[DoNotMerge]Updated swagger to include isSftpEnabled property#11597
Closed
dhanvia wants to merge 3 commits intoAzure:masterfrom
dhanvia:dhanvia/update_swagger_isSftpEnabled_account_property
Closed
[DoNotMerge]Updated swagger to include isSftpEnabled property#11597dhanvia wants to merge 3 commits intoAzure:masterfrom dhanvia:dhanvia/update_swagger_isSftpEnabled_account_property
dhanvia wants to merge 3 commits intoAzure:masterfrom
dhanvia:dhanvia/update_swagger_isSftpEnabled_account_property
Conversation
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
1 similar comment
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python
- Breaking Change detected in SDK
|
azure-resource-manager-schemas
|
azure-sdk-for-go
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java
|
azure-sdk-for-python-track2
- Breaking Change detected in SDK
|
azure-sdk-for-net
|
azure-sdk-for-js
|
This was referenced Nov 9, 2020
This was referenced Nov 9, 2020
Contributor
|
Hi @dhanvia, is the PR ready to merge now? |
Author
|
Hi, dhanvia. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Juliehzl
added
the
DoNotMerge
dhanvia
changed the title
Author
Author
|
@Juliehzl I am unable to merge this PR, because of the DoNotMerge label, and I am unable to edit that label aswell. Can you please check ? |
dhanvia
removed
the
DoNotMerge
Member
|
@dhanvia If not, we should not merge the API change before server is ready. |
pilor
added
the
ARMSignedOff
pilor
approved these changes
Jan 28, 2021
Author
Member
|
I have tried to register AllowSFTP for my subscription, but get failure "The feature 'AllowSFTP' does not support registration." See details below. |
Author
|
@blueww The AFEC registration is open only for internal customers. It is not open for public yet. |
Member
|
@dhanvia |
Author
|
@blueww / @pilor I had to update June19 version aswell, as the server supports this feature in the June19 template. Can you please review. This Need not be merged yet, but would later have to be merged when the property is opened for public |
dhanvia
changed the title
dhanvia
added
the
DoNotMerge
|
Hi, @dhanvia. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
25 tasks
3 tasks
Member
|
Hi @dhanvia, Is there any ETA from server side that open this feature for public? |
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.