fix servicefabric allOf and duplicate Operations_List

[ctaggart]

It appears to be some mistakes using allOf in a few places. Operations_List is also duplicated. This fixes both issues so that a code generator I'm using works.

[openapi-pipeline-app]

Swagger Validation Report

️❌BreakingChange: 23 Errors, 0 Warnings failed [Detail] [Expand]

Only 10 items are listed, please refer to log for more details.

• Compared Swaggers (Based on Oad v0.8.1)
  • original: preview/2020-01-01-preview/managedcluster.json <---> new: preview/2020-01-01-preview/managedcluster.json
  • original: preview/2020-01-01-preview/nodetype.json <---> new: preview/2020-01-01-preview/nodetype.json
  • original: stable/2020-03-01/application.json <---> new: stable/2020-03-01/application.json
  • original: stable/2020-03-01/cluster.json <---> new: stable/2020-03-01/cluster.json

Rule	Message
❌ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.ServiceFabric/operations' removed or restructured? New: azure-rest-api-specs/blob/a751dcc71626fa197fc400805044f82c4fc8f619/ Old: Microsoft.ServiceFabric/stable/2020-03-01/cluster.json#L465:5
❌ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.ServiceFabric/operations' removed or restructured? New: azure-rest-api-specs/blob/a751dcc71626fa197fc400805044f82c4fc8f619/ Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L37:5
❌ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.ServiceFabric/operations' removed or restructured? New: azure-rest-api-specs/blob/a751dcc71626fa197fc400805044f82c4fc8f619/ Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L37:5
❌ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L214:13 Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L214:13
❌ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L208:13 Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L208:13
❌ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L220:13 Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L220:13
❌ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L275:13 Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L275:13
❌ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L281:13 Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L281:13
❌ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L565:5 Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L565:5
❌ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.ServiceFabric/stable/2020-03-01/cluster.json#L628:5 Old: Microsoft.ServiceFabric/stable/2020-03-01/cluster.json#L664:5

️❌~[Staging] LintDiff: 1 Errors, 0 Warnings failed [Detail] [Expand]

• Linted configuring files (Based on source branch, openapi-validator v1.5.0 , classic-openapi-validator v1.1.4 )
  • servicefabric/resource-manager/readme.md tag:package-2020-03
• Linted configuring files (Based on target branch, openapi-validator v1.5.0 , classic-openapi-validator v1.1.4 )
  • servicefabric/resource-manager/readme.md tag:package-2020-03

Rule	Message
❌ R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.ServiceFabric/operations' does not match the ARM specification. Please standardize the schema. New: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L342

️❌~[Staging] Avocado: 1 Errors, 1 Warnings failed [Detail] [Expand]

Rule	Message
❌ UNREFERENCED_JSON_FILE	The example JSON file is not referenced from the swagger file. readme: specification/servicefabric/resource-manager/readme.md json: preview/2020-01-01-preview/examples/Operations_example.json
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/servicefabric/resource-manager/readme.md tag: specification/servicefabric/resource-manager/readme.md#tag-package-2020-03

️️✔️~[Staging] ModelValidation succeeded [Detail]

Validation passes for ModelValidation.

️️✔️~[Staging] SemanticValidation succeeded [Detail]

Validation passes for SemanticValidation.

️️✔️~[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail]

There are no breaking changes.

️️✔️~[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail]

There are no breaking changes.

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Swagger Generation Artifacts

️️✔️~[Staging] ApiDocPreview succeeded [Detail]

 Please click here to preview with your @microsoft account. 

_{Posted by Swagger Pipeline | How to fix these errors?}

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[openapi-sdkautomation]

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

[openapi-sdkautomation]

azure-sdk-for-go

️✔️ succeeded [Logs] [Expand Details]

• ️✔️ Generate from a751dcc with merge commit 57316c0760292e5e41b24ff79bbf98c9cf498d26. SDK Automation 13.0.17.20200918.2
• ️✔️preview/servicefabric/mgmt/2017-07-01-preview [View full logs]  [Preview SDK Changes]
  • preview.servicefabric.mgmt.2017-07-01-preview.zip
• ️✔️preview/servicefabric/mgmt/2018-02-01-preview [View full logs]  [Preview SDK Changes]
  • preview.servicefabric.mgmt.2018-02-01-preview.zip
• ️✔️preview/servicefabric/mgmt/2019-03-01-preview [View full logs]  [Preview SDK Changes]
  • preview.servicefabric.mgmt.2019-03-01-preview.zip
• ️✔️servicefabric/mgmt/2016-09-01 [View full logs]  [Preview SDK Changes]
  • servicefabric.mgmt.2016-09-01.zip
• ️✔️servicefabric/mgmt/2019-03-01 [View full logs]  [Preview SDK Changes]
  • servicefabric.mgmt.2019-03-01.zip

[openapi-sdkautomation]

azure-sdk-for-python

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]

• ⚠️ Generate from a751dcc with merge commit 57316c0760292e5e41b24ff79bbf98c9cf498d26. SDK Automation 13.0.17.20200918.2
• ⚠️azure-mgmt-servicefabric [View full logs]  [Preview SDK Changes] Breaking Change Detected
  • azure-mgmt-servicefabric-0.5.0.zip
  • azure_mgmt_servicefabric-0.5.0-py2.py3-none-any.whl

  [build_conf] INFO:packaging_tools:Building template azure-mgmt-servicefabric
  [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
  [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
  [build_conf] INFO:packaging_tools:Template done azure-mgmt-servicefabric
  [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
  [build_package]   warnings.warn(msg)
  [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
  [build_package]   warnings.warn(msg)
  [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
  [ChangeLog] Size of delta 0.350% size of original (original: 72640 chars, delta: 254 chars)
  [ChangeLog] **Breaking changes**
  [ChangeLog] 
  [ChangeLog]   - Model ManagedCluster no longer has parameter use_test_extension
  [ChangeLog]   - Model ManagedCluster no longer has parameter reverse_proxy_endpoint_port
  [ChangeLog]   - Model ManagedClusterUpdateParameters no longer has parameter reverse_proxy_endpoint_port

[openapi-sdkautomation]

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

• ️✔️ Generate from a751dcc with merge commit 57316c0760292e5e41b24ff79bbf98c9cf498d26. SDK Automation 13.0.17.20200918.2

  [AutoRest] realpath(): Permission denied
  [AutoRest] realpath(): Permission denied
  [AutoRest] realpath(): Permission denied
  [AutoRest] realpath(): Permission denied
  [AutoRest] realpath(): Permission denied
  [AutoRest] realpath(): Permission denied

• ️✔️Microsoft.Azure.Management.ServiceFabric [View full logs]  [Preview SDK Changes]
  • Microsoft.Azure.Management.ServiceFabric.1.3.0.nupkg
  • Microsoft.Azure.Management.ServiceFabric.1.3.0.snupkg

[openapi-sdkautomation]

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]

• ⚠️ Generate from a751dcc with merge commit 57316c0760292e5e41b24ff79bbf98c9cf498d26. SDK Automation 13.0.17.20200918.2
• ️✔️sdk/servicefabric/mgmt-v2016_09_01 [View full logs]  [Preview SDK Changes]
  • pom.xml
  • azure-mgmt-servicefabric-1.0.0-beta-javadoc.jar
  • azure-mgmt-servicefabric-1.0.0-beta-sources.jar
  • azure-mgmt-servicefabric-1.0.0-beta.jar
• ⚠️sdk/servicefabric/mgmt-v2017_07_01_preview [View full logs]  [Preview SDK Changes]

  [mvn] [ERROR] COMPILATION ERROR : 
  [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[40,22] no suitable method found for createAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner)
  [mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner,com.microsoft.rest.ServiceCallback) is not applicable
  [mvn]       (actual and formal argument lists differ in length)
  [mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner) is not applicable
  [mvn]       (actual and formal argument lists differ in length)
  [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[54,22] no suitable method found for updateAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters)
  [mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters,com.microsoft.rest.ServiceCallback) is not applicable
  [mvn]       (actual and formal argument lists differ in length)
  [mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters) is not applicable
  [mvn]       (actual and formal argument lists differ in length)
  [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-servicefabric: Compilation failure: Compilation failure: 
  [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[40,22] no suitable method found for createAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner)
  [mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner,com.microsoft.rest.ServiceCallback) is not applicable
  [mvn] [ERROR]       (actual and formal argument lists differ in length)
  [mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner) is not applicable
  [mvn] [ERROR]       (actual and formal argument lists differ in length)
  [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[54,22] no suitable method found for updateAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters)
  [mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters,com.microsoft.rest.ServiceCallback) is not applicable
  [mvn] [ERROR]       (actual and formal argument lists differ in length)
  [mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters) is not applicable
  [mvn] [ERROR]       (actual and formal argument lists differ in length)
  [mvn] [ERROR] -> [Help 1]
  [mvn] [ERROR] 
  [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
  [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
  [mvn] [ERROR] 
  [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
  [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

• ️✔️sdk/servicefabric/mgmt-v2018_02_01 [View full logs]  [Preview SDK Changes]
  • pom.xml
  • azure-mgmt-servicefabric-1.0.0-beta-javadoc.jar
  • azure-mgmt-servicefabric-1.0.0-beta-sources.jar
  • azure-mgmt-servicefabric-1.0.0-beta.jar

[openapi-sdkautomation]

azure-sdk-for-python-track2

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

[openapi-sdkautomation]

azure-resource-manager-schemas

️✔️ succeeded [Logs] [Expand Details]

• ️✔️ Generate from a751dcc with merge commit 57316c0760292e5e41b24ff79bbf98c9cf498d26. Schema Automation 13.0.17.20200918.2

  [servicefabric][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
  [servicefabric][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
  [servicefabric][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend

• ️✔️servicefabric [View full logs]  [Preview Schema Changes]

  [after_scripts|node] PostProcessor finished successfully.
  [after_scripts|node]   5822 passing (1m)
  AzureResourceSchema has no registered package commands.

[openapi-sdkautomation]

Trenton Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

[openapi-sdkautomation]

azure-sdk-for-js

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

[openapi-workflow-bot]

Hi @ctaggart, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

[jianyexi]

@ctaggart please fix the CI errors , then we can go on reviewing

[ctaggart]

I was just trying to help, but I ran out of time to contribute here. I'll reopen if I find more time to help out.