reuse ControllerDetails definition in dnc 2020-08-08-preview#11578
Closed
ctaggart wants to merge 1 commit intoAzure:masterfrom
Closed
reuse ControllerDetails definition in dnc 2020-08-08-preview#11578ctaggart wants to merge 1 commit intoAzure:masterfrom
ctaggart wants to merge 1 commit intoAzure:masterfrom
Conversation
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is missing a definition that was found in the old version. Was 'subnetDetails' removed or renamed? New: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/delegatedSubnets.json#L311:3 Old: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/delegatedSubnets.json#L311:3 |
|
The new version is missing a definition that was found in the old version. Was 'controllerDetails' removed or renamed? New: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/delegatedSubnets.json#L311:3 Old: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/delegatedSubnets.json#L311:3 |
️️✔️~[Staging] LintDiff succeeded [Detail]
Validation passes for LintDiff.
️️✔️~[Staging] Avocado succeeded [Detail]
Validation passes for Avocado.
️️✔️~[Staging] ModelValidation succeeded [Detail]
Validation passes for ModelValidation.
️️✔️~[Staging] SemanticValidation succeeded [Detail]
Validation passes for SemanticValidation.
️️✔️~[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail]
There are no breaking changes.
️️✔️~[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail]
There are no breaking changes.
Swagger Generation Artifacts
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-resource-manager-schemas
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java
|
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net
|
Contributor
Author
|
See #10819. It made these two definitions: orchestrators.json "ControllerDetails": {
"description": "controller details",
"type": "object",
"properties": {
"id": {
"description": "controller arm resource id",
"type": "string"
}
}
},delegatedSubnets.json "controllerDetails": {
"description": "controller details",
"type": "object",
"properties": {
"id": {
"description": "controller arm resource id",
"type": "string"
}
}
}, |
|
Hi @ctaggart, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi, ctaggart. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
added
the
Contributor
Author
|
This pull request should have been reviewed and merged, but it was not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A code generator I'm using generates duplicate
ControllerDetailstypes for dnc 2020-08-08-preview. It is defining the type in two different input files instead of just using references. It should also reference common types for the common parameters instead of duplicating them. This pull request, just reuses aControllerDetailsdefinition, which fixes it for the code generator I'm using.input-file: