add datafactory track2 config and fix swagger#11563
Closed
00Kai0 wants to merge 3 commits intoAzure:masterfrom
Closed
add datafactory track2 config and fix swagger#1156300Kai0 wants to merge 3 commits intoAzure:masterfrom
00Kai0 wants to merge 3 commits intoAzure:masterfrom
Conversation
Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
|
| Rule | Message |
|---|---|
|
Must not have duplicate name of x-ms-enum extension , make sure every x-ms-enum name unique. The duplicate x-ms-enum name: compressioncodec, path: $.DelimitedTextDatasetTypeProperties.properties.compressionCodec Location: stable/2018-06-01/entityTypes/Dataset.json#L746 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌[Staging] SDK Track2 Validation: 2 Errors, 294 Warnings failed [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"datafactory/resource-manager/readme.md", "tag":"package-2018-06", "details":"Duplicate Schema named BlobEventTypes -- type: undefined => "string", items: "$ref":"#/components/schemas/BlobEventTypes" =>, enum: undefined => ["Microsoft.Storage.BlobCreated", "Microsoft.Storage.BlobDeleted"], x-ms-enum: undefined => "name":"BlobEventTypes", "modelAsString":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"datafactory/resource-manager/readme.md", "tag":"package-2018-06", "details":"Error: Plugin prechecker reported failure." |
| "readme":"datafactory/resource-manager/readme.md", "tag":"package-2018-06", "details":"The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"datafactory/resource-manager/readme.md", "tag":"package-2018-06", "details":"The schema 'SubResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"datafactory/resource-manager/readme.md", "tag":"package-2018-06", "details":"The schema 'SubResourceDebugResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"datafactory/resource-manager/readme.md", "tag":"package-2018-06", "details":"The schema 'IntegrationRuntimeReference' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"datafactory/resource-manager/readme.md", "tag":"package-2018-06", "details":"The schema 'IntegrationRuntimeResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"datafactory/resource-manager/readme.md", "tag":"package-2018-06", "details":"The schema 'IntegrationRuntimeDebugResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"datafactory/resource-manager/readme.md", "tag":"package-2018-06", "details":"The schema 'IntegrationRuntimeStatusResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"datafactory/resource-manager/readme.md", "tag":"package-2018-06", "details":"The schema 'FactoryRepoUpdate' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation
|
azure-sdk-for-go
|
azure-sdk-for-python
|
azure-sdk-for-net
|
azure-resource-manager-schemas
|
azure-sdk-for-js
|
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java
|
|
Hi @00Kai0, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
00Kai0
added
the
DoNotMerge
|
Azure Pipelines successfully started running 1 pipeline(s). |
00Kai0
force-pushed
the
kaihuis-track2-datafactory
branch
from
007e4ea to
a67f1b2
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hi, @00Kai0. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
added
the
00Kai0
force-pushed
the
kaihuis-track2-datafactory
branch
from
a67f1b2 to
c50d4c2
Compare
|
Hi @00Kai0, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
Member
|
One additional issue for Java is that And naming conflict here https://github.com/Azure/azure-rest-api-specs/blob/master/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Trigger.json#L340-L354 |
qiaozha
reviewed
Mar 15, 2021
| "CompressionLevel": { | ||
| "title": "Microsoft.Azure.Management.DataFactories.Models.CompressionLevel", | ||
| "description": "All available compression levels.", | ||
| "type": "object", |
Member
There was a problem hiding this comment.
I don't think string is going to work for datafactory. This is meant to be oneOf scenario and swagger 2.0 hasn't supported oneOf yet.
Member
There was a problem hiding this comment.
It has to be string as "modelAsString": true" below.
If it is not string, modelAsString should be false, and format need to be provided.
Member
There was a problem hiding this comment.
Not that, In datafactory, this kind of property can be either enum string or Expression type. we need to use oneOf to express such scenario which is only supported in swagger 3.0, but currently we are using swagger 2.0 and I believe, we don't have plan to upgrade to swagger 3.0 at least in recent months.
Member
There was a problem hiding this comment.
I think I get you. But even if this is supported by swagger, it will not be supported by SDK, at least not Java. We will not return anything like such: it could be enum, it could be string otherwise not included in the enum, or it could be an object of undefined schema, as there is no Expression anywhere in this def.
Hence Java will not release for datafactory.
qiaozha
reviewed
Mar 15, 2021
| Please also specify `--python-sdks-folder=<path to the root directory of your azure-sdk-for-python clone>`. | ||
| Use `--python-mode=update` if you already have a setup.py and just want to update the code itself. | ||
|
|
||
| ``` yaml $(python) |
Member
There was a problem hiding this comment.
I don't think we still need this since we already have readme.python.md.
Member
Member
|
@jsntcy yes it is |
Contributor
Author
|
New PR at:#13398 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix gen error: