Swagger changes for workspace git configuration APIs#11534
Closed
praveenmathamsetty wants to merge 3 commits intoAzure:masterfrom
Closed
Swagger changes for workspace git configuration APIs#11534praveenmathamsetty wants to merge 3 commits intoAzure:masterfrom
praveenmathamsetty wants to merge 3 commits intoAzure:masterfrom
Conversation
Swagger Validation Report
|
| Rule | Message |
|---|---|
| 'gitHubAccessTokenRequest' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. New: Microsoft.Synapse/preview/2019-06-01-preview/gitintegration.json#L52 |
|
| 'api-version' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. New: Microsoft.Synapse/preview/2019-06-01-preview/gitintegration.json#L46 |
|
| The response of operation:'BigDataPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.Synapse/preview/2020-10-01-preview/bigDataPool.json#L25 |
|
| The response of operation:'BigDataPools_Update' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.Synapse/preview/2020-10-01-preview/bigDataPool.json#L78 |
|
| The response of operation:'BigDataPools_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.Synapse/preview/2020-10-01-preview/bigDataPool.json#L142 |
|
| The response of operation:'BigDataPools_ListByWorkspace' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.Synapse/preview/2020-10-01-preview/bigDataPool.json#L292 |
|
| The response of operation:'IpFirewallRules_ListByWorkspace' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.Synapse/preview/2020-10-01-preview/firewallRule.json#L25 |
|
| The response of operation:'IpFirewallRules_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.Synapse/preview/2020-10-01-preview/firewallRule.json#L75 |
|
| The response of operation:'IpFirewallRules_Get' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.Synapse/preview/2020-10-01-preview/firewallRule.json#L203 |
️⚠️~[Staging] Avocado: 1 Warnings warning [Detail] [Expand]
| Rule | Message |
|---|---|
| The JSON file has a circular reference. readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2020-10-01-preview/workspace.json |
️️✔️~[Staging] ModelValidation succeeded [Detail]
Validation passes for ModelValidation.
️️✔️~[Staging] SemanticValidation succeeded [Detail]
Validation passes for SemanticValidation.
️⚠️~[Staging] Cross Version BreakingChange (Base on preview version): 39 Warnings warning [Detail] [Expand]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.1)
- original: preview/2019-06-01-preview/bigDataPool.json <---> new: preview/2020-10-01-preview/bigDataPool.json
- original: preview/2019-06-01-preview/checkNameAvailability.json <---> new: preview/2020-10-01-preview/checkNameAvailability.json
- original: preview/2019-06-01-preview/firewallRule.json <---> new: preview/2020-10-01-preview/firewallRule.json
- original: preview/2019-06-01-preview/integrationRuntime.json <---> new: preview/2020-10-01-preview/integrationRuntime.json
- original: preview/2019-06-01-preview/keys.json <---> new: preview/2020-10-01-preview/keys.json
- original: preview/2020-04-01-preview/operations.json <---> new: preview/2020-10-01-preview/operations.json
- original: preview/2019-06-01-preview/privateEndpointConnections.json <---> new: preview/2020-10-01-preview/privateEndpointConnections.json
- original: preview/2019-06-01-preview/privateLinkResources.json <---> new: preview/2020-10-01-preview/privateLinkResources.json
- original: preview/2019-06-01-preview/privatelinkhub.json <---> new: preview/2020-10-01-preview/privatelinkhub.json
- original: preview/2020-04-01-preview/sqlPool.json <---> new: preview/2020-10-01-preview/sqlPool.json
- original: preview/2019-06-01-preview/workspace.json <---> new: preview/2020-10-01-preview/workspace.json
| Rule | Message |
|---|
️️✔️~[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail]
There are no breaking changes.
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
RestBuild error |
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=172670&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory" |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
azure-sdk-for-net
|
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go
|
azure-sdk-for-java
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js
|
This was referenced Nov 4, 2020
18b25be to
3781ca3
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
2f35ae5 to
e2944b5
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
e2944b5 to
8cb463f
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
8cb463f to
013fab9
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
013fab9 to
04858ac
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
04858ac to
8646215
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
66e91cf to
9e0b396
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
9e0b396 to
f5c8075
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
f5c8075 to
8250631
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
8250631 to
964ee97
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
964ee97 to
084f5e4
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
1971cc1 to
084f5e4
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.