Skip to content

Text Analytics v3.1preview.3 deserialization fixes for SDK #11530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmazuel merged 2 commits into from
Nov 5, 2020
Merged

Text Analytics v3.1preview.3 deserialization fixes for SDK #11530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
993c64c
Updates to the Swagger to fix a few deserialization problems for the SDK
Nov 3, 2020
709ffd6
Merge branch 'master' of github.com:Azure/azure-rest-api-specs into a…
Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions ...tion/cognitiveservices/data-plane/TextAnalytics/preview/v3.1-preview.3/TextAnalytics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
"summary": "Get analysis status and results",
"parameters": [
{
"$ref": "#/parameters/JobId"
"$ref": "#/parameters/AnalyzeJobId"
Copy link
Member

@deyaaeldeen deyaaeldeen Nov 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that because of the uuid issue?

Copy link
Contributor Author

@abhahn abhahn Nov 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I decided to add a new value for the job ID for Analyze because Guid has already been implemented for the Healthcare service and I didn't want to break anything. The service team who owns the Analyze frontend has told us that they won't have time to change their job ID to a Guid in time for the preview release.

},
{
"$ref": "#/parameters/ShowStats"
Expand Down Expand Up @@ -1045,10 +1045,12 @@
"tasks": {
"properties": {
"details": {
"items": {
"$ref": "#/definitions/TaskState"
"properties": {
"allof": {
"$ref": "#/definitions/TaskState"
}
},
"type": "array"
"type": "object"
},
"completed": {
"type": "integer"
Expand Down Expand Up @@ -2257,6 +2259,14 @@
"type": "string",
"x-ms-parameter-location": "method"
},
"AnalyzeJobId": {
"description": "Job ID for Analyze",
"in": "path",
"name": "jobId",
"required": true,
"type": "string",
"x-ms-parameter-location": "method"
},
"ShowStats": {
"name": "showStats",
"in": "query",
Expand Down
4 changes: 2 additions & 2 deletions specification/cognitiveservices/data-plane/TextAnalytics/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,9 @@ input-file: preview/v3.1-preview.2/TextAnalytics.json

### Release 3.1-Preview.3

These settings apply only when `--tag=release_3_2_preview.1` is specified on the command line.
These settings apply only when `--tag=release_3_1_preview.3` is specified on the command line.

``` yaml $(tag) == 'release_3_2_preview.1'
``` yaml $(tag) == 'release_3_1_preview.3'
input-file: preview/v3.1-preview.3/TextAnalytics.json
```

Expand Down
10 changes: 5 additions & 5 deletions specification/cognitiveservices/data-plane/TextAnalytics/readme.python.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ no-namespace-folders: true
batch:
- tag: release_3_0
- tag: release_3_1_preview.2
- tag: release_3_2_preview.1
- tag: release_3_1_preview.3
- multiapiscript: true
```

Expand Down Expand Up @@ -48,8 +48,8 @@ namespace: azure.ai.textanalytics.v3_1_preview_2
output-folder: $(python-sdks-folder)/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/v3_1_preview_2
```

### Tag: release_3_2_preview_1
``` yaml $(tag) == 'release_3_2_preview.1'
namespace: azure.ai.textanalytics.v3_2_preview_1
output-folder: $(python-sdks-folder)/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/v3_2_preview_1
### Tag: release_3_1_preview_3
``` yaml $(tag) == 'release_3_1_preview.3'
namespace: azure.ai.textanalytics.v3_1_preview_3
output-folder: $(python-sdks-folder)/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/v3_1_preview_3
```