Skip to content

Conversation

@sjd8078
Copy link
Contributor

@sjd8078 sjd8078 commented Nov 3, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @sjd8078 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 3, 2020

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail]
    There are no breaking changes.
    ️️✔️~[Staging] LintDiff succeeded [Detail]
    Validation passes for LintDiff.
    ️️✔️~[Staging] Avocado succeeded [Detail]
    Validation passes for Avocado.
    ️️✔️~[Staging] ModelValidation succeeded [Detail]
    Validation passes for ModelValidation.
    ️️✔️~[Staging] SemanticValidation succeeded [Detail]
    Validation passes for SemanticValidation.
    ️️✔️~[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail]
    There are no breaking changes.
    ️️✔️~[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail]
    There are no breaking changes.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 3, 2020

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 46b42a6. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	python3 -m venv venv
      command	pip install --upgrade setuptools wheel pip
      command	pip install pathlib jinja2 msrestazure
      command	autorest --version=V2 [email protected]/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/digitaltwins/data-plane/readme.md
      warn	No package detected after generation
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 46b42a6. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2020-12-12 01:25:30 ERROR [Skip] readme path does not format as specification/*/resource-manager/readme.md
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 46b42a6. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/digitaltwins/data-plane/readme.md
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 46b42a6. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/digitaltwins/2020-05-31-preview/digitaltwins [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️️✔️~[Staging] ApiDocPreview succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 3, 2020

    Azure CLI Extension Generation

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 3, 2020

    azure-sdk-for-go

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 9f2b9fb with merge commit 9e3208daa72eb5f92badb088b5ee7cb6f6332d68. SDK Automation 13.0.17.20200918.2
      Failed to find any diff after autorest so no changed packages was found.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 3, 2020

    azure-sdk-for-java

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 9f2b9fb with merge commit 9e3208daa72eb5f92badb088b5ee7cb6f6332d68. SDK Automation 13.0.17.20200918.2
      Failed to find any diff after autorest so no changed packages was found.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 3, 2020

    azure-sdk-for-python

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 9f2b9fb with merge commit 9e3208daa72eb5f92badb088b5ee7cb6f6332d68. SDK Automation 13.0.17.20200918.2
      Failed to find any changed packages. Please check the changed file list.
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_03_01_preview/__init__.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_10_31/_azure_digital_twins_management_client.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/_configuration.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/CHANGELOG.md
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/MANIFEST.in
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/README.md
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/__init__.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/__init__.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/__init__.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/_azure_digital_twins_management_client.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/models.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_03_01_preview/_azure_digital_twins_management_client.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_03_01_preview/_configuration.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_03_01_preview/models/__init__.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_03_01_preview/models/_azure_digital_twins_management_client_enums.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_03_01_preview/models/_models.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_03_01_preview/models/_models_py3.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_03_01_preview/models/_paged_models.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_03_01_preview/operations/__init__.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_03_01_preview/operations/_digital_twins_endpoint_operations.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_03_01_preview/operations/_digital_twins_operations.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_03_01_preview/operations/_operations.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_10_31/__init__.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_10_31/_configuration.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_10_31/models/__init__.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_10_31/models/_azure_digital_twins_management_client_enums.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_10_31/models/_models.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_10_31/models/_models_py3.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_10_31/models/_paged_models.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_10_31/operations/_digital_twins_endpoint_operations.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_10_31/operations/_digital_twins_operations.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_10_31/operations/_operations.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_10_31/version.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/version.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/sdk_packaging.toml
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/setup.cfg
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/setup.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/ci.yml
      /z/work/azure-sdk-for-python/sdk/digitaltwins/models/__init__.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/models/_models.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/models/_models_py3.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/models/_paged_models.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_10_31/operations/__init__.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/operations/_digital_twin_models_operations.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/operations/_digital_twins_operations.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/operations/_event_routes_operations.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/operations/_query_operations.py
      /z/work/azure-sdk-for-python/sdk/digitaltwins/azure-mgmt-digitaltwins/azure/mgmt/digitaltwins/v2020_03_01_preview/version.py

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 3, 2020

    Trenton Generation

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 3, 2020

    azure-resource-manager-schemas

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 3, 2020

    azure-sdk-for-net

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 3, 2020

    azure-sdk-for-js

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 9f2b9fb with merge commit 9e3208daa72eb5f92badb088b5ee7cb6f6332d68. SDK Automation 13.0.17.20200918.2
      Failed to find any diff after autorest so no changed packages was found.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 11, 2020

    azure-sdk-for-python-track2

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @lmazuel lmazuel merged commit 46b42a6 into Azure:master Dec 12, 2020
    dabenhamMic pushed a commit to dabenhamMic/azure-rest-api-specs that referenced this pull request Dec 14, 2020
    * removed unused metadata fields from api response examples
    
    * removed  from component metadata example responses
    
    * Removed component model from 05-31-preview example responses
    
    Co-authored-by: Samuel Davis <[email protected]>
    giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020
    * removed unused metadata fields from api response examples
    
    * removed  from component metadata example responses
    
    * Removed component model from 05-31-preview example responses
    
    Co-authored-by: Samuel Davis <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants