Added event grid filters read APIs for Microsoft.AppConfiguration.#11451
Closed
jimmyca15 wants to merge 3 commits intoAzure:masterfrom
Closed
Added event grid filters read APIs for Microsoft.AppConfiguration.#11451jimmyca15 wants to merge 3 commits intoAzure:masterfrom
jimmyca15 wants to merge 3 commits intoAzure:masterfrom
Conversation
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is adding a path that was not found in the old version. New: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L1017:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L1069:5 |
️⚠️~[Staging] LintDiff: 2 Warnings warning [Detail] [Expand]
- Linted configuring files (Based on source branch, openapi-validator v1.5.0 , classic-openapi-validator v1.1.4 )
- Linted configuring files (Based on target branch, openapi-validator v1.5.0 , classic-openapi-validator v1.1.4 )
| Rule | Message |
|---|---|
| The response of operation:'EventGridFilters_ListByConfigurationStore' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L1018 |
|
| The response of operation:'EventGridFilters_Get' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L1070 |
️️✔️~[Staging] Avocado succeeded [Detail]
Validation passes for Avocado.
️️✔️~[Staging] ModelValidation succeeded [Detail]
Validation passes for ModelValidation.
️️✔️~[Staging] SemanticValidation succeeded [Detail]
Validation passes for SemanticValidation.
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-js
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go
|
azure-sdk-for-java
|
azure-sdk-for-net
|
This was referenced Oct 29, 2020
This was referenced Oct 29, 2020
|
@jimmyca15 Please fix the model validation error |
PhoenixHe-NV
added
the
Reviewed-ChangesRequested
Swagger Generation Artifacts
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2
- Breaking Change detected in SDK
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
@PhoenixHe-msft fixed. |
Member
Author
|
@PhoenixHe-msft I'm thinking this should be good to merge now. Is anything else needed? |
Member
Author
|
Swagger live validation is going to exclude this operation so we don't need to document it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Microsoft.AppConfiguration supports sending to events to event grid. Thus we implement the standard /eventGridFilters API. These have been called out as undocumented by live validation.
Autorest validation results in no errors.