Merged
Conversation
This file is currently in review in another PR
PR already raised for them
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is adding a path that was not found in the old version. New: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L1298:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L4269:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L4467:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L4521:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L4740:5 |
️⚠️~[Staging] LintDiff: 1 Warnings warning [Detail] [Expand]
- Linted configuring files (Based on source branch, openapi-validator v1.5.0 , classic-openapi-validator v1.1.4 )
- Linted configuring files (Based on target branch, openapi-validator v1.5.0 , classic-openapi-validator v1.1.4 )
| Rule | Message |
|---|---|
| 'DataMaskingPolicy' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L6610 |
️️✔️~[Staging] Avocado succeeded [Detail]
Validation passes for Avocado.
️️✔️~[Staging] ModelValidation succeeded [Detail]
Validation passes for ModelValidation.
️️✔️~[Staging] SemanticValidation succeeded [Detail]
Validation passes for SemanticValidation.
️️✔️~[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail]
There are no breaking changes.
️️✔️~[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail]
There are no breaking changes.
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @kashyap-kunal your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @raych1 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi, @kashyap-kunal Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-net - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JeffreyRichter
approved these changes
Nov 2, 2020
JeffreyRichter
added
the
Approved-BreakingChange
Member
|
@kashyap-kunal , please ping ARM review board(armapireview@microsoft.com) to get this PR reviewed by ARM. |
Swagger Generation Artifacts
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
[Billing] Update readme.az.md for 2nd phase requests (Azure#11438)
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Based on the comments from Amogh and Kunal "The APIs here are all being proxied to SQL RP and thus we’ve added the corresponding Swagger on our side to be compliant with the completeness and correctness requirement" |
chiragg4u
added
ARMSignedOff
Contributor
|
For breaking change please follow-up with the SDK team as newPath should not be a breaking change. |
raych1
approved these changes
Nov 6, 2020
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
* Workspace Managed Sql Server Proxy Apis. #907750 #923781 * Spelling mistakes fix * Lint issue fix * Fixing lint warnings * Fixing Lint issue * resolving review comment * Backup Comit * removing datawarehouse queries * Update custom-words.txt * removing due to conflict with Swetha's PR * removed sqlServer This file is currently in review in another PR * Removing conflicting file PR already raised for them * resolving lint issue * Fixing Avocado issue * Adding default response * Fixing avocado issues * resolving avocado issues * fixing issues * resolving breaking change * Removing conflicting code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.