Skip to content

Comments

Enable the creation of Java SDK for the Microsoft.Communication resource manager#11316

Merged
lirenhe merged 1 commit intomasterfrom
user/memontic/add-communication-java
Oct 26, 2020
Merged

Enable the creation of Java SDK for the Microsoft.Communication resource manager#11316
lirenhe merged 1 commit intomasterfrom
user/memontic/add-communication-java

Conversation

@memontic-ms
Copy link
Contributor

@memontic-ms memontic-ms commented Oct 21, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

openapi-workflow-bot bot commented Oct 21, 2020

Hi, @memontic-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 21, 2020 •
    edited
    Loading

    [Staging] Swagger Validation Report

    ️️✔️BreakingChange [Detail] 
     There are no breaking changes.
    ️️✔️LintDiff [Detail] 
     Validation passes for LintDiff.
    ️️✔️Avocado [Detail] 
     Validation passes for Avocado.
    ️️✔️ModelValidation [Detail] 
     Validation passes for ModelValidation.
    ️️✔️SemanticValidation [Detail] 
     Validation passes for SemanticValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @azure-pipelines
    Copy link

    azure-pipelines bot commented Oct 21, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @memontic-ms memontic-ms requested a review from usvoyager October 21, 2020 21:10
    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 21, 2020 •
    edited
    Loading

    azure-sdk-for-python - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from f730445 with merge commit 6da20ad. SDK Automation 13.0.17.20200918.2 
      [azure-mgmt-communication][breaking_change_report_pypi] WARNING:__main__:Version 1.0.0b2 seems to be too old to build a report (probably not Autorest based)
[azure-mgmt-communication][ChangeLog] WARNING: Failed to generate ChangeLog.
    • ⚠️azure-mgmt-communication [View full logs]  [Release SDK Changes] 
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-communication
[build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-communication
[build_conf] INFO:packaging_tools:Template done azure-mgmt-communication
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_report_pypi] WARNING:__main__:Version 1.0.0b2 seems to be too old to build a report (probably not Autorest based)
Not exact 2 reports found:
code_reports/latest/report.json
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 21, 2020 •
    edited
    Loading

    azure-sdk-for-java - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from f730445 with merge commit 6da20ad. SDK Automation 13.0.17.20200918.2 
      Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/AggregationType.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/CommunicationServiceCreateOrUpdateHeaders.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/CommunicationServiceDeleteHeaders.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/Dimension.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/ErrorResponse.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/ErrorResponseError.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/ErrorResponseException.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/KeyType.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/LinkNotificationHubParameters.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/LocationResource.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/MetricSpecification.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/OperationDisplay.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/OperationProperties.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/ProvisioningState.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/RegenerateKeyParameters.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/ServiceSpecification.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/Status.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/TaggedResource.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/implementation/CommunicationServiceKeysInner.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/implementation/CommunicationServiceManagementClientImpl.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/implementation/CommunicationServiceResourceInner.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/implementation/CommunicationServicesInner.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/implementation/LinkedNotificationHubInner.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/implementation/OperationInner.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/implementation/OperationStatusInner.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/implementation/OperationStatusesInner.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/implementation/OperationsInner.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/implementation/PageImpl.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/implementation/package-info.java
/z/work/azure-sdk-for-java/azure-mgmt-communication/src/main/java/com/microsoft/azure/management/communication/package-info.java

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 21, 2020 •
    edited
    Loading

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 21, 2020 •
    edited
    Loading

    azure-sdk-for-net - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from f730445 with merge commit 6da20ad. SDK Automation 13.0.17.20200918.2 
      [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Communication [View full logs]  [Release SDK Changes]
        No Artifact Generated.

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Oct 21, 2020 •
      edited
      Loading

      azure-sdk-for-js - Release

      ⚠️ warning [Logs] [Expand Details]
      • ⚠️ Generate from f730445 with merge commit 6da20ad. SDK Automation 13.0.17.20200918.2 
        Failed to find any diff after autorest so no changed packages was found.

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Oct 21, 2020 •
      edited
      Loading

      azure-sdk-for-go - Release

      ⚠️ warning [Logs] [Expand Details]

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Oct 21, 2020 •
      edited
      Loading

      azure-sdk-for-python-track2 - Release

      ⚠️ warning [Logs] [Expand Details]
      • ⚠️ Generate from f730445 with merge commit 6da20ad. SDK Automation 13.0.17.20200918.2 
        Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/2525: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"122","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 26 Oct 2020 08:19:43 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"07C0:0E06:2C4728:481C20:5F96869F","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4676","x-ratelimit-reset":"1603701479","x-ratelimit-used":"324","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/track2_azure-mgmt-communication@11316","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/2524: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"122","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 26 Oct 2020 08:19:43 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"07C4:03A8:33B54C3:563FC02:5F96869F","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4675","x-ratelimit-reset":"1603701479","x-ratelimit-used":"325","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/azure-mgmt-communication@11316","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse-error' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
[track2_azure-mgmt-communication][breaking_change_report_pypi] WARNING:__main__:Version 1.0.0b2 seems to be too old to build a report (probably not Autorest based)
[track2_azure-mgmt-communication][ChangeLog] WARNING: Failed to generate ChangeLog.
      • ⚠️azure-mgmt-communication [View full logs]  [Release SDK Changes] 
        [build_conf_init]   Cache entry deserialization failed, entry ignored
[build_conf_init]   Cache entry deserialization failed, entry ignored
[build_conf] INFO:packaging_tools:Building template azure-mgmt-communication
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-communication
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_report_pypi] WARNING:__main__:Version 1.0.0b2 seems to be too old to build a report (probably not Autorest based)
Not exact 2 reports found:
code_reports/latest/report.json
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Oct 21, 2020 •
      edited
      Loading

      azure-resource-manager-schemas - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Oct 21, 2020 •
      edited
      Loading

      Trenton Generation - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      This was referenced Oct 21, 2020
      Closed
      Closed
      Closed
      @usvoyager usvoyager changed the title Enable the creation of Java SDK for the Communication resource manager Enable the creation of Java SDK for the Microsoft.Communication resource manager Oct 22, 2020
      @lirenhe lirenhe merged commit 6da20ad into master Oct 26, 2020
      giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020
      @memontic-ms
      Add Java README for Azure Communication Services (Azure#11316)
      0f27527
      @JackTn JackTn deleted the user/memontic/add-communication-java branch August 9, 2021 10:17
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

      Reviewers

      @lirenhe lirenhe lirenhe approved these changes

      @usvoyager usvoyager usvoyager approved these changes

      Assignees

      @lirenhe lirenhe

      Labels

      None yet

      Projects

      None yet

      Milestone

      No milestone

      Development

      Successfully merging this pull request may close these issues.

      3 participants

      @memontic-ms @lirenhe @usvoyager