Add delete incident comment API by roherzbe · Pull Request #11297 · Azure/azure-rest-api-specs

roherzbe · 2020-10-20T09:17:10Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

AutorestCI · 2020-10-20T09:17:14Z

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask tih@microsoft.com (or NullMDR in github) for additional help.

openapi-pipeline-app · 2020-10-20T09:17:15Z

[Staging] Swagger Validation Report

️❌BreakingChange: 6 Errors, 0 Warnings [Detail] [Expand]

Rule	Message
`❌` 1011 - AddingResponseCode	The new version adds a response code '200'. New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L3189:11
`❌` 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L7020:11 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L6965:11
`❌` 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L3139:13 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L3139:13
`❌` 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L3162:9 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L3162:9
`❌` 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L3197:13 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L3191:13
`❌` 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L6994:5 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L6939:5

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

ghost · 2020-10-20T09:17:16Z

Thank you for your contribution roherzbe! We will review the pull request and get back to you soon.

openapi-workflow-bot · 2020-10-20T09:19:33Z

Hi, @roherzbe Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

…pecs

openapi-workflow-bot · 2020-10-20T15:38:16Z

Hi, @roherzbe your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @leni-msft

roherzbe · 2020-10-20T16:36:54Z

Hi @leni-msft,

According to the automatic validations it marks that there are 6 Errors & Breaking Changes, all other validations have passed successfully (as far as I can tell).
I looked into the details of these errors and understand the breaking changes were caused by:
• Adding response call 200 (to an API that returned only 201 beforehand).
• Adding an Etag field to the resource that is received/sent.

Can you please help me understand why these changes are breaking?
From my understanding and testing if something is added and optional it shouldn’t break previous behavior.

Thanks in advance,
Rotem

pilor · 2020-10-20T17:30:04Z

...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json

          }
        ],
        "responses": {
+          "200": {


Are these swagger bugfixes to bring swagger in-line with how the API has always behaved? If not, these should go into a new api-version as the existing preview version is almost 2 years old.

Yes, this is a bug fix. It exists in production for more then half a year and has no costumer impact (not breaking any scenario). We are aware that in the stable version this kind of change will require a new version.

pilor

Swagger fixes for API surface that was already present. Please work with @leni-msft to deal with any SDK breaking issues and for merging this

roherzbe · 2020-10-21T20:02:52Z

@pilor Thank you very much!
@leni-msft what else needs to be done in order to merge this PR? thanks in advance :)

openapi-workflow-bot · 2020-10-22T05:38:53Z

Hi @roherzbe, one or multiple breaking change(s) is detected in your PR. Pls follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.

leniatgh · 2020-10-22T05:53:29Z

@roherzbe please follow the breaking change review process above。

roherzbe · 2020-10-22T15:50:23Z

Hi @leni-msft
I read the breaking change policy before opening the PR and again now, but I'm not sure in which scenario this PR fits and how to proceed?
The code I changed is in the preview version. I've also generated a client from this code and validated many scenarios and tests in order to validate this change doesn't break anything.
Should I contact someone for the "BreakingChangeReview" or will someone contact me?
Thanks!

leniatgh · 2020-10-23T03:49:55Z

@roherzbe Adding response code belongs to API behavioral changes. To proceed, please follow the section 3 Detailed Breaking Change Process in the breaking change policy document.

roherzbe · 2020-10-27T16:39:21Z

@JeffreyRichter
After discussing this change in office hours and approving this intake (8663535)
Thanks in advance

roherzbe · 2020-10-27T17:03:00Z

Jeffrey, Thank you very much!
@leni-msft how do we proceed from here? :)

leniatgh · 2020-10-28T02:02:11Z

/azp run automation - sdk

azure-pipelines · 2020-10-28T02:02:20Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-10-28T02:07:06Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 1416e5e with merge commit e86a6ee. SDK Automation 13.0.17.20200918.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-10-28T02:07:06Z

Azure CLI Extension Generation - Release

Installation instruction for service securityinsight [Preview Changes]
curl -L "https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/azure-rest-api-specs/11297/azure-cli-extensions/securityinsight/sentinel-0.1.0-py3-none-any.whl" -o sentinel-0.1.0-py3-none-any.whl az extension add --source=sentinel-0.1.0-py3-none-any.whl

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 1416e5e with merge commit e86a6ee. Azure CLI Automation 13.0.17.20200918.2

[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'AwsCloudTrailDataConnectorDataTypes-logs' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-exchange' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-sharePoint' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'TIDataConnectorDataTypes-indicators' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRuleTemplatesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BookmarkList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataConnectorList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentCommentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OfficeConsentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceWithEtag' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
[AutoRest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'MCASDataConnectorDataTypes' has a property 'alerts' that is already declared the parent schema 'AlertsDataTypeOfDataConnector' but isn't significantly different. The property has been removed from MCASDataConnectorDataTypes
[AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
[AutoRest] 
[AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
[AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
[AutoRest] --------------------------------------------------------
[AutoRest]   test-scenario:
[AutoRest]     - name: /Actions/get/Get all actions of alert rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates a Fusion alert rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates a MicrosoftSecurityIncidentCreation rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates a Scheduled alert rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates an action of alert rule.
[AutoRest]     - name: /AlertRules/get/Get a Fusion alert rule.
[AutoRest]     - name: /AlertRules/get/Get a MicrosoftSecurityIncidentCreation rule.
[AutoRest]     - name: /AlertRules/get/Get a Scheduled alert rule.
[AutoRest]     - name: /AlertRules/get/Get all alert rules.
[AutoRest]     - name: /AlertRules/get/Get an action of alert rule.
[AutoRest]     - name: /AlertRules/delete/Delete an action of alert rule.
[AutoRest]     - name: /AlertRules/delete/Delete an alert rule.
[AutoRest]     - name: /AlertRuleTemplates/get/Get alert rule template by Id.
[AutoRest]     - name: /AlertRuleTemplates/get/Get all alert rule templates.
[AutoRest]     - name: /Bookmarks/put/Creates or updates a bookmark.
[AutoRest]     - name: /Bookmarks/get/Get a bookmark.
[AutoRest]     - name: /Bookmarks/get/Get all bookmarks.
[AutoRest]     - name: /Bookmarks/delete/Delete a bookmark.
[AutoRest]     - name: /DataConnectors/put/Creates or updates an Office365 data connector.
[AutoRest]     - name: /DataConnectors/get/Get a ASC data connector.
[AutoRest]     - name: /DataConnectors/get/Get a MCAS data connector.
[AutoRest]     - name: /DataConnectors/get/Get a MDATP data connector
[AutoRest]     - name: /DataConnectors/get/Get a TI data connector.
[AutoRest]     - name: /DataConnectors/get/Get all data connectors.
[AutoRest]     - name: /DataConnectors/get/Get an AAD data connector.
[AutoRest]     - name: /DataConnectors/get/Get an AATP data connector.
[AutoRest]     - name: /DataConnectors/get/Get an AwsCloudTrail data connector.
[AutoRest]     - name: /DataConnectors/get/Get an Office365 data connector.
[AutoRest]     - name: /DataConnectors/delete/Delete an Office365 data connector.
[AutoRest]     - name: /IncidentComments/put/Creates an incident comment.
[AutoRest]     - name: /IncidentComments/get/Get all incident comments.
[AutoRest]     - name: /IncidentComments/get/Get an incident comment.
[AutoRest]     - name: /Incidents/put/Creates or updates an incident.
[AutoRest]     - name: /Incidents/get/Get all incidents.
[AutoRest]     - name: /Incidents/get/Get an incident.
[AutoRest]     - name: /Incidents/delete/Delete an incident.
[AutoRest] --------------------------------------------------------

️✔️securityinsight [View full logs] [Release Azure CLI Changes]

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 28 Oct 2020 02:27:27 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0644:9C6F:2D4953F:33D9248:5F98D70F","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-10-28T02:07:12Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-10-28T02:07:33Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 1416e5e with merge commit e86a6ee. SDK Automation 13.0.17.20200918.2

️✔️preview/securityinsight/mgmt/2019-01-01-preview [View full logs] [Release SDK Changes]

preview.securityinsight.mgmt.2019-01-01-preview.zip

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 28 Oct 2020 02:31:19 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0480:462D:1F890D:45763E:5F98D7F7","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

️✔️securityinsight/mgmt/v1.0 [View full logs] [Release SDK Changes]

securityinsight.mgmt.v1.0.zip

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 28 Oct 2020 02:31:33 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0481:3FAA:39366A:614A86:5F98D805","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-10-28T02:07:46Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 1416e5e with merge commit e86a6ee. SDK Automation 13.0.17.20200918.2

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.SecurityInsights [View full logs] [Release SDK Changes]

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 28 Oct 2020 02:29:59 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0740:026E:32258A:59806A:5F98D7A7","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-10-28T02:07:58Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 1416e5e with merge commit e86a6ee. SDK Automation 13.0.17.20200918.2
```
[azure-mgmt-securityinsight][ChangeLog] WARNING: Failed to generate ChangeLog.
```

⚠️azure-mgmt-securityinsight [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-securityinsight
[build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-securityinsight
[build_conf] INFO:packaging_tools:Template done azure-mgmt-securityinsight
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 28 Oct 2020 02:28:23 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0782:5EBF:1CADA0:3F91B0:5F98D747","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
Not exact 2 reports found:
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

openapi-sdkautomation · 2020-10-28T02:08:02Z

azure-resource-manager-schemas - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 1416e5e with merge commit e86a6ee. Schema Automation 13.0.17.20200918.2

[securityinsights][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
[securityinsights][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
[securityinsights][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend

️✔️securityinsights [View full logs] [Release Schema Changes]

[after_scripts|node] PostProcessor finished successfully.
[after_scripts|node]   5790 passing (1m)
AzureResourceSchema has no registered package commands.
Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 28 Oct 2020 02:33:00 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0500:6972:14243:4013A:5F98D85C","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-10-28T02:08:11Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-10-28T02:08:14Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

* Add delete incident comment * Fix for Prettier * Fix Prettier 2

Add delete incident comment

cec0208

ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Oct 20, 2020

openapi-assignment-bot bot assigned leniatgh Oct 20, 2020

roherzbe and others added 3 commits October 20, 2020 12:56

Fix for Prettier

aa1290e

Fix Prettier 2

fda2996

Merge branch 'master' of https://github.com/roherzbe/azure-rest-api-s…

1416e5e

…pecs

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 20, 2020

pilor self-requested a review October 20, 2020 17:27

pilor added the ARMChangesRequested label Oct 20, 2020

pilor suggested changes Oct 20, 2020

View reviewed changes

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 21, 2020

pilor approved these changes Oct 21, 2020

View reviewed changes

leniatgh added the BreakingChangeReviewRequired label Oct 22, 2020

JeffreyRichter self-requested a review October 27, 2020 16:55

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 27, 2020

JeffreyRichter approved these changes Oct 27, 2020

View reviewed changes

leniatgh merged commit e86a6ee into Azure:master Oct 28, 2020

giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020

Add delete incident comment API (Azure#11297)

dabb549

* Add delete incident comment * Fix for Prettier * Fix Prettier 2

Comments

Conversation

roherzbe commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

AutorestCI commented Oct 20, 2020

Uh oh!

openapi-pipeline-app bot commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Staging] Swagger Validation Report

Uh oh!

ghost commented Oct 20, 2020

Uh oh!

openapi-workflow-bot bot commented Oct 20, 2020

Uh oh!

openapi-workflow-bot bot commented Oct 20, 2020

Uh oh!

roherzbe commented Oct 20, 2020

Uh oh!

pilor Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

roherzbe Oct 21, 2020

Choose a reason for hiding this comment

Uh oh!

pilor left a comment

Choose a reason for hiding this comment

Uh oh!

roherzbe commented Oct 21, 2020

Uh oh!

openapi-workflow-bot bot commented Oct 22, 2020

Uh oh!

leniatgh commented Oct 22, 2020

Uh oh!

roherzbe commented Oct 22, 2020

Uh oh!

leniatgh commented Oct 23, 2020

Uh oh!

roherzbe commented Oct 27, 2020

Uh oh!

roherzbe commented Oct 27, 2020

Uh oh!

leniatgh commented Oct 28, 2020

Uh oh!

azure-pipelines bot commented Oct 28, 2020

Uh oh!

openapi-sdkautomation bot commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Azure CLI Extension Generation - Release

Uh oh!

openapi-sdkautomation bot commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-resource-manager-schemas - Release

Uh oh!

openapi-sdkautomation bot commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python-track2 - Release

roherzbe commented Oct 20, 2020 •

edited

Loading

openapi-pipeline-app bot commented Oct 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 28, 2020 •

edited

Loading