Skip to content

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #11258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhoenixHe-NV merged 14 commits into from
Nov 3, 2020
Merged

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #11258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a340f10
Fix mistakes in swagger from actual responses
zachraMSFT Oct 10, 2020
2ff74c5
Fix swagger mismatches
zachraMSFT Oct 16, 2020
3ec1fff
Add 204 to examples
zachraMSFT Oct 16, 2020
39d2eab
Fix example response to match actual response format
zachraMSFT Oct 16, 2020
c72bd29
Fix errors
zachraMSFT Oct 16, 2020
98f6d70
Remove discriminator, not returned in full response
zachraMSFT Oct 16, 2020
ce8ab89
Avoid discriminator while still not active in code
zachraMSFT Oct 16, 2020
58c5e0e
Add discriminator, it's actively used
zachraMSFT Oct 17, 2020
72d805e
Fix example files
zachraMSFT Oct 17, 2020
63fee08
Additional fix
zachraMSFT Oct 17, 2020
10f3854
Fix discriminator setup
zachraMSFT Oct 17, 2020
7622330
Remove new properties added
zachraMSFT Oct 28, 2020
52a4134
Remove required property
zachraMSFT Oct 28, 2020
abe6729
Fix example
zachraMSFT Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 46 additions & 2 deletions ...ion/consumption/resource-manager/Microsoft.Consumption/stable/2019-10-01/consumption.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,6 +1099,9 @@
"$ref": "#/definitions/ReservationRecommendationsListResult"
}
},
"204": {
"description": "An empty response is sent when there are no recommendations."
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
Expand Down Expand Up @@ -2985,6 +2988,14 @@
}
],
"properties": {
"location": {
"type": "string",
"description": "Resource Location."
},
"sku": {
"type": "string",
"description": "Resource sku"
},
"properties": {
"x-ms-client-flatten": true,
"$ref": "#/definitions/ReservationRecommendationDetailsProperties",
Expand Down Expand Up @@ -3055,6 +3066,10 @@
"type": "number",
"readOnly": true
},
"reservedUnitCount": {
"description": "The number of reserved units used to calculate savings. Always 1 for virtual machines.",
"type": "number"
},
"savings": {
"description": "The amount saved by purchasing the recommended quantity of reservation.",
"type": "number",
Expand Down Expand Up @@ -3553,7 +3568,7 @@
"x-ms-discriminator-value": "Modern",
"allOf": [
{
"$ref": "#/definitions/Resource"
"$ref": "#/definitions/ReservationTransactionResource"
}
],
"properties": {
Expand Down Expand Up @@ -3700,7 +3715,7 @@
"type": "object",
"allOf": [
{
"$ref": "#/definitions/Resource"
"$ref": "#/definitions/ReservationTransactionResource"
}
],
"properties": {
Expand Down Expand Up @@ -4906,6 +4921,35 @@
},
"x-ms-azure-resource": true
},
"ReservationTransactionResource": {
"description": "The Resource model definition.",
"properties": {
"id": {
"readOnly": true,
"type": "string",
"description": "Resource Id."
},
"name": {
"readOnly": true,
"type": "string",
"description": "Resource name."
},
"type": {
"readOnly": true,
"type": "string",
"description": "Resource type."
},
"tags": {
"readOnly": true,
"type": "array",
"items": {
"type": "string"
},
"description": "Resource tags."
}
},
"x-ms-azure-resource": true
},
"ResourceAttributes": {
"description": "The Resource model definition.",
"properties": {
Expand Down
3 changes: 2 additions & 1 deletion ...ft.Consumption/stable/2019-10-01/examples/ReservationRecommendationsByBillingAccount.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
],
"nextLink": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Consumption/reservationRecommendations?api-version=2019-10-01&$skiptoken=AQAAAA%3D%3D&"
}
}
},
"204": {}
}
}
3 changes: 2 additions & 1 deletion ...ft.Consumption/stable/2019-10-01/examples/ReservationRecommendationsByBillingProfile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
],
"nextLink": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Consumption/reservationRecommendations?api-version=2019-10-01&$skiptoken=AQAAAA%3D%3D&"
}
}
},
"204": {}
}
}
3 changes: 2 additions & 1 deletion ...oft.Consumption/stable/2019-10-01/examples/ReservationRecommendationsByResourceGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
],
"nextLink": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/testGroup/providers/Microsoft.Consumption/reservationRecommendations?api-version=2019-10-01&$skiptoken=AQAAAA%3D%3D&"
}
}
},
"204": {}
}
}
3 changes: 2 additions & 1 deletion ...soft.Consumption/stable/2019-10-01/examples/ReservationRecommendationsBySubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
],
"nextLink": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Consumption/reservationRecommendations?api-version=2019-10-01&$skiptoken=AQAAAA%3D%3D&"
}
}
},
"204": {}
}
}
3 changes: 2 additions & 1 deletion ...-10-01/examples/ReservationRecommendationsFilterBySubscriptionForScopeLookBackPeriod.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
],
"nextLink": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Consumption/reservationRecommendations?api-version=2019-10-01&$filter=properties/scope+eq+'Single'+AND+properties/lookBackPeriod+eq+'Last7Days'&$skiptoken=AQAAAA%3D%3D&"
}
}
},
"204": {}
}
}
4 changes: 2 additions & 2 deletions ...Consumption/stable/2019-10-01/examples/ReservationTransactionsListByEnrollmentNumber.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"id": "/billingAccounts/123456/providers/Microsoft.Consumption/reservationtransactions/201909091919",
"name": "201909091919",
"type": "Microsoft.Consumption/reservationTransactions",
"tags": {},
"tags": [],
"properties": {
"eventDate": "2019-09-09T19:19:04Z",
"reservationOrderId": "00000000-0000-0000-0000-000000000000",
Expand Down Expand Up @@ -40,7 +40,7 @@
"id": "/billingAccounts/123456/providers/Microsoft.Consumption/reservationtransactions/201909091919",
"name": "201909091919",
"type": "Microsoft.Consumption/reservationTransactions",
"tags": {},
"tags": [],
"properties": {
"eventDate": "2019-09-09T19:19:04Z",
"reservationOrderId": "00000000-0000-0000-0000-000000000000",
Expand Down