Adding support for SqlPoolDeleteRestorePoints and RestorableDroppedSqlPools apis #11257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @tunafish88 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Staging] Swagger Validation Report
️✔️ |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @tunafish88 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @${PRAssignee} |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-resource-manager-schemas - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-python
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
This was referenced Oct 16, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
idear1203
reviewed
Oct 23, 2020
...ification/synapse/resource-manager/Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json
Outdated
Show resolved
Hide resolved
idear1203
reviewed
Oct 23, 2020
...ification/synapse/resource-manager/Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json
Outdated
Show resolved
Hide resolved
idear1203
reviewed
Oct 23, 2020
...ification/synapse/resource-manager/Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json
Outdated
Show resolved
Hide resolved
… added restorablesqlpools api
|
Azure Pipelines successfully started running 1 pipeline(s). |
tunafish88
changed the title
|
Azure Pipelines successfully started running 1 pipeline(s). |
pilor
suggested changes
Oct 23, 2020
| } | ||
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/restorableDroppedSqlpools/{restorableDroppededSqlPoolId}": { |
Contributor
There was a problem hiding this comment.
How do you restore these? Also, typically these soft-delete scenarios give users the ability to purge the restorable objects by calling a DELETE API on the "restorable" variant.
Contributor
Author
There was a problem hiding this comment.
S there are 2 options:
-
user calls this API (visa some rest client, or via commandlet) and reaches out to CSS with a list of restorable dropped databases. Css creates an ICM and we can help the user out from there. ( less common)
-
There is going to be an Azure portal blade which will call this API to show a drop down of the restorabled droppedpools. The user chooses one of them and the chosen one gets passed onto a Create from 'restorable dropped sql pool' flow., to create a new sql pool based off of it.
Contributor
There was a problem hiding this comment.
What API is used in #2? How do you specify via the API that you want to restore one of these databases? Where is that API change?
Contributor
Author
There was a problem hiding this comment.
It would have to be the 'create sqlpool' API. ( sqlpool.json file) with some update to it (to take some more parameters as per my understanding).
This line below is from a Colleague:
'Synapse RP would need to expose additional parameters (deletionTime, deletionDateString, deletionTimeString, deletedDatabaseId) in their create sqlpool api (to support the provided arm template)'
The way the counterpart SQL API is used, is here https://docs.microsoft.com/en-us/azure/azure-sql/database/recovery-using-backups#deleted-database-restore
pilor
added
ARMSignedOff
pilor
approved these changes
Oct 27, 2020
Contributor
pilor
left a comment
pilor
left a comment
There was a problem hiding this comment.
Approving as a read-only view of restorable pools that can be restored via a support ticket. Please open another review for the API that allows restoring these when you implement that.
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
leniatgh
added
the
Approved-OkToMerge
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
…lPools apis (Azure#11257) * Adding support for SqlPoolTransparentDataEncryptionActivity * Added default response * Adding sqlPool restore points oeprations * Added the response type * Fixed errors * removed transparent dataencryption API added in a previous iteration, added restorablesqlpools api * Applied Dongwei's feedback * Added suppression validation * Fixed the suppression synatx error * Fixed the suppression synatx error * Fixed spelling errors flagged by spell checker * Fixed spelling errors flagged by spell checker * Fixed spelling errors flagged by spell checker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.