[Data Factory]Fix secret property in AmazonS3 linked service#11235
Merged
qianwens merged 11 commits intoAzure:masterfrom Oct 16, 2020
Merged
[Data Factory]Fix secret property in AmazonS3 linked service#11235qianwens merged 11 commits intoAzure:masterfrom
qianwens merged 11 commits intoAzure:masterfrom
Conversation
Merge from origin
Merge from origin
Merge from origin
Merge from origin
Merge from origin
Merge from origin
Merge from master
Merge from origin
Merge from origin
Merge from origin
|
Hi, @rickysun93 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Staging] Swagger Validation Report
❌ |
| Rule | Message |
|---|---|
|
The new version has a different discriminator than the previous one. New: stable/2018-06-01/entityTypes/LinkedService.json#L2708:9 Old: stable/2018-06-01/entityTypes/LinkedService.json#L2708:9 |
|
The new version has new required property 'type' that was not found in the old version. New: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4233:7 |
|
The new version has new required property 'type' that was not found in the old version. New: stable/2018-06-01/entityTypes/LinkedService.json#L2708:9 Old: stable/2018-06-01/entityTypes/LinkedService.json#L2708:9 |
️️✔️LintDiff [Detail]
️✔️Validation passes for LintDiff.
️️✔️Avocado [Detail]
️✔️Validation passes for Avocado.
️️✔️ModelValidation [Detail]
️✔️Validation passes for ModelValidation.
️️✔️SemanticValidation [Detail]
️✔️Validation passes for SemanticValidation.
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-resource-manager-schemas - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
Azure CLI Extension Generation - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
rickysun93
commented
Oct 16, 2020
| "sessionToken": { | ||
| "type": "object", | ||
| "description": "The session token for the S3 temporary security credential. Type: string (or Expression with resultType string)." | ||
| "$ref": "../datafactory.json#/definitions/SecretBase", |
Member
Author
There was a problem hiding this comment.
This mistake was added by last PR #10903 just now. And there's no SDK release after that.
So it won't be a breaking change.
This was referenced Oct 16, 2020
qianwens
approved these changes
Oct 16, 2020
qianwens
approved these changes
Oct 16, 2020
qianwens
approved these changes
Oct 16, 2020
qianwens
added
the
Approved-BreakingChange
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.