Updated HybridNetwork Swaggers for October release. by congl-microsoft · Pull Request #11232 · Azure/azure-rest-api-specs

congl-microsoft · 2020-10-16T03:39:04Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-10-16T03:39:08Z

[Staging] Swagger Validation Report

️❌BreakingChange: 79 Errors, 0 Warnings [Detail] [Expand]

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.HybridNetwork/locations/{locationName}/vendors/{vendorName}/virtualNetworkFunctions' removed or restructured? Old: Microsoft.HybridNetwork/preview/2020-01-01-preview/vendor.json#L575:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.HybridNetwork/locations/{locationName}/vendors/{vendorName}/virtualNetworkFunctions/{serviceKey}' removed or restructured? Old: Microsoft.HybridNetwork/preview/2020-01-01-preview/vendor.json#L444:5
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'VendorProvisioningState' removed or renamed? New: Microsoft.HybridNetwork/preview/2020-01-01-preview/vendor.json#L691:3 Old: Microsoft.HybridNetwork/preview/2020-01-01-preview/vendor.json#L882:3
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'VendorVirtualNetworkFunction' removed or renamed? New: Microsoft.HybridNetwork/preview/2020-01-01-preview/vendor.json#L691:3 Old: Microsoft.HybridNetwork/preview/2020-01-01-preview/vendor.json#L882:3
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'VirtualNetworkFunctionTemplate' removed or renamed? New: Microsoft.HybridNetwork/preview/2020-01-01-preview/vendor.json#L691:3 Old: Microsoft.HybridNetwork/preview/2020-01-01-preview/vendor.json#L882:3
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'VendorVirtualNetworkFunctionPropertiesFormat' removed or renamed? New: Microsoft.HybridNetwork/preview/2020-01-01-preview/vendor.json#L691:3 Old: Microsoft.HybridNetwork/preview/2020-01-01-preview/vendor.json#L882:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ApiVersionParameter' removed or renamed? Old: Microsoft.HybridNetwork/preview/2020-01-01-preview/common.json#L262:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'SubscriptionIdParameter' removed or renamed? Old: Microsoft.HybridNetwork/preview/2020-01-01-preview/common.json#L262:3
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) 'Deleted' from the old version. New: Microsoft.HybridNetwork/preview/2020-01-01-preview/device.json#L401:9 Old: Microsoft.HybridNetwork/preview/2020-01-01-preview/device.json#L425:9
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) 'Firewall' from the old version. New: Microsoft.HybridNetwork/preview/2020-01-01-preview/vendor.json#L748:9 Old: Microsoft.HybridNetwork/preview/2020-01-01-preview/vendor.json#L939:9

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-10-16T03:39:21Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-10-16T03:41:06Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-10-16T03:41:16Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 63e573c with merge commit 895ecf1. SDK Automation 13.0.17.20200918.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-10-16T03:41:19Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 63e573c with merge commit 895ecf1. SDK Automation 13.0.17.20200918.2

️✔️preview/hybridnetwork/management/2020-01-01-preview [View full logs] [Release SDK Changes]

preview.hybridnetwork.management.2020-01-01-preview.zip

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 20 Oct 2020 01:44:31 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0782:2F1F:1D266C6B:219402F8:5F8E40FF","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-10-16T03:41:29Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 63e573c with merge commit 895ecf1. SDK Automation 13.0.17.20200918.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-10-16T03:41:34Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-10-16T03:41:36Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 63e573c with merge commit 895ecf1. SDK Automation 13.0.17.20200918.2

Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/_hybrid_network_management_client.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/models/_hybrid_network_management_client_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/_devices_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/_network_function_vendor_skus_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/_network_function_vendors_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/_network_functions_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/_role_instances_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/_vendor_network_functions_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/_vendor_sku_preview_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/_vendor_skus_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/_vendors_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/version.py

openapi-sdkautomation · 2020-10-16T03:41:39Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

congl-microsoft · 2020-10-16T03:41:54Z

Hi @raych1 , since there are lots of breaking changes that complained by the pipeline, please refer to our last PR to RPSaaSMaster (https://github.com/Azure/azure-rest-api-specs-pr/pull/2142). Thanks!

openapi-sdkautomation · 2020-10-16T03:42:01Z

azure-resource-manager-schemas - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 63e573c with merge commit 895ecf1. Schema Automation 13.0.17.20200918.2

[hybridnetwork][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
[hybridnetwork][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
[hybridnetwork][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend

️✔️hybridnetwork [View full logs] [Release Schema Changes]

[after_scripts|node] PostProcessor finished successfully.
[after_scripts|node]   5782 passing (1m)
AzureResourceSchema has no registered package commands.
Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 20 Oct 2020 01:48:18 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0400:13331:1DDE55C7:2276F8B3:5F8E41E2","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-10-16T03:42:01Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-workflow-bot · 2020-10-16T09:19:46Z

Hi @congl-microsoft, one or multiple breaking change(s) is detected in your PR. Pls follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.

raych1 · 2020-10-16T09:24:41Z

@congl-microsoft , could you clarify the changes? From the title that says "October release", however it updated the current preview swagger(2020-01-01-preview). As identified in the check, this PR has breaking changes that needs review from breaking change review board.

congl-microsoft · 2020-10-16T17:59:05Z

Hi @raych1 , thank you very much for asking. Yes, this PR contains lots of breaking changes because the current Swaggers on Master is out-dated. It has been a long time that our team didn't update Swaggers to Master branch because our service was still under private preview. We didn't publish any SDK as well. So using the same version with breaking changes will not impact any customers. For the past months, we changed Swaggers a lot on RPSaaSMaster, and each time we followed the reviewers' feedback and got the changes approved. For now, this PR is exactly the same content as our current Swaggers on RPSaaSMaster which was updated a few days ago and merged by Allen Zhang. Before that PR, there was also a PR merged in August. I just share the two PR links here for your reference. [https://github.com/Azure/azure-rest-api-specs-pr/pull/1898] [https://github.com/Azure/azure-rest-api-specs-pr/pull/2142] Would you please let us know if we need to go through the same review process as we already had on RPSaaSMaster? Please feel free to reach out to me on Teams (congl) if you have any concerns.

raych1 · 2020-10-20T01:20:50Z

Hi @raych1 , thank you very much for asking. Yes, this PR contains lots of breaking changes because the current Swaggers on Master is out-dated. It has been a long time that our team didn't update Swaggers to Master branch because our service was still under private preview. We didn't publish any SDK as well. So using the same version with breaking changes will not impact any customers. For the past months, we changed Swaggers a lot on RPSaaSMaster, and each time we followed the reviewers' feedback and got the changes approved. For now, this PR is exactly the same content as our current Swaggers on RPSaaSMaster which was updated a few days ago and merged by Allen Zhang. Before that PR, there was also a PR merged in August. I just share the two PR links here for your reference. [https://github.com/Azure/azure-rest-api-specs-pr/pull/1898] [https://github.com/Azure/azure-rest-api-specs-pr/pull/2142] Would you please let us know if we need to go through the same review process as we already had on RPSaaSMaster? Please feel free to reach out to me on Teams (congl) if you have any concerns.

Breaking change approved as this is preview swagger with no published SDK.

Updated HybridNetwork Swaggers for October release.

63e573c

openapi-assignment-bot bot assigned raych1 Oct 16, 2020

openapi-sdkautomation bot mentioned this pull request Oct 16, 2020

[AutoPR hybridnetwork] Updated HybridNetwork Swaggers for October release. AzureSDKAutomation/azure-resource-manager-schemas#564

Closed

raych1 added the BreakingChangeReviewRequired label Oct 16, 2020

raych1 added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed BreakingChangeReviewRequired labels Oct 20, 2020

raych1 approved these changes Oct 20, 2020

View reviewed changes

raych1 merged commit 895ecf1 into Azure:master Oct 20, 2020

giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020

Updated HybridNetwork Swaggers for October release. (Azure#11232)

5dfe0a0

Conversation

congl-microsoft commented Oct 16, 2020

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-pipeline-app bot commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Staging] Swagger Validation Report

Uh oh!

azure-pipelines bot commented Oct 16, 2020

Uh oh!

openapi-sdkautomation bot commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Azure CLI Extension Generation - Release

Uh oh!

openapi-sdkautomation bot commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python-track2 - Release

Uh oh!

congl-microsoft commented Oct 16, 2020

Uh oh!

openapi-sdkautomation bot commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-resource-manager-schemas - Release

Uh oh!

openapi-sdkautomation bot commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Trenton Generation - Release

Uh oh!

openapi-workflow-bot bot commented Oct 16, 2020

Uh oh!

raych1 commented Oct 16, 2020

Uh oh!

congl-microsoft commented Oct 16, 2020

Uh oh!

raych1 commented Oct 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

openapi-pipeline-app bot commented Oct 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 16, 2020 •

edited

Loading