Separate servers, operations, and backups from sql.core.#1122
Merged
sarangan12 merged 1 commit intoAzure:masterfrom Apr 14, 2017
Merged
Separate servers, operations, and backups from sql.core.#1122sarangan12 merged 1 commit intoAzure:masterfrom
sarangan12 merged 1 commit intoAzure:masterfrom
Conversation
No change to contents, just simple move. This separation is needed because servers and operations will soon have a new api-version, so composite swagger will need to to pull databases/pools/etc from 2014-04-04 sql.core.json and servers/operations from 2015-05-01-preview swagger files.
Contributor
Author
|
Can we keep this change as a pure source code refactor and track any validation fixes in #1107 ? This way the functional and non-functional changes are separated. |
sarangan12
approved these changes
Apr 14, 2017
Contributor
sarangan12
left a comment
There was a problem hiding this comment.
Agreeing with @jaredmoo comments. The errors are being handled seperately. This is considered simple as a move and thus being approved.
|
No modification for NodeJS |
Contributor
Author
|
Thanks for the very speedy review and merge @sarangan12 ! |
mccleanp
pushed a commit
that referenced
this pull request
Mar 23, 2022
Permit 200 response from RegenerateKey endpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No change to contents, just simple move. This separation is needed because servers and operations will soon have a new api-version, so composite swagger will need to to pull databases/pools/etc from 2014-04-04 sql.core.json and servers/operations from 2015-05-01-preview swagger files.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger