Skip to content

Separate servers, operations, and backups from sql.core.#1122

Merged
sarangan12 merged 1 commit intoAzure:masterfrom
jaredmoo:splitsqlcore
Apr 14, 2017
Merged

Separate servers, operations, and backups from sql.core.#1122
sarangan12 merged 1 commit intoAzure:masterfrom
jaredmoo:splitsqlcore

Conversation

@jaredmoo
Copy link
Contributor

@jaredmoo jaredmoo commented Apr 14, 2017

No change to contents, just simple move. This separation is needed because servers and operations will soon have a new api-version, so composite swagger will need to to pull databases/pools/etc from 2014-04-04 sql.core.json and servers/operations from 2015-05-01-preview swagger files.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

No change to contents, just simple move. This separation is needed because servers and operations will soon have a new api-version, so composite swagger will need to to pull databases/pools/etc from 2014-04-04 sql.core.json and servers/operations from 2015-05-01-preview swagger files.
@jaredmoo
Copy link
Contributor Author

Can we keep this change as a pure source code refactor and track any validation fixes in #1107 ? This way the functional and non-functional changes are separated.

Copy link
Contributor

@sarangan12 sarangan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreeing with @jaredmoo comments. The errors are being handled seperately. This is considered simple as a move and thus being approved.

@sarangan12 sarangan12 merged commit 5802869 into Azure:master Apr 14, 2017
@AutorestCI
Copy link

No modification for NodeJS

@AutorestCI
Copy link

@AutorestCI
Copy link

@jaredmoo
Copy link
Contributor Author

Thanks for the very speedy review and merge @sarangan12 !

@jaredmoo jaredmoo deleted the splitsqlcore branch July 8, 2017 17:23
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
Permit 200 response from RegenerateKey endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants