Fix Swagger Issues for Microsoft.AAD/DomainServices#11178
Merged
xseeseesee merged 23 commits intoAzure:masterfrom Nov 9, 2020
jihochang:master
Merged
Fix Swagger Issues for Microsoft.AAD/DomainServices#11178xseeseesee merged 23 commits intoAzure:masterfrom jihochang:master
xseeseesee merged 23 commits intoAzure:masterfrom
jihochang:master
Conversation
Add GET/PROVIDERS/MICROSOFT.AAD/SUBSCRIPTIONS/RESOURCEGROUPS/PROVIDERS/MICROSOFT.AAD/DOMAINSERVICES operation
Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Oct 13, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
Add DeploymentId property to DomainServiceProperties
|
Azure Pipelines successfully started running 1 pipeline(s). |
Fix swagger correctness issues
|
Azure Pipelines successfully started running 1 pipeline(s). |
Add description for default error type
|
Azure Pipelines successfully started running 1 pipeline(s). |
Ran Prettier
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @jihochang, one or multiple breaking change(s) is detected in your PR. Pls follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Change format back to date-time
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Swagger Generation Artifacts
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JeffreyRichter
approved these changes
Nov 6, 2020
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
* Update domainservices.json Add GET/PROVIDERS/MICROSOFT.AAD/SUBSCRIPTIONS/RESOURCEGROUPS/PROVIDERS/MICROSOFT.AAD/DOMAINSERVICES operation * Update domainservices.json * Update domainservice.json for 2017-01-01 Add DeploymentId property to DomainServiceProperties * Update domainservice.json for 2017-06-01 Fix swagger correctness issues * Update domainservices.json Add description for default error type * Update DomainService 2017-06-01 Ran Prettier * Update oucontainer.json for 2017-06-01 * Update oucontainer.json for 2020-01-01 * Update domainservice.json for 2020-01-01 * Fix linting issues in domainservice.json 2020-01-01 * Fix spell check error on domainservice.json 2020-01-01 * Update domainservices.json Remove incorrect GET * Update domainservices.json Add x-ms-secret metadata for ResourceForest property * Update domainservices.json Change format back to date-time * update format back to date-time * Update domainservices.json * Update domainservices.json * Update domainservices.json * Update domainservices.json * Update domainservices.json * Update domainservices.json * Update domainservices.json * Update domainservices.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GET/PROVIDERS/MICROSOFT.AAD/SUBSCRIPTIONS/RESOURCEGROUPS/PROVIDERS/MICROSOFT.AAD/DOMAINSERVICES operation
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.