Skip to content

Enabling the creation of JavaScript SDK for the Communication resource manager #11114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weidongxu-microsoft merged 2 commits into from
Oct 15, 2020
Merged

Enabling the creation of JavaScript SDK for the Communication resource manager #11114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0817c8a
Add JavaScript for Communication resource manager
memontic-ms Oct 9, 2020
94c5cf6
Remove unneeded after_script
memontic-ms Oct 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions specification/communication/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ swagger-to-sdk:
- repo: azure-sdk-for-python
- repo: azure-sdk-for-python-track2
- repo: azure-sdk-for-go
- repo: azure-sdk-for-js
after_scripts:
- bundle install && rake arm:regen_all_profiles['azure_mgmt_vsonline']
Copy link
Member

@qiaozha qiaozha Oct 10, 2020 •
edited by usvoyager
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS SDK doesn't have after scripts, you should remove the after scripts or put it right after the repo that needs it. #Resolved

Copy link
Contributor Author

@memontic-ms memontic-ms Oct 12, 2020 •
edited by usvoyager
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. That after_script is not needed. I'll remove it. #Resolved

```
Expand All @@ -68,3 +69,7 @@ See configuration in [readme.python.md](./readme.python.md)
## Go

See configuration in [readme.go.md](./readme.go.md)

## Typescript

See configuration in [readme.typescript.md](./readme.typescript.md)
13 changes: 13 additions & 0 deletions specification/communication/resource-manager/readme.typescript.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
## TypeScript

These settings apply only when `--typescript` is specified on the command line.
Please also specify `--typescript-sdks-folder=<path to the root directory of your azure-sdk-for-js clone>`.

``` yaml $(typescript)
typescript:
azure-arm: true
package-name: "@azure/arm-communication"
output-folder: "$(typescript-sdks-folder)/sdk/communication/arm-communication"
Copy link
Member

@qiaozha qiaozha Oct 10, 2020 •
edited by usvoyager
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found that the folder https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/communication is not empty, Are those the communication data-plane SDKs? #Resolved

Copy link
Contributor Author

@memontic-ms memontic-ms Oct 12, 2020 •
edited by usvoyager
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Those are the data-plane SDKs. #Resolved

clear-output-folder: true
generate-metadata: true
```