Workspace Managed Sql Server Proxy Apis. #907750 #923781#11105
Conversation
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Guid used in model definition 'ServerBlobAuditingPolicyProperties' for property 'storageAccountSubscriptionId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. New: Microsoft.Synapse/preview/2019-06-01-preview/sqlServer.json#L1231 |
|
| Guid used in model definition 'ExtendedServerBlobAuditingPolicyProperties' for property 'storageAccountSubscriptionId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. New: Microsoft.Synapse/preview/2019-06-01-preview/sqlServer.json#L1333 |
️️✔️~[Staging] Avocado succeeded [Detail]
Validation passes for Avocado.
️️✔️~[Staging] ModelValidation succeeded [Detail]
Validation passes for ModelValidation.
️️✔️~[Staging] SemanticValidation succeeded [Detail]
Validation passes for SemanticValidation.
️️✔️~[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail]
There are no breaking changes.
️️✔️~[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail]
There are no breaking changes.
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-js - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-resource-manager-schemas - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
For delete operation, 200 response code is added and local lint check is not throwing the error. Still PR auto validation is throwing it. |
You should add 204 as well, and you can run local lint like this: |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi, @kashyap-kunal Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
Hi, @kashyap-kunal your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @jianyexi |
|
Azure Pipelines successfully started running 1 pipeline(s). |
- AFeature moved inside other API
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
RestBuild error |
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=172998&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
As per breaking change checklist, you are updating API(s) in preview over 1 year. Is there any reason for not able to add new API version? |
varunkumta
left a comment
There was a problem hiding this comment.
I realize most of my comments may not be valid given you are trying to remain consistent with Microsoft.Sql/servers apis. Please resolve them as such, and take a look at the rest.
I don't have an answer to this. It was a design decision. |
Yes, the API version is 2019-06-01-preview, it is over 1 year but the Synapse service was just announced public preview in May 2020. Besides we have plan to build a stable API version soon. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please explain the reason for these new API's; from the look of it you are creating Proxy API's in Synapse namespace for SQL API's. Please confirm if that is the case. Also call out if there are new API's which you want specific review. |
varunkumta
left a comment
There was a problem hiding this comment.
lgtm, please have @chiragg4u sign off and add the ARMSignedOff label
|
Based on the comments from Amogh and Kunal "The APIs here are all being proxied to SQL RP and thus we’ve added the corresponding Swagger on our side to be compliant with the completeness and correctness requirement" |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@zhenglaizhang could you take a look at the ApiDocPreview failure ? |
* Workspace Managed Sql Server Proxy Apis. #907750 #923781 * Spelling mistakes fix * Lint issue fix * Fixing lint warnings * Fixing Lint issue * resolving review comment * Resolvong comment and detangling merge conflicts * Update custom-words.txt * removing server key spec - AFeature moved inside other API * Update sqlServer.json
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.