-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Template Specs: Including "expand" parameter, TemplateSpecVersionInfo model for getting basic version info with template spec(s). #11102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… model for getting basic version info with template spec(s).
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-python-track2 - Release
|
azure-resource-manager-schemas - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
/azp run automation - sdk |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@Tiano2017 , can you please review this PR? |
|
@raych1 : Yes this is implemented/actively deployed in the service. I see the changes required tag is present on the PR, but no changes are requested in the conversation unless I'm missing something? |
|
Hi @changlong-liu , can you please have a look at this python T2 errors? |
|
@raych1 : Is this good to merge? Anything left to address from our side? |
@stuartko , it looks good to me, can you please ask code owner @Tiano2017 to approve then I can merge it? |
Tiano2017
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
… model for getting basic version info with template spec(s). (Azure#11102)
We've had a expand parameter with the possible value of "versions" in our backend for a long while, but it was not documented in the swagger as it was intended for use only through the Portal UI. Due to recent S360 flagging changes, we must now document the expand in the swagger, this PR adds the appropriate definitions to our existing swagger.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.