Skip to content

Azure Stack Fabric.Admin Api update for GPU support#11092

Merged
allenjzhang merged 6 commits intoAzure:masterfrom
LingyunSu:ApiUpdateForGPU
Oct 20, 2020
Merged

Azure Stack Fabric.Admin Api update for GPU support#11092
allenjzhang merged 6 commits intoAzure:masterfrom
LingyunSu:ApiUpdateForGPU

Conversation

@LingyunSu
Copy link
Contributor

@LingyunSu LingyunSu commented Oct 8, 2020

Azure Stack Fabric.Admin Api update for GPU support

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 8, 2020 •
edited
Loading

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail] 
 There are no breaking changes.
️️✔️LintDiff [Detail] 
 Validation passes for LintDiff.
️️✔️Avocado [Detail] 
 Validation passes for Avocado.
️️✔️ModelValidation [Detail] 
 Validation passes for ModelValidation.
️️✔️SemanticValidation [Detail] 
 Validation passes for SemanticValidation.
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 8, 2020

No pipelines are associated with this pull request.

@chiragg4u
Copy link
Contributor

chiragg4u commented Oct 8, 2020

Thank you for copying the existing version into new folder for first commit. Changes looks good to me marking it ARMSignedOff.

@chiragg4u chiragg4u added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 8, 2020
@bganapa
Copy link
Member

bganapa commented Oct 9, 2020

second commit for easy review 9ceaa94

@allenjzhang
Copy link
Contributor

allenjzhang commented Oct 11, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 11, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 11, 2020 •
edited
Loading

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 11, 2020 •
edited
Loading

azure-resource-manager-schemas - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 11, 2020 •
edited
Loading

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 11, 2020 •
edited
Loading

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 11, 2020 •
edited
Loading

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 11, 2020 •
edited
Loading

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 11, 2020 •
edited
Loading

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 11, 2020 •
edited
Loading

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 11, 2020 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@allenjzhang allenjzhang added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Oct 11, 2020
allenjzhang
allenjzhang suggested changes Oct 11, 2020
View reviewed changes
Copy link
Contributor

@allenjzhang allenjzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix checks failures. The swaggers look fine. Once checks are green, it can be merged. Thx

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 12, 2020

No pipelines are associated with this pull request.

@allenjzhang
Copy link
Contributor

allenjzhang commented Oct 13, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 13, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 13, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 15, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@bganapa
Copy link
Member

bganapa commented Oct 15, 2020

@allenjzhang
The following error is an issue with the linting tool. RP Name is already in PascalCasing, i believe since we have .Admin part in the RP name, the linter is flagging it as an issue.

Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Fabric.Admin/fabricLocations/{location}/scaleUnits/{scaleUnit}/setGpuPartitionSize'
at specification/azsadmin/resource-manager/fabric/Microsoft.Fabric.Admin/preview/2020-10-01/ScaleUnit.json:62

https://dev.azure.com/azure-sdk/public/_build/results?buildId=575227&view=logs&j=688669d0-441c-57c3-cf6d-f89a22ccfa5d&t=923b5a90-e462-5994-c166-86509c6bf5f2&l=3754

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 15, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@allenjzhang
Copy link
Contributor

allenjzhang commented Oct 17, 2020

@akning-ms , could you help to see if this is caused by our validation logic can't handles provider name with two dots?

R3020 - PathResourceProviderNamePascalCase
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Fabric.Admin/fabricLocations/{location}/scaleUnits/{scaleUnit}/setGpuPartitionSize'
at specification/azsadmin/resource-manager/fabric/Microsoft.Fabric.Admin/preview/2020-10-01/ScaleUnit.json:62

@akning-ms
Copy link
Contributor

akning-ms commented Oct 20, 2020

@akning-ms , could you help to see if this is caused by our validation logic can't handles provider name with two dots?

R3020 - PathResourceProviderNamePascalCase
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Fabric.Admin/fabricLocations/{location}/scaleUnits/{scaleUnit}/setGpuPartitionSize'
at specification/azsadmin/resource-manager/fabric/Microsoft.Fabric.Admin/preview/2020-10-01/ScaleUnit.json:62

Yes. This case already supported in new Lint version which will enable soon. @jianyexi for awareness

@jianyexi
Copy link
Contributor

jianyexi commented Oct 20, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 20, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@allenjzhang allenjzhang added Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates and removed Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Oct 20, 2020
@allenjzhang allenjzhang merged commit 88ee00b into Azure:master Oct 20, 2020
giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020
@LingyunSu
Azure Stack Fabric.Admin Api update for GPU support (Azure#11092)
8ffe5f7 
* FabricAdmin Old version

* Update on Fabric.Admin new version for GPU support

* Fix CI validation issue

* Validation fix

* Add default response for setGpuPartitionSize

* Add GPUP as a custom word
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bganapa bganapa bganapa approved these changes

+1 more reviewer

@allenjzhang allenjzhang allenjzhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@allenjzhang allenjzhang

Labels

Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LingyunSu @chiragg4u @bganapa @allenjzhang @akning-ms @jianyexi

Comments