Skip to content

Fixed incorrect type formats in SQL database #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balajikris merged 10 commits into from
Apr 19, 2017
Merged

Fixed incorrect type formats in SQL database #1107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ff1fe16
Fixed databaseId format
jaredmoo Mar 24, 2017
4a9a9f8
Fixed recoveryServicesRecoveryPointResourceId format
jaredmoo Mar 24, 2017
54fb52c
FIxed nullability of service objective properties
jaredmoo Apr 10, 2017
1792796
Fixed types of capabilities properties
jaredmoo Apr 10, 2017
30b5386
Fixed format of ElasticPoolActivityProperties operationId
jaredmoo Apr 10, 2017
6edc59c
Merge remote-tracking branch 'azure/master' into typefixes
jaredmoo Apr 11, 2017
bcb426e
Make activity operation id non-nullable
jaredmoo Apr 11, 2017
8307231
Use `false` instead of `false` for x-nullable
jaredmoo Apr 11, 2017
04506ec
Merge remote-tracking branch 'azure/master' into typefixes
jaredmoo Apr 14, 2017
af09c73
Fixed readonly/nullability for ServiceTierAdvisorProperties and SloUs…
jaredmoo Apr 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions arm-sql/2014-04-01/swagger/capabilities.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@
"readOnly": true,
"type": "integer",
"format": "int64",
"description": "The maximum size of the database (see 'unit' for the units)."
"description": "The maximum size of the database (see 'unit' for the units).",
"x-nullable": false
},
"unit": {
"readOnly": true,
Expand Down Expand Up @@ -118,7 +119,9 @@
"id": {
"readOnly": true,
"type": "string",
"description": "The unique ID of the service objective."
"format": "uuid",
Copy link
Contributor

@balajikris balajikris Apr 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autorest linter tags this as

WARNING: Guid used at the #/Definitions/ServiceObjectiveCapability/.../id. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.

@ravbhatnagar : what's the recommended change here? I do not have enough context on why guids are bad and what's the right way to fix this. I'll appreciate it if you can fill me and Jared in here.

Copy link
Contributor Author

@jaredmoo jaredmoo Apr 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately no change is possible. This is what the service is returning, and changing it at this point would be a REST API breaking change. We will have to consider removing this guid from the next api version.

Copy link
Contributor

@balajikris balajikris Apr 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Thought as much. Thanks for confirming

"description": "The unique ID of the service objective.",
"x-nullable": false
},
"supportedMaxSizes": {
"readOnly": true,
Expand Down
100 changes: 26 additions & 74 deletions arm-sql/2014-04-01/swagger/sql.core.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1499,7 +1499,9 @@
"operationId": {
"readOnly": true,
"type": "string",
"description": "The unique operation ID."
"format": "uuid",
"description": "The unique operation ID.",
"x-nullable": false
},
"percentComplete": {
"readOnly": true,
Expand Down Expand Up @@ -1659,7 +1661,8 @@
"readOnly": true,
"type": "string",
"format": "uuid",
"description": "The unique operation ID."
"description": "The unique operation ID.",
"x-nullable": false
},
"percentComplete": {
"readOnly": true,
Expand Down Expand Up @@ -1924,31 +1927,12 @@
"readOnly": true,
"type": "string",
"format": "uuid",
"enum": [
"dd6d99bb-f193-4ec1-86f2-43d3bccbc49c",
"f1173c43-91bd-4aaa-973c-54e79e15235b",
"1b1ebd4d-d903-4baa-97f9-4ea675f5e928",
"455330e1-00cd-488b-b5fa-177c226f28b7",
"789681b8-ca10-4eb0-bdf2-e0b050601b40",
"7203483a-c4fb-4304-9e9f-17c71c904f5d",
"a7d1b92d-c987-4375-b54d-2b1d0e0f5bb0",
"a7c4c615-cfb1-464b-b252-925be0a19446",
"26e021db-f1f9-4c98-84c6-92af8ef433d7",
"29dd7459-4a7c-4e56-be22-f0adda49440d",
"c99ac918-dbea-463f-a475-16ec020fdc12",
"620323bf-2879-4807-b30d-c2e6d7b3b3aa",
"33d0db1f-6893-4210-99f9-463fb9b496a4",
"da24338c-a6c9-46c2-a4bf-4ac95b496ae4"
],
"description": "The current service level objective ID of the database. This is the ID of the service level objective that is currently active.",
"x-ms-enum": {
"modelAsString": true,
"name": "ServiceObjectiveId"
}
"description": "The current service level objective ID of the database. This is the ID of the service level objective that is currently active."
},
"databaseId": {
"readOnly": true,
"type": "string",
"format": "uuid",
"description": "The ID of the database."
},
"earliestRestoreDate": {
Expand Down Expand Up @@ -1995,7 +1979,6 @@
},
"recoveryServicesRecoveryPointResourceId": {
"type": "string",
"format": "date-time",
"description": "Conditional. If createMode is RestoreLongTermRetentionBackup, then this value is required. Specifies the resource ID of the recovery point to restore from.",
"x-ms-mutability": [ "create" ]
},
Expand Down Expand Up @@ -2026,27 +2009,7 @@
"requestedServiceObjectiveId": {
"type": "string",
"format": "uuid",
"enum": [
"dd6d99bb-f193-4ec1-86f2-43d3bccbc49c",
"f1173c43-91bd-4aaa-973c-54e79e15235b",
"1b1ebd4d-d903-4baa-97f9-4ea675f5e928",
"455330e1-00cd-488b-b5fa-177c226f28b7",
"789681b8-ca10-4eb0-bdf2-e0b050601b40",
"7203483a-c4fb-4304-9e9f-17c71c904f5d",
"a7d1b92d-c987-4375-b54d-2b1d0e0f5bb0",
"a7c4c615-cfb1-464b-b252-925be0a19446",
"26e021db-f1f9-4c98-84c6-92af8ef433d7",
"29dd7459-4a7c-4e56-be22-f0adda49440d",
"c99ac918-dbea-463f-a475-16ec020fdc12",
"620323bf-2879-4807-b30d-c2e6d7b3b3aa",
"33d0db1f-6893-4210-99f9-463fb9b496a4",
"da24338c-a6c9-46c2-a4bf-4ac95b496ae4"
],
"description": "The configured service level objective ID of the database. This is the service level objective that is in the process of being applied to the database. Once successfully updated, it will match the value of currentServiceObjectiveId property. If requestedServiceObjectiveId and requestedServiceObjectiveName are both updated, the value of requestedServiceObjectiveId overrides the value of requestedServiceObjectiveName. To see possible values, query the capabilities API (/subscriptions/{subscriptionId}/providers/Microsoft.Sql/locations/{locationID}/capabilities) referred to by operationId: \"Capabilities_ListByLocation.\"",
"x-ms-enum": {
"modelAsString": true,
"name": "ServiceObjectiveId"
}
"description": "The configured service level objective ID of the database. This is the service level objective that is in the process of being applied to the database. Once successfully updated, it will match the value of currentServiceObjectiveId property. If requestedServiceObjectiveId and requestedServiceObjectiveName are both updated, the value of requestedServiceObjectiveId overrides the value of requestedServiceObjectiveName. To see possible values, query the capabilities API (/subscriptions/{subscriptionId}/providers/Microsoft.Sql/locations/{locationID}/capabilities) referred to by operationId: \"Capabilities_ListByLocation.\""
},
"requestedServiceObjectiveName": {
"type": "string",
Expand Down Expand Up @@ -2313,7 +2276,8 @@
"readOnly": true,
"type": "number",
"format": "double",
"description": "Gets or sets confidence for service tier advisor."
"description": "Gets or sets confidence for service tier advisor.",
"x-nullable": false
}
},
"description": "Represents the properties of a Service Tier Advisor."
Expand Down Expand Up @@ -2356,40 +2320,25 @@
"System2",
"ElasticPool"
],
"x-ms-enum": {
"modelAsString": true,
"name": "ServiceObjectiveName"
}
"x-ms-enum": {
"modelAsString": true,
"name": "ServiceObjectiveName"
},
"readOnly": true
},
"serviceLevelObjectiveId": {
"type": "string",
"format": "uuid",
"description": "The serviceLevelObjectiveId for SLO usage metric.",
"enum": [
"dd6d99bb-f193-4ec1-86f2-43d3bccbc49c",
"f1173c43-91bd-4aaa-973c-54e79e15235b",
"1b1ebd4d-d903-4baa-97f9-4ea675f5e928",
"455330e1-00cd-488b-b5fa-177c226f28b7",
"789681b8-ca10-4eb0-bdf2-e0b050601b40",
"7203483a-c4fb-4304-9e9f-17c71c904f5d",
"a7d1b92d-c987-4375-b54d-2b1d0e0f5bb0",
"a7c4c615-cfb1-464b-b252-925be0a19446",
"26e021db-f1f9-4c98-84c6-92af8ef433d7",
"29dd7459-4a7c-4e56-be22-f0adda49440d",
"c99ac918-dbea-463f-a475-16ec020fdc12",
"620323bf-2879-4807-b30d-c2e6d7b3b3aa",
"33d0db1f-6893-4210-99f9-463fb9b496a4",
"da24338c-a6c9-46c2-a4bf-4ac95b496ae4"
],
"x-ms-enum": {
"modelAsString": true,
"name": "ServiceObjectiveId"
}
"readOnly": true,
"x-nullable": false
},
"inRangeTimeRatio": {
"type": "number",
"format": "double",
"description": "Gets or sets inRangeTimeRatio for SLO usage metric."
"description": "Gets or sets inRangeTimeRatio for SLO usage metric.",
"readOnly": true,
"x-nullable": false
}
},
"description": "Represents a Slo Usage Metric."
Expand Down Expand Up @@ -2556,12 +2505,14 @@
"isDefault": {
"readOnly": true,
"type": "boolean",
"description": "Gets whether the service level objective is the default service objective."
"description": "Gets whether the service level objective is the default service objective.",
"x-nullable": false
},
"isSystem": {
"readOnly": true,
"type": "boolean",
"description": "Gets whether the service level objective is a system service objective."
"description": "Gets whether the service level objective is a system service objective.",
"x-nullable": false
},
"description": {
"readOnly": true,
Expand All @@ -2571,7 +2522,8 @@
"enabled": {
"readOnly": true,
"type": "boolean",
"description": "Gets whether the service level objective is enabled."
"description": "Gets whether the service level objective is enabled.",
"x-nullable": false
}
},
"description": "Represents the properties of a database service objective."
Expand Down