Skip to content

Fix a bug in Microsoft.Resources/deploymentScripts where tenantId property is missed from ManagedServiceIdentity. #11059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markcowl merged 3 commits into from
Oct 7, 2020
Merged

Fix a bug in Microsoft.Resources/deploymentScripts where tenantId property is missed from ManagedServiceIdentity. #11059

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38429a8
Update deploymentScripts.json
lwang2016 May 4, 2020
ad7e3d7
Merge branch 'master' of https://github.com/lwang2016/azure-rest-api-…
lwang2016 Oct 7, 2020
68867f2
Update deploymentScripts.json
lwang2016 Oct 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...es/resource-manager/Microsoft.Resources/preview/2019-10-01-preview/deploymentScripts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,6 +752,10 @@
"modelAsString": true
}
},
"tenantId": {
Copy link
Member

@majastrz majastrz Oct 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Info for other reviewers: The service has always returned the tenant ID. @lwang2016 is fixing a swagger accuracy issue.

Copy link
Member Author

@lwang2016 lwang2016 Oct 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Thanks for the clarification @majastrz

"type": "string",
"description": "ID of the Azure Active Directory."
},
"userAssignedIdentities": {
"type": "object",
"description": "The list of user-assigned managed identities associated with the resource. Key is the Azure resource Id of the managed identity.",
Expand Down