Skip to content

Update keyvault.json #11042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allenjzhang merged 1 commit into from
Oct 11, 2020
Merged

Update keyvault.json #11042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/keyvault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,6 +983,7 @@
"items": {
"type": "string",
"enum": [
"all",
Copy link
Member

@heaths heaths Oct 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these real values the service supports? And is that on the data plane as well?

Copy link
Contributor

@sadasant sadasant Oct 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also concerned about whether this is a real value the service supports. Data plane doesn't seem to have it, unless I'm missing something.

Worth noting is that this PR most likely comes from this customer issue: Azure/azure-sdk-for-js#10705

"encrypt",
"decrypt",
"wrapKey",
Expand Down Expand Up @@ -1012,6 +1013,7 @@
"items": {
"type": "string",
"enum": [
"all",
"get",
"list",
"set",
Expand All @@ -1033,6 +1035,7 @@
"items": {
"type": "string",
"enum": [
"all",
"get",
"list",
"delete",
Expand Down Expand Up @@ -1062,6 +1065,7 @@
"items": {
"type": "string",
"enum": [
"all",
"get",
"list",
"delete",
Expand Down