Skip to content

Conversation

@audunn
Copy link
Member

@audunn audunn commented Sep 30, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 30, 2020

[Staging] Swagger Validation Report

BreakingChange: 12 Errors, 0 Warnings [Detail] [Expand] Only 10 items are listed, please refer to log for more details.
Rule Message
1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
New: Microsoft.NetApp/stable/2020-02-01/netapp.json#L2186:9
Old: Microsoft.NetApp/stable/2020-02-01/netapp.json#L2186:9
1036 - ConstraintChanged The new version has a different 'maxLength' value than the previous one.
New: Microsoft.NetApp/stable/2020-03-01/netapp.json#L2186:9
Old: Microsoft.NetApp/stable/2020-03-01/netapp.json#L2186:9
1036 - ConstraintChanged The new version has a different 'maxLength' value than the previous one.
New: Microsoft.NetApp/stable/2020-02-01/netapp.json#L2186:9
Old: Microsoft.NetApp/stable/2020-02-01/netapp.json#L2186:9
1036 - ConstraintChanged The new version has a different 'minLength' value than the previous one.
New: Microsoft.NetApp/stable/2020-02-01/netapp.json#L2186:9
Old: Microsoft.NetApp/stable/2020-02-01/netapp.json#L2186:9
1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
New: Microsoft.NetApp/stable/2020-02-01/netapp.json#L2186:9
Old: Microsoft.NetApp/stable/2020-02-01/netapp.json#L2186:9
1036 - ConstraintChanged The new version has a different 'minLength' value than the previous one.
New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L3392:9
Old: Microsoft.NetApp/stable/2020-06-01/netapp.json#L3392:9
1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
New: Microsoft.NetApp/stable/2020-03-01/netapp.json#L2186:9
Old: Microsoft.NetApp/stable/2020-03-01/netapp.json#L2186:9
1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L3392:9
Old: Microsoft.NetApp/stable/2020-06-01/netapp.json#L3392:9
1036 - ConstraintChanged The new version has a different 'minLength' value than the previous one.
New: Microsoft.NetApp/stable/2020-03-01/netapp.json#L2186:9
Old: Microsoft.NetApp/stable/2020-03-01/netapp.json#L2186:9
1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
New: Microsoft.NetApp/stable/2020-03-01/netapp.json#L2186:9
Old: Microsoft.NetApp/stable/2020-03-01/netapp.json#L2186:9
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 30, 2020

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 30, 2020

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 30, 2020

azure-sdk-for-java

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 30, 2020

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 2543854 with merge commit d64422165767402e04bfa12bd96454f24e891a5f. SDK Automation 13.0.17.20200918.2
  • ️✔️@azure/arm-netapp [View full logs]  [Preview SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/azureNetAppFilesManagementClient.js → ./dist/arm-netapp.js...
    [npmPack] created ./dist/arm-netapp.js in 381ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 5.1kB   esm/operations/accountBackups.js                    
    [npmPack] npm notice 954B    esm/models/accountBackupsMappers.js                 
    [npmPack] npm notice 9.3kB   esm/operations/accounts.js                          
    [npmPack] npm notice 954B    esm/models/accountsMappers.js                       
    [npmPack] npm notice 226.3kB dist/arm-netapp.js                                  
    [npmPack] npm notice 74.1kB  dist/arm-netapp.min.js                              
    [npmPack] npm notice 2.4kB   esm/azureNetAppFilesManagementClient.js             
    [npmPack] npm notice 2.7kB   esm/azureNetAppFilesManagementClientContext.js      
    [npmPack] npm notice 9.1kB   esm/operations/backupPolicies.js                    
    [npmPack] npm notice 980B    esm/models/backupPoliciesMappers.js                 
    [npmPack] npm notice 10.2kB  esm/operations/backups.js                           
    [npmPack] npm notice 947B    esm/models/backupsMappers.js                        
    [npmPack] npm notice 345B    esm/models/index.js                                 
    [npmPack] npm notice 681B    esm/operations/index.js                             
    [npmPack] npm notice 76.7kB  esm/models/mappers.js                               
    [npmPack] npm notice 4.8kB   esm/operations/netAppResource.js                    
    [npmPack] npm notice 495B    esm/models/netAppResourceMappers.js                 
    [npmPack] npm notice 1.6kB   esm/operations/operations.js                        
    [npmPack] npm notice 509B    esm/models/operationsMappers.js                     
    [npmPack] npm notice 3.3kB   esm/models/parameters.js                            
    [npmPack] npm notice 10.0kB  esm/operations/pools.js                             
    [npmPack] npm notice 950B    esm/models/poolsMappers.js                          
    [npmPack] npm notice 990B    rollup.config.js                                    
    [npmPack] npm notice 9.0kB   esm/operations/snapshotPolicies.js                  
    [npmPack] npm notice 1.0kB   esm/models/snapshotPoliciesMappers.js               
    [npmPack] npm notice 11.6kB  esm/operations/snapshots.js                         
    [npmPack] npm notice 951B    esm/models/snapshotsMappers.js                      
    [npmPack] npm notice 1.9kB   esm/operations/vaults.js                            
    [npmPack] npm notice 944B    esm/models/vaultsMappers.js                         
    [npmPack] npm notice 29.9kB  esm/operations/volumes.js                           
    [npmPack] npm notice 1.0kB   esm/models/volumesMappers.js                        
    [npmPack] npm notice 1.7kB   package.json                                        
    [npmPack] npm notice 457B    tsconfig.json                                       
    [npmPack] npm notice 1.7kB   esm/operations/accountBackups.d.ts.map              
    [npmPack] npm notice 2.6kB   esm/operations/accountBackups.js.map                
    [npmPack] npm notice 523B    esm/models/accountBackupsMappers.d.ts.map           
    [npmPack] npm notice 536B    esm/models/accountBackupsMappers.js.map             
    [npmPack] npm notice 2.2kB   esm/operations/accounts.d.ts.map                    
    [npmPack] npm notice 4.5kB   esm/operations/accounts.js.map                      
    [npmPack] npm notice 514B    esm/models/accountsMappers.d.ts.map                 
    [npmPack] npm notice 527B    esm/models/accountsMappers.js.map                   
    [npmPack] npm notice 400.9kB dist/arm-netapp.js.map                              
    [npmPack] npm notice 59.2kB  dist/arm-netapp.min.js.map                          
    [npmPack] npm notice 1.0kB   esm/azureNetAppFilesManagementClient.d.ts.map       
    [npmPack] npm notice 1.4kB   esm/azureNetAppFilesManagementClient.js.map         
    [npmPack] npm notice 531B    esm/azureNetAppFilesManagementClientContext.d.ts.map
    [npmPack] npm notice 1.4kB   esm/azureNetAppFilesManagementClientContext.js.map  
    [npmPack] npm notice 2.7kB   esm/operations/backupPolicies.d.ts.map              
    [npmPack] npm notice 4.5kB   esm/operations/backupPolicies.js.map                
    [npmPack] npm notice 539B    esm/models/backupPoliciesMappers.d.ts.map           
    [npmPack] npm notice 552B    esm/models/backupPoliciesMappers.js.map             
    [npmPack] npm notice 3.1kB   esm/operations/backups.d.ts.map                     
    [npmPack] npm notice 5.1kB   esm/operations/backups.js.map                       
    [npmPack] npm notice 509B    esm/models/backupsMappers.d.ts.map                  
    [npmPack] npm notice 522B    esm/models/backupsMappers.js.map                    
    [npmPack] npm notice 26.8kB  esm/models/index.d.ts.map                           
    [npmPack] npm notice 355B    esm/operations/index.d.ts.map                       
    [npmPack] npm notice 126B    esm/models/index.js.map                             
    [npmPack] npm notice 370B    esm/operations/index.js.map                         
    [npmPack] npm notice 2.9kB   esm/models/mappers.d.ts.map                         
    [npmPack] npm notice 41.3kB  esm/models/mappers.js.map                           
    [npmPack] npm notice 2.2kB   esm/operations/netAppResource.d.ts.map              
    [npmPack] npm notice 2.8kB   esm/operations/netAppResource.js.map                
    [npmPack] npm notice 226B    esm/models/netAppResourceMappers.d.ts.map           
    [npmPack] npm notice 239B    esm/models/netAppResourceMappers.js.map             
    [npmPack] npm notice 664B    esm/operations/operations.d.ts.map                  
    [npmPack] npm notice 908B    esm/operations/operations.js.map                    
    [npmPack] npm notice 251B    esm/models/operationsMappers.d.ts.map               
    [npmPack] npm notice 264B    esm/models/operationsMappers.js.map                 
    [npmPack] npm notice 731B    esm/models/parameters.d.ts.map                      
    [npmPack] npm notice 2.4kB   esm/models/parameters.js.map                        
    [npmPack] npm notice 2.4kB   esm/operations/pools.d.ts.map                       
    [npmPack] npm notice 4.7kB   esm/operations/pools.js.map                         
    [npmPack] npm notice 508B    esm/models/poolsMappers.d.ts.map                    
    [npmPack] npm notice 521B    esm/models/poolsMappers.js.map                      
    [npmPack] npm notice 3.4kB   esm/operations/snapshotPolicies.d.ts.map            
    [npmPack] npm notice 4.8kB   esm/operations/snapshotPolicies.js.map              
    [npmPack] npm notice 556B    esm/models/snapshotPoliciesMappers.d.ts.map         
    [npmPack] npm notice 569B    esm/models/snapshotPoliciesMappers.js.map           
    [npmPack] npm notice 2.9kB   esm/operations/snapshots.d.ts.map                   
    [npmPack] npm notice 5.3kB   esm/operations/snapshots.js.map                     
    [npmPack] npm notice 513B    esm/models/snapshotsMappers.d.ts.map                
    [npmPack] npm notice 526B    esm/models/snapshotsMappers.js.map                  
    [npmPack] npm notice 784B    esm/operations/vaults.d.ts.map                      
    [npmPack] npm notice 1.0kB   esm/operations/vaults.js.map                        
    [npmPack] npm notice 507B    esm/models/vaultsMappers.d.ts.map                   
    [npmPack] npm notice 520B    esm/models/vaultsMappers.js.map                     

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 30, 2020

azure-sdk-for-python

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 2543854 with merge commit d64422165767402e04bfa12bd96454f24e891a5f. SDK Automation 13.0.17.20200918.2
  • ️✔️azure-mgmt-netapp [View full logs]  [Preview SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-netapp
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-netapp
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 4.381% size of original (original: 53595 chars, delta: 2348 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model SnapshotPolicyPatch has a new parameter provisioning_state
    [ChangeLog]   - Model SnapshotPolicyPatch has a new parameter name1
    [ChangeLog]   - Model SnapshotPolicy has a new parameter provisioning_state
    [ChangeLog]   - Model SnapshotPolicy has a new parameter name1
    [ChangeLog]   - Model SnapshotPolicyDetails has a new parameter provisioning_state
    [ChangeLog]   - Model SnapshotPolicyDetails has a new parameter name1

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 30, 2020

azure-sdk-for-python-track2

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 30, 2020

azure-resource-manager-schemas

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 2543854 with merge commit d64422165767402e04bfa12bd96454f24e891a5f. Schema Automation 13.0.17.20200918.2
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 30, 2020

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 30, 2020

Trenton Generation

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 2543854 with merge commit d64422165767402e04bfa12bd96454f24e891a5f. Trenton Automation 13.0.17.20200918.2
    Only show 100 items here, please refer to log for details.
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ServiceSpecification' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MetricSpecification' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Dimension' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'volumeProperties-exportPolicy' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'volumeProperties-dataProtection' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'volumePatchProperties-exportPolicy' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'volumePatchProperties-dataProtection' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
    [AutoRest] WARNING (): 'cli.flatten.cli-flatten-set-enabled' is not set to true, skip flattenSetter
    [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
    Failed to find any changed packages. Please check the changed file list.
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-05-01/netapp/accounts.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-05-01/netapp/client.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-05-01/netapp/enums.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-05-01/netapp/models.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-05-01/netapp/mounttargets.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-05-01/netapp/netappapi/interfaces.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-05-01/netapp/operations.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-05-01/netapp/pools.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-05-01/netapp/snapshots.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-05-01/netapp/version.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-05-01/netapp/volumes.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-06-01/netapp/accounts.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-06-01/netapp/client.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-06-01/netapp/enums.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-06-01/netapp/models.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-06-01/netapp/mounttargets.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-06-01/netapp/netappapi/interfaces.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-06-01/netapp/operations.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-06-01/netapp/pools.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-06-01/netapp/snapshots.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-06-01/netapp/version.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-06-01/netapp/volumes.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-07-01/netapp/accounts.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-07-01/netapp/client.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-07-01/netapp/enums.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-07-01/netapp/models.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-07-01/netapp/mounttargets.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-07-01/netapp/netappapi/interfaces.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-07-01/netapp/operations.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-07-01/netapp/pools.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-07-01/netapp/snapshots.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-07-01/netapp/version.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-07-01/netapp/volumes.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-08-01/netapp/accounts.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-08-01/netapp/client.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-08-01/netapp/enums.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-08-01/netapp/models.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-08-01/netapp/mounttargets.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-08-01/netapp/netappapi/interfaces.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-08-01/netapp/operations.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-08-01/netapp/pools.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-08-01/netapp/resource.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-08-01/netapp/snapshots.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-08-01/netapp/version.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-08-01/netapp/volumes.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-10-01/netapp/accounts.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-10-01/netapp/client.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-10-01/netapp/enums.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-10-01/netapp/models.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-10-01/netapp/mounttargets.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-10-01/netapp/netappapi/interfaces.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-10-01/netapp/operations.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-10-01/netapp/pools.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-10-01/netapp/resource.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-10-01/netapp/snapshots.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-10-01/netapp/version.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-10-01/netapp/volumes.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-11-01/netapp/accounts.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-11-01/netapp/client.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-11-01/netapp/enums.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-11-01/netapp/models.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-11-01/netapp/netappapi/interfaces.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-11-01/netapp/operations.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-11-01/netapp/pools.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-11-01/netapp/resource.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-11-01/netapp/snapshots.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-11-01/netapp/version.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2019-11-01/netapp/volumes.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2020-02-01/netapp/accounts.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2020-02-01/netapp/client.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2020-02-01/netapp/enums.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2020-02-01/netapp/models.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2020-02-01/netapp/netappapi/interfaces.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2020-02-01/netapp/operations.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2020-02-01/netapp/pools.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2020-02-01/netapp/resource.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2020-02-01/netapp/snapshots.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2020-02-01/netapp/version.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2020-02-01/netapp/volumes.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2020-03-01/netapp/accounts.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2020-03-01/netapp/client.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2020-03-01/netapp/enums.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2020-03-01/netapp/models.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2020-03-01/netapp/netappapi/interfaces.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2020-03-01/netapp/operations.go
    /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/netapp/mgmt/2020-03-01/netapp/pools.go

This was referenced Sep 30, 2020
@markcowl
Copy link
Member

markcowl commented Oct 1, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@audunn
Copy link
Member Author

audunn commented Oct 6, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@audunn
Copy link
Member Author

audunn commented Oct 6, 2020

@markcowl can we get this merged or does this need more work? Note sdk's need to be generated for this update.
ARM says this does not need ARM review "This PR doesn’t require ARM API review"

@markcowl
Copy link
Member

markcowl commented Oct 6, 2020

@audunn The issue is that this is a breaking change in existing swagger specs, which couldresult in breaking changes in SDKs. Why are we making this change in existing api-versions?

@audunn
Copy link
Member Author

audunn commented Oct 6, 2020

@audunn The issue is that this is a breaking change in existing swagger specs, which could result in breaking changes in SDKs. Why are we making this change in existing api-versions?

@markcowl This PR is to correct incorrectness in the spec that can it-self cause issues, and also serves to align this between API versions. SDK's will not be generated based on this but on newer api versions. Note the solution is in preview.
Should we rather leave this as is and fix forward?

@markcowl
Copy link
Member

markcowl commented Oct 7, 2020

@audunn Yes, we should fix forward. Closing the PR. Please pint me (markcowl) if you would like this reopened for any reason.

@markcowl markcowl closed this Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants