-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[NetAppFiles]Bug fix Remove limit on readonly property #10997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go
|
azure-sdk-for-java
|
azure-sdk-for-js
|
azure-sdk-for-python
|
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net
|
Trenton Generation
|
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
…into SwaggerInternalReviewIssues
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@markcowl can we get this merged or does this need more work? Note sdk's need to be generated for this update. |
|
@audunn The issue is that this is a breaking change in existing swagger specs, which couldresult in breaking changes in SDKs. Why are we making this change in existing api-versions? |
@markcowl This PR is to correct incorrectness in the spec that can it-self cause issues, and also serves to align this between API versions. SDK's will not be generated based on this but on newer api versions. Note the solution is in preview. |
|
@audunn Yes, we should fix forward. Closing the PR. Please pint me (markcowl) if you would like this reopened for any reason. |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.