Skip to content

Conversation

@abhishekbhol
Copy link
Contributor

@abhishekbhol abhishekbhol commented Sep 28, 2020

added managedVirtualNetworkSettings definition.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 28, 2020

[Staging] Swagger Validation Report

BreakingChange: 1 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1041 - AddedPropertyInResponse The new version has a new property 'managedVirtualNetworkSettings' in response that was not found in the old version.
New: Microsoft.Synapse/preview/2019-06-01-preview/workspace.json#L771:7
Old: Microsoft.Synapse/preview/2019-06-01-preview/workspace.json#L749:7
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 28, 2020

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 98e41e3 with merge commit 5c4f2ee. SDK Automation 13.0.17.20200918.2
  • ️✔️azure-mgmt-synapse [View full logs]  [Release SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-synapse
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-synapse
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 13 Oct 2020 04:41:38 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0443:4251:2764AF0:4162D76:5F853002","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 1.489% size of original (original: 120876 chars, delta: 1800 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model Workspace has a new parameter managed_virtual_network_settings
    [ChangeLog]   - Model WorkspacePatchInfo has a new parameter managed_virtual_network_settings
    [ChangeLog]   - Model BigDataPoolResourceInfo has a new parameter spark_config_properties

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 28, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 28, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 98e41e3 with merge commit 5c4f2ee. SDK Automation 13.0.17.20200918.2
  • ️✔️preview/synapse/mgmt/2019-06-01-preview [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 13 Oct 2020 04:44:42 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"07C2:DBDA:E4892C6:10AB3C5F:5F8530BA","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 28, 2020

azure-resource-manager-schemas - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 98e41e3 with merge commit 5c4f2ee. Schema Automation 13.0.17.20200918.2
    [synapse][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [synapse][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [synapse][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
  • ️✔️synapse [View full logs]  [Release Schema Changes]
      [after_scripts|node] PostProcessor finished successfully.
      [after_scripts|node]   5775 passing (1m)
      AzureResourceSchema has no registered package commands.
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 13 Oct 2020 04:46:21 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0742:0A71:24B68E7:3C37688:5F85311D","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 28, 2020

    azure-sdk-for-java - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 98e41e3 with merge commit 5c4f2ee. SDK Automation 13.0.17.20200918.2
    • ⚠️sdk/synapse/mgmt-v2019_06_01_preview [View full logs]  [Release SDK Changes]
        [mvn] [ERROR] COMPILATION ERROR : 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/BigDataPoolsInner.java:[17,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/OperationsInner.java:[15,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IpFirewallRulesInner.java:[16,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolsInner.java:[16,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolMetadataSyncConfigsInner.java:[13,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspacesInner.java:[19,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceAadAdminsInner.java:[15,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceManagedIdentitySqlControlSettingsInner.java:[13,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateEndpointConnectionsInner.java:[15,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateLinkHubsInner.java:[19,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolVulnerabilityAssessmentRuleBaselinesImpl.java:[42,119] cannot find symbol
        [mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
        [mvn]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolVulnerabilityAssessmentRuleBaselinesImpl
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[24,50] cannot find symbol
        [mvn]   symbol: class ManagedIntegrationRuntime
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[25,53] cannot find symbol
        [mvn]   symbol: class SelfHostedIntegrationRuntime
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-synapse: Compilation failure: Compilation failure: 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/BigDataPoolsInner.java:[17,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/OperationsInner.java:[15,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IpFirewallRulesInner.java:[16,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolsInner.java:[16,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolMetadataSyncConfigsInner.java:[13,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspacesInner.java:[19,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceAadAdminsInner.java:[15,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceManagedIdentitySqlControlSettingsInner.java:[13,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateEndpointConnectionsInner.java:[15,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateLinkHubsInner.java:[19,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolVulnerabilityAssessmentRuleBaselinesImpl.java:[42,119] cannot find symbol
        [mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
        [mvn] [ERROR]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolVulnerabilityAssessmentRuleBaselinesImpl
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[24,50] cannot find symbol
        [mvn] [ERROR]   symbol: class ManagedIntegrationRuntime
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[25,53] cannot find symbol
        [mvn] [ERROR]   symbol: class SelfHostedIntegrationRuntime
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
        Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 13 Oct 2020 04:45:26 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0441:5672:12E74CA:2EDDC06:5F8530E6","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Sep 28, 2020

      azure-sdk-for-python-track2 - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Sep 28, 2020

      azure-sdk-for-net - Release

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from 98e41e3 with merge commit 5c4f2ee. SDK Automation 13.0.17.20200918.2
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
      • ️✔️Microsoft.Azure.Management.Synapse [View full logs]  [Release SDK Changes]
        Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 13 Oct 2020 04:45:04 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"05C0:3288:AE486D:1C12E82:5F8530D0","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Sep 28, 2020

      azure-sdk-for-js - Release

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from 98e41e3 with merge commit 5c4f2ee. SDK Automation 13.0.17.20200918.2
      • ️✔️@azure/arm-synapse [View full logs]  [Release SDK Changes]
        Only show 100 items here, please refer to log for details.
        [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
        [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
        [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
        [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
        [npmPack] loaded rollup.config.js with warnings
        [npmPack] (!) Unused external imports
        [npmPack] default imported from external module 'rollup' but never used
        [npmPack] 
        [npmPack] ./esm/synapseManagementClient.js → ./dist/arm-synapse.js...
        [npmPack] created ./dist/arm-synapse.js in 1s
        [npmPack] npm notice 
        [npmPack] npm notice package: @azure/[email protected]
        [npmPack] npm notice === Tarball Contents === 
        [npmPack] npm notice 539.1kB dist/arm-synapse.js                                                   
        [npmPack] npm notice 199.7kB dist/arm-synapse.min.js                                               
        [npmPack] npm notice 10.5kB  esm/operations/bigDataPools.js                                        
        [npmPack] npm notice 2.3kB   esm/models/bigDataPoolsMappers.js                                     
        [npmPack] npm notice 345B    esm/models/index.js                                                   
        [npmPack] npm notice 2.0kB   esm/operations/index.js                                               
        [npmPack] npm notice 3.8kB   esm/operations/integrationRuntimeAuthKeysOperations.js                
        [npmPack] npm notice 518B    esm/models/integrationRuntimeAuthKeysOperationsMappers.js             
        [npmPack] npm notice 2.3kB   esm/operations/integrationRuntimeConnectionInfos.js                   
        [npmPack] npm notice 478B    esm/models/integrationRuntimeConnectionInfosMappers.js                
        [npmPack] npm notice 2.2kB   esm/operations/integrationRuntimeCredentials.js                       
        [npmPack] npm notice 440B    esm/models/integrationRuntimeCredentialsMappers.js                    
        [npmPack] npm notice 2.4kB   esm/operations/integrationRuntimeMonitoringDataOperations.js          
        [npmPack] npm notice 525B    esm/models/integrationRuntimeMonitoringDataOperationsMappers.js       
        [npmPack] npm notice 2.4kB   esm/operations/integrationRuntimeNodeIpAddressOperations.js           
        [npmPack] npm notice 485B    esm/models/integrationRuntimeNodeIpAddressOperationsMappers.js        
        [npmPack] npm notice 5.1kB   esm/operations/integrationRuntimeNodes.js                             
        [npmPack] npm notice 505B    esm/models/integrationRuntimeNodesMappers.js                          
        [npmPack] npm notice 3.7kB   esm/operations/integrationRuntimeObjectMetadata.js                    
        [npmPack] npm notice 669B    esm/models/integrationRuntimeObjectMetadataMappers.js                 
        [npmPack] npm notice 13.9kB  esm/operations/integrationRuntimes.js                                 
        [npmPack] npm notice 2.6kB   esm/models/integrationRuntimesMappers.js                              
        [npmPack] npm notice 2.3kB   esm/operations/integrationRuntimeStatusOperations.js                  
        [npmPack] npm notice 739B    esm/models/integrationRuntimeStatusOperationsMappers.js               
        [npmPack] npm notice 10.9kB  esm/operations/ipFirewallRules.js                                     
        [npmPack] npm notice 2.4kB   esm/models/ipFirewallRulesMappers.js                                  
        [npmPack] npm notice 149.9kB esm/models/mappers.js                                                 
        [npmPack] npm notice 5.2kB   esm/operations/operations.js                                          
        [npmPack] npm notice 763B    esm/models/operationsMappers.js                                       
        [npmPack] npm notice 9.1kB   esm/models/parameters.js                                              
        [npmPack] npm notice 8.9kB   esm/operations/privateEndpointConnections.js                          
        [npmPack] npm notice 2.3kB   esm/models/privateEndpointConnectionsMappers.js                       
        [npmPack] npm notice 8.8kB   esm/operations/privateLinkHubs.js                                     
        [npmPack] npm notice 2.3kB   esm/models/privateLinkHubsMappers.js                                  
        [npmPack] npm notice 3.9kB   esm/operations/privateLinkResources.js                                
        [npmPack] npm notice 2.2kB   esm/models/privateLinkResourcesMappers.js                             
        [npmPack] npm notice 983B    rollup.config.js                                                      
        [npmPack] npm notice 3.8kB   esm/operations/sqlPoolBlobAuditingPolicies.js                         
        [npmPack] npm notice 2.2kB   esm/models/sqlPoolBlobAuditingPoliciesMappers.js                      
        [npmPack] npm notice 2.2kB   esm/operations/sqlPoolConnectionPolicies.js                           
        [npmPack] npm notice 2.2kB   esm/models/sqlPoolConnectionPoliciesMappers.js                        
        [npmPack] npm notice 2.3kB   esm/operations/sqlPoolDataWarehouseUserActivities.js                  
        [npmPack] npm notice 2.2kB   esm/models/sqlPoolDataWarehouseUserActivitiesMappers.js               
        [npmPack] npm notice 2.2kB   esm/operations/sqlPoolGeoBackupPolicies.js                            
        [npmPack] npm notice 2.2kB   esm/models/sqlPoolGeoBackupPoliciesMappers.js                         
        [npmPack] npm notice 3.6kB   esm/operations/sqlPoolMetadataSyncConfigs.js                          
        [npmPack] npm notice 2.3kB   esm/models/sqlPoolMetadataSyncConfigsMappers.js                       
        [npmPack] npm notice 2.4kB   esm/operations/sqlPoolOperationResults.js                             
        [npmPack] npm notice 434B    esm/models/sqlPoolOperationResultsMappers.js                          
        [npmPack] npm notice 2.8kB   esm/operations/sqlPoolOperations.js                                   
        [npmPack] npm notice 2.3kB   esm/models/sqlPoolOperationsMappers.js                                
        [npmPack] npm notice 2.9kB   esm/operations/sqlPoolReplicationLinks.js                             
        [npmPack] npm notice 2.2kB   esm/models/sqlPoolReplicationLinksMappers.js                          
        [npmPack] npm notice 5.5kB   esm/operations/sqlPoolRestorePoints.js                                
        [npmPack] npm notice 2.3kB   esm/models/sqlPoolRestorePointsMappers.js                             
        [npmPack] npm notice 15.5kB  esm/operations/sqlPools.js                                            
        [npmPack] npm notice 2.8kB   esm/operations/sqlPoolSchemas.js                                      
        [npmPack] npm notice 2.2kB   esm/models/sqlPoolSchemasMappers.js                                   
        [npmPack] npm notice 3.8kB   esm/operations/sqlPoolSecurityAlertPolicies.js                        
        [npmPack] npm notice 2.2kB   esm/models/sqlPoolSecurityAlertPoliciesMappers.js                     
        [npmPack] npm notice 11.1kB  esm/operations/sqlPoolSensitivityLabels.js                            
        [npmPack] npm notice 2.2kB   esm/models/sqlPoolSensitivityLabelsMappers.js                         
        [npmPack] npm notice 2.3kB   esm/models/sqlPoolsMappers.js                                         
        [npmPack] npm notice 3.1kB   esm/operations/sqlPoolTableColumns.js                                 
        [npmPack] npm notice 2.2kB   esm/models/sqlPoolTableColumnsMappers.js                              
        [npmPack] npm notice 2.9kB   esm/operations/sqlPoolTables.js                                       
        [npmPack] npm notice 2.2kB   esm/models/sqlPoolTablesMappers.js                                    
        [npmPack] npm notice 3.9kB   esm/operations/sqlPoolTransparentDataEncryptions.js                   
        [npmPack] npm notice 2.2kB   esm/models/sqlPoolTransparentDataEncryptionsMappers.js                
        [npmPack] npm notice 2.7kB   esm/operations/sqlPoolUsages.js                                       
        [npmPack] npm notice 462B    esm/models/sqlPoolUsagesMappers.js                                    
        [npmPack] npm notice 4.3kB   esm/operations/sqlPoolVulnerabilityAssessmentRuleBaselines.js         
        [npmPack] npm notice 2.2kB   esm/models/sqlPoolVulnerabilityAssessmentRuleBaselinesMappers.js      
        [npmPack] npm notice 6.9kB   esm/operations/sqlPoolVulnerabilityAssessments.js                     
        [npmPack] npm notice 7.0kB   esm/operations/sqlPoolVulnerabilityAssessmentScans.js                 
        [npmPack] npm notice 2.3kB   esm/models/sqlPoolVulnerabilityAssessmentScansMappers.js              
        [npmPack] npm notice 2.3kB   esm/models/sqlPoolVulnerabilityAssessmentsMappers.js                  
        [npmPack] npm notice 4.9kB   esm/synapseManagementClient.js                                        
        [npmPack] npm notice 2.5kB   esm/synapseManagementClientContext.js                                 
        [npmPack] npm notice 6.4kB   esm/operations/workspaceAadAdmins.js                                  
        [npmPack] npm notice 2.3kB   esm/models/workspaceAadAdminsMappers.js                               
        [npmPack] npm notice 3.7kB   esm/operations/workspaceManagedIdentitySqlControlSettings.js          
        [npmPack] npm notice 2.3kB   esm/models/workspaceManagedIdentitySqlControlSettingsMappers.js       
        [npmPack] npm notice 11.7kB  esm/operations/workspaces.js                                          
        [npmPack] npm notice 2.4kB   esm/models/workspacesMappers.js                                       
        [npmPack] npm notice 1.6kB   package.json                                                          
        [npmPack] npm notice 457B    tsconfig.json                                                         

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Sep 28, 2020

      Trenton Generation - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @abhishekbhol abhishekbhol marked this pull request as draft September 28, 2020 17:21
      @chiragg4u chiragg4u added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 6, 2020
      @chiragg4u
      Copy link
      Contributor

      Do not Merge. Need a confirm few things

      Added DonotMerge tag

      @chiragg4u
      Copy link
      Contributor

      As identified in the automated checks there are breaking changes, Please follow Azure Breaking changes approval request form as defined @ Breaking Change Process

      @abhishekbhol abhishekbhol marked this pull request as ready for review October 8, 2020 06:20
      @abhishekbhol
      Copy link
      Contributor Author

      Hi @chiragg4u I have verified that the changes are safe. Please remove the Do not merge tag and merge this PR.

      @abhishekbhol
      Copy link
      Contributor Author

      Verified with @idear1203 these addition of new property is not a breaking change for Synapse. Please take this PR to completion as some features are blocked on this.

      @chiragg4u chiragg4u removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 9, 2020
      @erich-wang erich-wang added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 10, 2020
      @erich-wang
      Copy link
      Member

      Adding new property in response is considered as breaking change, please check https://github.com/Azure/openapi-diff/blob/master/docs/rules/1041.md.
      However, considering this API version is in preview and less than one year, breaking change is allowed if you service team sign off the breaking change.

      @abhishekbhol , please confirm service team wants to merge this breaking change and understands the impact to existing customers, then I'll merge this PR, thanks.

      @abhishekbhol
      Copy link
      Contributor Author

      Hi @erich-wang , I have confirmed RP Synapse wants to merge this change. Please go ahead and merge it. Thanks

      @erich-wang erich-wang merged commit 5c4f2ee into Azure:master Oct 13, 2020
      "description": "Managed Virtual Network Settings",
      "type": "object",
      "properties": {
      "preventDataExfiltration": {
      Copy link
      Member

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      Is there a typo here, should it be preventDataExfilteration?

      Copy link
      Contributor

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      No, I don't think it is a typo. It should be data exfiltration

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

      Labels

      Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374

      Projects

      None yet

      Development

      Successfully merging this pull request may close these issues.

      5 participants