-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Data Exfilteration related changes #10964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Exfilteration related changes #10964
Conversation
[Staging] Swagger Validation Report
❌ |
| Rule | Message |
|---|---|
1041 - AddedPropertyInResponse |
The new version has a new property 'managedVirtualNetworkSettings' in response that was not found in the old version. New: Microsoft.Synapse/preview/2019-06-01-preview/workspace.json#L771:7 Old: Microsoft.Synapse/preview/2019-06-01-preview/workspace.json#L749:7 |
️️✔️LintDiff [Detail]
️✔️Validation passes for LintDiff.
️️✔️Avocado [Detail]
️✔️Validation passes for Avocado.
️️✔️ModelValidation [Detail]
️✔️Validation passes for ModelValidation.
️️✔️SemanticValidation [Detail]
️✔️Validation passes for SemanticValidation.
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-resource-manager-schemas - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
Added DonotMerge tag |
|
As identified in the automated checks there are breaking changes, Please follow Azure Breaking changes approval request form as defined @ Breaking Change Process |
|
Hi @chiragg4u I have verified that the changes are safe. Please remove the Do not merge tag and merge this PR. |
|
Verified with @idear1203 these addition of new property is not a breaking change for Synapse. Please take this PR to completion as some features are blocked on this. |
|
Adding new property in response is considered as breaking change, please check https://github.com/Azure/openapi-diff/blob/master/docs/rules/1041.md. @abhishekbhol , please confirm service team wants to merge this breaking change and understands the impact to existing customers, then I'll merge this PR, thanks. |
|
Hi @erich-wang , I have confirmed RP Synapse wants to merge this change. Please go ahead and merge it. Thanks |
| "description": "Managed Virtual Network Settings", | ||
| "type": "object", | ||
| "properties": { | ||
| "preventDataExfiltration": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a typo here, should it be preventDataExfilteration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't think it is a typo. It should be data exfiltration
added managedVirtualNetworkSettings definition.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.