Skip to content

Remove implementation details of key release policy; instead use opaque blob #10916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Laurent Mazuel (lmazuel) merged 5 commits into from
Oct 27, 2020
Merged

Remove implementation details of key release policy; instead use opaque blob #10916

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6d2a39a
Remove implementation details of key release policy; instead use opaq…
Sep 23, 2020
7f43fba
syntax fix
Sep 23, 2020
8870e7d
Include a content-type
Sep 25, 2020
3461b43
add charset
Sep 25, 2020
600fd24
fix export key example
Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 14 additions & 77 deletions specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.2-preview/keys.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,83 +1033,6 @@
}
},
"definitions": {
"KeyReleaseCondition": {
"properties": {
"claim": {
"x-ms-client-name": "claimType",
"type": "string",
"minLength": 1,
"description": "claim type name"
},
"condition": {
"x-ms-client-name": "claimCondition",
"type": "string",
"minLength": 1,
"description": "condition to test",
"enum": [
"equals"
],
"x-ms-enum": {
"name": "KeyReleaseConditionCondition",
"modelAsString": true,
"values": [
{
"value": "equals",
"description": "equals comparison."
}
]
}
},
"value": {
"type": "string"
}
}
},
"KeyReleaseAuthority": {
"properties": {
"authority": {
"x-ms-client-name": "authorityURL",
"type": "string",
"minLength": 1,
"description": "Base URL of the attestation service."
},
"allOf": {
"type": "array",
"items": {
"$ref": "#/definitions/KeyReleaseCondition",
"description": "The set of claim conditions that must be met."
}
}
}
},
"KeyReleasePolicy": {
"properties": {
"version": {
"description": "key release policy version",
"type": "string",
"enum": [
"0.2"
],
"x-ms-enum": {
"name": "KeyReleasePolicyVersion",
"modelAsString": true,
"values": [
{
"value": "0.2",
"description": "Schema version 0.2"
}
]
}
},
"anyOf": {
"type": "array",
"items": {
"$ref": "#/definitions/KeyReleaseAuthority",
"description": "Authorities."
}
}
}
},
"JsonWebKey": {
"properties": {
"kid": {
Expand Down Expand Up @@ -1387,6 +1310,20 @@
},
"description": "The key item containing key metadata."
},
"KeyReleasePolicy": {
"properties": {
"contentType": {
"description": "Content type and version of key release policy",
"type": "string",
"default": "application/json; version=1.0"

@heaths Heath Stewart (heaths) Sep 25, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you already treat it as UTF8 anyway, it would help inform people if you made this, perhaps:

Suggested change
"default": "application/json; version=1.0"
"default": "application/json; charset=utf-8; version=1.0"

},
"data": {
"description": "Blob encoding the policy rules under which the key can be exported.",
"type": "string",
"format": "base64url"
}
}
},
"DeletedKeyBundle": {
"allOf": [
{
Expand Down