Consistency of privateIPAllocationMethod property in arm-network #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lmazuel, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
Member
|
Awesome! Thank you for the contribution. LGTM |
devigned
added a commit
that referenced
this pull request
Jan 8, 2016
Consistency of privateIPAllocationMethod property in arm-network
blueww
pushed a commit
to blueww/azure-rest-api-specs
that referenced
this pull request
Dec 8, 2017
…StorageSync (Azure#109) * Adding swagger spec for Storage sync ResourceProvider : Microsoft.StorageSync * Fixing Schema validation error message: 'Additional properties not allowed: requestUri', * Fixing the ReadMe * Remove ApiVersionParameter * formatting formatting * formatting * formatting * formatting formatting * formatting * formatting * Formatting * formatting * revert * Comments * Change case * change case * change case * Fix RESPONSE_STATUS_CODE_NOT_IN_SPEC * Remove moveresources * Fix REQUEST_VALIDATION_ERROR * Fix RESPONSE_VALIDATION_ERROR * Handle Negative results * Add x-ms-long-running-operation * Fix InternalResource/ArmResource definition * revert x-ms-long-running-operation * Patch cannot have mandatory property request body * change status to readonly. * fix syntax check * remove Replicagroup * ARM Feedback incorporation * Change names * Remove tags Remove tags * Review comments Review comments * Comments incorporation Comments incorporation * Add pageable Add pageable * Remove Additional properties Remove Additional properties * Fixing validation example error Fixing validation example error
marstr
pushed a commit
that referenced
this pull request
May 2, 2018
…StorageSync (#109) * Adding swagger spec for Storage sync ResourceProvider : Microsoft.StorageSync * Fixing Schema validation error message: 'Additional properties not allowed: requestUri', * Fixing the ReadMe * Remove ApiVersionParameter * formatting formatting * formatting * formatting * formatting formatting * formatting * formatting * Formatting * formatting * revert * Comments * Change case * change case * change case * Fix RESPONSE_STATUS_CODE_NOT_IN_SPEC * Remove moveresources * Fix REQUEST_VALIDATION_ERROR * Fix RESPONSE_VALIDATION_ERROR * Handle Negative results * Add x-ms-long-running-operation * Fix InternalResource/ArmResource definition * revert x-ms-long-running-operation * Patch cannot have mandatory property request body * change status to readonly. * fix syntax check * remove Replicagroup * ARM Feedback incorporation * Change names * Remove tags Remove tags * Review comments Review comments * Comments incorporation Comments incorporation * Add pageable Add pageable * Remove Additional properties Remove Additional properties * Fixing validation example error Fixing validation example error
annatisch
pushed a commit
that referenced
this pull request
Jun 13, 2018
* Storage Sync Swagger preview version (prev PR #109 * Added Python code gen config * Added NodeJS + Java code gen config * Review comments Review comments * StorageSyncError change StorageSyncError change * extra comma extra comma in pauseWaitForSyncDrainTimePeriodInSeconds * body to parameters body to parameters * Update RegisteredServers_Create example * Updated ServerEndpoints_Create example * Updated CloudEndpoints_PostRestore example * Updated CloudEndpoints_PreRestore example * Updated CloudEndpoints_PostBackup example * Updated StorageSyncServices_Create example * Updated SyncGroups_Create example * Updated CloudEndpoints_Create example * Updated CloudEndpoints_PreBackup example * Updated ServerEndpoints_Update example * Updated StorageSyncServices_Update example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm at the Python SDK team and we working on testing the auto-generated version currently. I found while testing that in
arm-networktheprivateIPAllocationMethodproperty is used 5 times:static/dynamicI think this property should be consistent in the file (actually, I think that the Python SDK should be consistent in this property, and this belongs to this file :)).
It's my first PR here, please tell me if I do not respect a process or something else.
Thank you,