Devices new api for IoT Security#10893
Merged
jianyexi merged 10 commits intoAzure:masterfrom Oct 19, 2020
Merged
Conversation
Merge upstream to fork
MichalHel
added
the
DoNotMerge
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@MichalHel Does this ready for review ? If not , do you have a plan for it |
Contributor
Author
|
@jianyexi - Yes, it is ready for review |
Merge upstream to fork
# Conflicts: # specification/security/resource-manager/readme.md
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-resource-manager-schemas - Release
|
Contributor
Author
|
Why was the "CI-BreakingChange-Python" tag added? |
majastrz
reviewed
Sep 30, 2020
| } | ||
| } | ||
| }, | ||
| "/{resourceId}/providers/Microsoft.Security/devices": { |
Member
There was a problem hiding this comment.
resourceId [](start = 7, length = 10)
ARM will route devices calls for any resource type. Make sure you validate {resourceId} to only allow the request for resource types that you support.
majastrz
approved these changes
Sep 30, 2020
Member
majastrz
left a comment
majastrz
left a comment
There was a problem hiding this comment.
Looks good to me. Signed off from ARM side.
majastrz
added
the
ARMSignedOff
Contributor
|
Could you fix the Go SDK failure ？ |
jianyexi
approved these changes
Oct 11, 2020
…vices. 2. Added new properties to the security device resource
|
No pipelines are associated with this pull request. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
2. added filter of Managed type to security devices
|
Azure Pipelines successfully started running 1 pipeline(s). |
MichalHel
removed
the
DoNotMerge
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@MichalHel Does the PR ready to merge now ? |
Contributor
Author
|
@jianyexi Yes it is ready to merge |
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
* Added new API for devices in IoT Security * Fixed validation errors * updated security readme * changed operation id in devices api * 1. Added parameter to the query section in the URI of the security devices. 2. Added new properties to the security device resource * 1. added new properties to security devices. 2. added filter of Managed type to security devices * changed naming of parameter in security devices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
[V ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.