Skip to content

added 2020-01-13-preview#10817

Closed
juliaweingart wants to merge 12 commits intoAzure:masterfrom
juliaweingart:workloadMonitor-addApiVersion
Closed

added 2020-01-13-preview#10817
juliaweingart wants to merge 12 commits intoAzure:masterfrom
juliaweingart:workloadMonitor-addApiVersion

Conversation

@juliaweingart
Copy link
Contributor

@juliaweingart juliaweingart commented Sep 16, 2020 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 16, 2020 •
edited
Loading

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail] 
 There are no breaking changes.
️️✔️LintDiff [Detail] 
 Validation passes for LintDiff.
️️✔️Avocado [Detail] 
 Validation passes for Avocado.
️️✔️ModelValidation [Detail] 
 Validation passes for ModelValidation.
️️✔️SemanticValidation [Detail] 
 Validation passes for SemanticValidation.
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 16, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 16, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 16, 2020 •
edited
Loading

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 16, 2020 •
edited
Loading

azure-sdk-for-python

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 6eaae57 with merge commit 9fe29afb7687d8ceb6df85134bc2dfc0c103ae7a. SDK Automation 13.0.17.20200918.2 
    [azure-mgmt-workloadmonitor][ChangeLog] WARNING: Failed to generate ChangeLog.
  • ⚠️azure-mgmt-workloadmonitor [View full logs]  [Preview SDK Changes] 
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-workloadmonitor
[build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-workloadmonitor
[build_conf] INFO:packaging_tools:Template done azure-mgmt-workloadmonitor
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /z/venv/lib/python3.6/site-packages/setuptools/dist.py:406: UserWarning: The version specified ('2020-01-13-preview') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.
[build_package]   "details." % self.metadata.version
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /z/venv/lib/python3.6/site-packages/setuptools/dist.py:406: UserWarning: The version specified ('2020-01-13-preview') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.
[build_package]   "details." % self.metadata.version
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
Not exact 2 reports found:
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 16, 2020 •
edited
Loading

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 6eaae57 with merge commit 9fe29afb7687d8ceb6df85134bc2dfc0c103ae7a. SDK Automation 13.0.17.20200918.2 
    [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.WorkloadMonitor [View full logs]  [Preview SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 16, 2020 •
    edited
    Loading

    azure-sdk-for-java

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 6eaae57 with merge commit 9fe29afb7687d8ceb6df85134bc2dfc0c103ae7a. SDK Automation 13.0.17.20200918.2
    • ⚠️sdk/workloadmonitor/mgmt-v2018_08_31_preview [View full logs]  [Preview SDK Changes] 
        [mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/workloadmonitor/mgmt-v2018_08_31_preview/src/main/java/com/microsoft/azure/management/workloadmonitor/v2018_08_31_preview/implementation/MonitorsInner.java:[544,194] cannot find symbol
[mvn]   symbol:   variable body
[mvn]   location: class com.microsoft.azure.management.workloadmonitor.v2018_08_31_preview.implementation.MonitorsInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/workloadmonitor/mgmt-v2018_08_31_preview/src/main/java/com/microsoft/azure/management/workloadmonitor/v2018_08_31_preview/implementation/NotificationSettingsInner.java:[526,208] cannot find symbol
[mvn]   symbol:   variable body
[mvn]   location: class com.microsoft.azure.management.workloadmonitor.v2018_08_31_preview.implementation.NotificationSettingsInner
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-workloadmonitor: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/workloadmonitor/mgmt-v2018_08_31_preview/src/main/java/com/microsoft/azure/management/workloadmonitor/v2018_08_31_preview/implementation/MonitorsInner.java:[544,194] cannot find symbol
[mvn] [ERROR]   symbol:   variable body
[mvn] [ERROR]   location: class com.microsoft.azure.management.workloadmonitor.v2018_08_31_preview.implementation.MonitorsInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/workloadmonitor/mgmt-v2018_08_31_preview/src/main/java/com/microsoft/azure/management/workloadmonitor/v2018_08_31_preview/implementation/NotificationSettingsInner.java:[526,208] cannot find symbol
[mvn] [ERROR]   symbol:   variable body
[mvn] [ERROR]   location: class com.microsoft.azure.management.workloadmonitor.v2018_08_31_preview.implementation.NotificationSettingsInner
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
      • ⚠️sdk/workloadmonitor/mgmt-v2020-01-13-preview [View full logs]  [Preview SDK Changes] 
          [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-mgmt-workloadmonitor: MavenReportException: Error while creating archive: 
[mvn] [ERROR] Exit code: 1 - javadoc: error - Illegal package name: "com.microsoft.azure.management.workloadmonitor.v2020-01-13-preview"
[mvn] [ERROR] 
[mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
[mvn] [ERROR] 
[mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/workloadmonitor/mgmt-v2020-01-13-preview/target/apidocs' dir.
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Sep 16, 2020 •
        edited
        Loading

        azure-sdk-for-js

        No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Sep 16, 2020 •
        edited
        Loading

        azure-resource-manager-schemas

        ⚠️ warning [Logs] [Expand Details]
        • ⚠️ Generate from 6eaae57 with merge commit 9fe29afb7687d8ceb6df85134bc2dfc0c103ae7a. Schema Automation 13.0.17.20200918.2 
          Failed to find any diff after autorest so no changed packages was found.

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Sep 16, 2020 •
        edited
        Loading

        azure-sdk-for-python-track2

        No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Sep 16, 2020 •
        edited
        Loading

        azure-sdk-for-go

        ⚠️ warning [Logs] [Expand Details]

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Sep 16, 2020 •
        edited
        Loading

        Trenton Generation

        No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

        This was referenced Sep 16, 2020
        Open
        Open
        Open
        @azure-pipelines
        Copy link

        azure-pipelines bot commented Sep 17, 2020

        Azure Pipelines successfully started running 1 pipeline(s).

        @azure-pipelines
        Copy link

        azure-pipelines bot commented Sep 17, 2020

        Azure Pipelines successfully started running 1 pipeline(s).

        @azure-pipelines
        Copy link

        azure-pipelines bot commented Sep 17, 2020

        Azure Pipelines successfully started running 1 pipeline(s).

        @ArcturusZhang
        Copy link
        Member

        ArcturusZhang commented Sep 17, 2020 •
        edited
        Loading

        Hi @juliaweingart could you please fix the CI errors before we could review this?
        And also the SDK generation fails in every language because the modeler reports some errors for this swagger, you may also need to resolve this.

        Thanks

        @azure-pipelines
        Copy link

        azure-pipelines bot commented Sep 17, 2020

        Azure Pipelines successfully started running 1 pipeline(s).

        @azure-pipelines
        Copy link

        azure-pipelines bot commented Sep 17, 2020

        Azure Pipelines successfully started running 1 pipeline(s).

        @azure-pipelines
        Copy link

        azure-pipelines bot commented Sep 17, 2020

        Azure Pipelines successfully started running 1 pipeline(s).

        @ArcturusZhang
        Copy link
        Member

        ArcturusZhang commented Sep 18, 2020

        Also @juliaweingart could you please also modify your commit history by making one previous api-version the first commit?
        ARM review usually needs to compare the new api-version with the old api-version, and it helps a lot if you just copy the old api-version to this directory and we could just compare these api-versions by selecting a range of commit.

        And this may also help identify the modeler error.

        @juliaweingart
        Copy link
        Contributor Author

        juliaweingart commented Sep 23, 2020 via email

        @ArcturusZhang
        Copy link
        Member

        ArcturusZhang commented Sep 24, 2020

        Hi @juliaweingart since we need to compare this new api-version with the old api-version, and github does not provide a functionality that you could compare between directories, therefore we have to comparing these different api-versions via commits. By making the copy of the old api-version the first commit in this PR, we could easily get the differences between these two api-versions by selecting all other commits except the first commit, so that we do not have to review the whole api-version as a new.

        ArcturusZhang
        ArcturusZhang requested changes Sep 24, 2020
        View reviewed changes
        Copy link
        Member

        @ArcturusZhang ArcturusZhang left a comment

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        About the autorest errors, I do not know why this happens, but I left some comments on the multiapi parts in the readme, maybe resolving this could solve this issue. Please have a look, thanks

        specification/workloadmonitor/resource-manager/readme.md
        ``` yaml $(go) && $(multiapi)
        batch:
        - tag: package-2018-08-31-preview
        - tag: package-2020-01-13-preview
        Copy link
        Member

        @ArcturusZhang ArcturusZhang Sep 24, 2020

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        Please add the new tag to this list and do not remove the old tag.

        Suggested change
        - tag: package-2020-01-13-preview
        - tag: package-2018-08-31-preview
        - tag: package-2020-01-13-preview

        specification/workloadmonitor/resource-manager/readme.md
        ``` yaml $(java) && $(multiapi)
        batch:
        - tag: package-2018-08-31-preview
        - tag: package-2020-01-13-preview
        Copy link
        Member

        @ArcturusZhang ArcturusZhang Sep 24, 2020

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        Please add the new tag to this list and do not remove the old tag.

        Suggested change
        - tag: package-2020-01-13-preview
        - tag: package-2018-08-31-preview
        - tag: package-2020-01-13-preview

        @azure-pipelines
        Copy link

        azure-pipelines bot commented Sep 24, 2020

        Pull request contains merge conflicts.

        @azure-pipelines
        Copy link

        azure-pipelines bot commented Sep 24, 2020

        Azure Pipelines successfully started running 1 pipeline(s).

        @juliaweingart
        Copy link
        Contributor Author

        juliaweingart commented Sep 24, 2020 via email

        @pilor pilor self-requested a review September 24, 2020 20:49
        @pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 24, 2020
        @juliaweingart
        Copy link
        Contributor Author

        juliaweingart commented Sep 24, 2020 via email

        @ArcturusZhang
        Copy link
        Member

        ArcturusZhang commented Sep 25, 2020

        Hi @juliaweingart if this new api-version is totally different with any previous api-versions, we do not need to alter the commit history to achieve a comparison with the old api-version then.

        I am also confused on the SDK failures. Let me ask for someone from modeler to help.

        @azure-pipelines
        Copy link

        azure-pipelines bot commented Sep 30, 2020

        Azure Pipelines successfully started running 1 pipeline(s).

        @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Sep 30, 2020
        Open
        @markcowl markcowl requested review from ArcturusZhang and removed request for ArcturusZhang October 5, 2020 21:26
        @markcowl markcowl self-requested a review October 5, 2020 21:28
        @chiragg4u chiragg4u mentioned this pull request Oct 5, 2020
        Merged
        10 tasks
        @markcowl
        Copy link
        Member

        markcowl commented Oct 6, 2020

        Closing in favor of #11039

        @markcowl markcowl closed this Oct 6, 2020
        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

        Reviewers

        @ArcturusZhang ArcturusZhang ArcturusZhang requested changes

        @markcowl markcowl Awaiting requested review from markcowl

        +1 more reviewer

        @pilor pilor pilor approved these changes

        Reviewers whose approvals may not affect merge requirements

        Assignees

        @ArcturusZhang ArcturusZhang

        Labels

        ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

        Projects

        None yet

        Milestone

        No milestone

        Development

        Successfully merging this pull request may close these issues.

        4 participants

        @juliaweingart @ArcturusZhang @markcowl @pilor