[NetAppFiles]Corrected case in operation ids#10811
Merged
weidongxu-microsoft merged 1 commit intoAzure:masterfrom Sep 17, 2020
Merged
[NetAppFiles]Corrected case in operation ids#10811weidongxu-microsoft merged 1 commit intoAzure:masterfrom
weidongxu-microsoft merged 1 commit intoAzure:masterfrom
Conversation
[Staging] Swagger Validation Report
❌ |
| Rule | Message |
|---|---|
1008 - ModifiedOperationId |
The operation id has been changed from 'snapshotPolicies_Get' to 'SnapshotPolicies_Get'. This will impact generated code. New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L1682:7 Old: Microsoft.NetApp/stable/2020-06-01/netapp.json#L1682:7 |
1008 - ModifiedOperationId |
The operation id has been changed from 'snapshotPolicies_Create' to 'SnapshotPolicies_Create'. This will impact generated code. New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L1705:7 Old: Microsoft.NetApp/stable/2020-06-01/netapp.json#L1705:7 |
1008 - ModifiedOperationId |
The operation id has been changed from 'snapshotPolicies_Update' to 'SnapshotPolicies_Update'. This will impact generated code. New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L1746:7 Old: Microsoft.NetApp/stable/2020-06-01/netapp.json#L1746:7 |
1008 - ModifiedOperationId |
The operation id has been changed from 'snapshotPolicies_Delete' to 'SnapshotPolicies_Delete'. This will impact generated code. New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L1780:7 Old: Microsoft.NetApp/stable/2020-06-01/netapp.json#L1780:7 |
1008 - ModifiedOperationId |
The operation id has been changed from 'backupPolicies_Get' to 'BackupPolicies_Get'. This will impact generated code. New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L2293:7 Old: Microsoft.NetApp/stable/2020-06-01/netapp.json#L2293:7 |
1008 - ModifiedOperationId |
The operation id has been changed from 'backupPolicies_Create' to 'BackupPolicies_Create'. This will impact generated code. New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L2334:7 Old: Microsoft.NetApp/stable/2020-06-01/netapp.json#L2334:7 |
1008 - ModifiedOperationId |
The operation id has been changed from 'backupPolicies_Update' to 'BackupPolicies_Update'. This will impact generated code. New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L2394:7 Old: Microsoft.NetApp/stable/2020-06-01/netapp.json#L2394:7 |
1008 - ModifiedOperationId |
The operation id has been changed from 'backupPolicies_Delete' to 'BackupPolicies_Delete'. This will impact generated code. New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L2444:7 Old: Microsoft.NetApp/stable/2020-06-01/netapp.json#L2444:7 |
️️✔️LintDiff [Detail]
️✔️Validation passes for LintDiff.
️️✔️Avocado [Detail]
️✔️Validation passes for Avocado.
️️✔️ModelValidation [Detail]
️✔️Validation passes for ModelValidation.
️️✔️SemanticValidation [Detail]
️✔️Validation passes for SemanticValidation.
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-js - Release
|
azure-resource-manager-schemas - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
|
This was referenced Sep 16, 2020
weidongxu-microsoft
approved these changes
Sep 17, 2020
Member
weidongxu-microsoft
left a comment
There was a problem hiding this comment.
The change is unlikely to affect SDK code, since most codegen will handle the casing.
Member
|
@changlong-liu @ArcturusZhang e.g. |
Member
Hi @weidongxu-microsoft , no for Python in this case |
Member
Author
|
.net generated code is not affected I think code generators handle this. |
nitegupt
pushed a commit
to nitegupt/azure-rest-api-specs
that referenced
this pull request
Sep 25, 2020
Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
When publishing API documentation for NetAppFiles API version 2020-06-01 we find issues with snapshotPolicies and backupPolicies
for example: BackupPolicies 2nd
This PR attempts to correct that issue
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.