Skip to content

SharedAccessAuthorizationRule definition renamed and path property removed.#1077

Merged
anudeepsharma merged 1 commit into
Azure:masterfrom
v-Ajnava:Relay_propertiesUpdated
Mar 30, 2017
Merged

SharedAccessAuthorizationRule definition renamed and path property removed.#1077
anudeepsharma merged 1 commit into
Azure:masterfrom
v-Ajnava:Relay_propertiesUpdated

Conversation

@v-Ajnava
Copy link
Copy Markdown
Contributor

@v-Ajnava v-Ajnava commented Mar 28, 2017

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@msftclas
Copy link
Copy Markdown

@v-Ajnava,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@v-Ajnava
Copy link
Copy Markdown
Contributor Author

These are not breaking changes as SDK is not shipped yet.

@anudeepsharma
Copy link
Copy Markdown
Contributor

Thanks for the letting know that SDK is not published and these are not breaking changes. Please have a look at https://travis-ci.org/Azure/azure-rest-api-specs/jobs/216146805 and fix the build.

Copy link
Copy Markdown
Contributor

@anudeepsharma anudeepsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-Ajnava
Copy link
Copy Markdown
Contributor Author

@anudeepsharma, one query, the builed error for TrackedResource, those are not tracked resources. can we ignore them? in last PR we have ignored them.

@anudeepsharma anudeepsharma merged commit ab55849 into Azure:master Mar 30, 2017
@AutorestCI
Copy link
Copy Markdown

No modification for Ruby

@AutorestCI
Copy link
Copy Markdown

No modification for NodeJS

@AutorestCI
Copy link
Copy Markdown

No modification for Python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants