Bump up version number for "old" preview api by jorgbaca · Pull Request #10768 · Azure/azure-rest-api-specs

jorgbaca · 2020-09-11T21:05:21Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

Fixed systemData.

Fixed identitytype case.

…nt PR to rename properties.

Removed optional properties from dataControllers. Marked some properties required for dataControllers.

well

openapi-pipeline-app · 2020-09-11T21:05:25Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️❌LintDiff: 1 Errors, 10 Warnings [Detail] [Expand]

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` R3023 - OperationsAPIImplementation	Operations API must be implemented for '/providers/Microsoft.AzureData/operations'. New: Microsoft.AzureData/preview/2020-09-08-preview/azuredata.json#L18
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience New: Microsoft.AzureData/preview/2020-09-08-preview/azuredata.json#L1536
⚠️ R4009 - RequiredSystemDataInNewApiVersions	The response of operation:'DataControllers_ListInSubscription' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.AzureData/preview/2020-09-08-preview/azuredata.json#L884
⚠️ R4009 - RequiredSystemDataInNewApiVersions	The response of operation:'SqlManagedInstances_List' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.AzureData/preview/2020-09-08-preview/azuredata.json#L20
⚠️ R4009 - RequiredSystemDataInNewApiVersions	The response of operation:'SqlManagedInstances_ListByResourceGroup' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.AzureData/preview/2020-09-08-preview/azuredata.json#L59
⚠️ R4009 - RequiredSystemDataInNewApiVersions	The response of operation:'DataControllers_ListInGroup' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.AzureData/preview/2020-09-08-preview/azuredata.json#L923
⚠️ R4009 - RequiredSystemDataInNewApiVersions	The response of operation:'SqlServerInstances_ListByResourceGroup' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.AzureData/preview/2020-09-08-preview/azuredata.json#L347
⚠️ R4009 - RequiredSystemDataInNewApiVersions	The response of operation:'PostgresInstances_List' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.AzureData/preview/2020-09-08-preview/azuredata.json#L596
⚠️ R4009 - RequiredSystemDataInNewApiVersions	The response of operation:'PostgresInstances_ListByResourceGroup' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.AzureData/preview/2020-09-08-preview/azuredata.json#L635
⚠️ R4009 - RequiredSystemDataInNewApiVersions	The response of operation:'SqlServerInstances_List' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.AzureData/preview/2020-09-08-preview/azuredata.json#L308

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-09-11T21:05:37Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-09-11T21:07:43Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-11T21:08:35Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from ab5c036 with merge commit a79f3b3. SDK Automation 13.0.17.20200909.5

️✔️preview/azuredata/mgmt/2019-07-24-preview [View full logs] [Release SDK Changes]

preview.azuredata.mgmt.2019-07-24-preview.zip

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 05:08:35 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"07C8:104EC:267FB0B:2DFB3AF:5F619DD3","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-09-11T21:08:42Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from ab5c036 with merge commit a79f3b3. SDK Automation 13.0.17.20200909.5
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-09-11T21:08:42Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from ab5c036 with merge commit a79f3b3. SDK Automation 13.0.17.20200909.5
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-09-11T21:08:45Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from ab5c036 with merge commit a79f3b3. SDK Automation 13.0.17.20200909.5

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.AzureData [View full logs] [Release SDK Changes]

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 05:08:34 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0481:454E:9A9836:BCF88B:5F619DD2","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-09-11T21:08:55Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from ab5c036 with merge commit a79f3b3. SDK Automation 13.0.17.20200909.5

Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/_azure_data_management_client.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/models/_azure_data_management_client_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_data_controllers_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_postgres_instances_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_sql_managed_instances_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_sql_server_instances_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_sql_server_registrations_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_sql_servers_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/version.py

openapi-sdkautomation · 2020-09-11T21:09:19Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-11T21:09:25Z

azure-resource-manager-schemas - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from ab5c036 with merge commit a79f3b3. Schema Automation 13.0.17.20200909.5
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-09-11T21:09:31Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-09-11T21:13:26Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-11T21:30:32Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-11T21:49:13Z

Azure Pipelines successfully started running 1 pipeline(s).

jorgbaca · 2020-09-11T22:29:51Z

Hi @erich-wang can you help us review this PR?

There is a validation failing regarding support for the "operations api". It's our understanding that we don't have to support that for preview, only for GA (which we plan on doing).

Thank you for your help.

erich-wang · 2020-09-15T07:35:42Z

@jorgbaca , as mentioned in the description:
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

jorgbaca · 2020-09-15T16:41:07Z

Thank you for your help @erich-wang . I'll reach out to the on call.

jorgbaca · 2020-09-15T18:21:13Z

@erich-wang Contacted ARM and they already signed off. Let me know if you need anything from me to complete this PR. Thanks you.

* WIP: Updating Microsoft.AzureData * Minor changes * Adding new SystemData property to examples * Fixed formatting * Update azuredata.json Fixed systemData. * Update azuredata.json Fixed identitytype case. * Fixed formatting * Removing changes from this PR (suggested by ARM). Will send a different PR to rename properties. * Added optional properties to sqlManagedInstances. Removed optional properties from dataControllers. Marked some properties required for dataControllers. * Ran prettier check * Adding missing parameter * Added new definition for data controller patch model * Fixed parameter * Copying 2019 api to 2020 * Removing EOS examples (and list operation which is not supported) * Remvoing EOS stuff from azuredata.json. Removing operation resource as well * Update postgres details * Update postgres example * Updating api-version in examples * Adding last uploaded date and k8sRaw * Update descriptions * Fix paramters * Add missing bracket * Update readme

jorgbaca and others added 25 commits July 20, 2020 09:57

WIP: Updating Microsoft.AzureData

11ce62d

Merge remote-tracking branch 'azure-remote/master'

4c74ee7

Minor changes

e44ca90

Adding new SystemData property to examples

e55b9bd

Fixed formatting

a5ee8a3

Update azuredata.json

7337b93

Fixed systemData.

Update azuredata.json

78e2146

Fixed identitytype case.

Fixed formatting

7f7d4bf

Merge remote-tracking branch 'azure-remote/master'

b35a214

Removing changes from this PR (suggested by ARM). Will send a differe…

d0468ae

…nt PR to rename properties.

Merge remote-tracking branch 'upstream/master'

8d0c323

Added optional properties to sqlManagedInstances.

c03d76a

Removed optional properties from dataControllers. Marked some properties required for dataControllers.

Ran prettier check

049699e

Adding missing parameter

199e6a3

Added new definition for data controller patch model

fc355db

Fixed parameter

f53c424

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

a08e33f

Copying 2019 api to 2020

98fe8f5

Removing EOS examples (and list operation which is not supported)

f17a34d

Remvoing EOS stuff from azuredata.json. Removing operation resource as

a58b739

well

Update postgres details

a07f2d1

Update postgres example

61909cb

Updating api-version in examples

0babe01

Adding last uploaded date and k8sRaw

301995d

Update descriptions

d81f060

openapi-assignment-bot bot assigned erich-wang Sep 11, 2020

openapi-sdkautomation bot mentioned this pull request Sep 11, 2020

[AutoPR Microsoft.Azure.Management.AzureData] Bump up version number for "old" preview api AzureSDKAutomation/azure-sdk-for-net#1694

Closed

Fix paramters

29bdbb7

Add missing bracket

a9d2f1e

Update readme

ab5c036

jorgbaca marked this pull request as ready for review September 11, 2020 22:27

erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 13, 2020

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 15, 2020

erich-wang approved these changes Sep 16, 2020

View reviewed changes

erich-wang merged commit a79f3b3 into Azure:master Sep 16, 2020

Conversation

jorgbaca commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-pipeline-app bot commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Staging] Swagger Validation Report

Uh oh!

azure-pipelines bot commented Sep 11, 2020

Uh oh!

openapi-sdkautomation bot commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Azure CLI Extension Generation - Release

Uh oh!

openapi-sdkautomation bot commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python-track2 - Release

Uh oh!

openapi-sdkautomation bot commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-resource-manager-schemas - Release

Uh oh!

openapi-sdkautomation bot commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Trenton Generation - Release

Uh oh!

azure-pipelines bot commented Sep 11, 2020

Uh oh!

azure-pipelines bot commented Sep 11, 2020

Uh oh!

azure-pipelines bot commented Sep 11, 2020

Uh oh!

jorgbaca commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erich-wang commented Sep 15, 2020

Uh oh!

jorgbaca commented Sep 15, 2020

Uh oh!

jorgbaca commented Sep 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jorgbaca commented Sep 11, 2020 •

edited

Loading

openapi-pipeline-app bot commented Sep 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 11, 2020 •

edited

Loading

jorgbaca commented Sep 11, 2020 •

edited

Loading