Adding request body for listcredential for Microsoft.Kubernetes#10766
Adding request body for listcredential for Microsoft.Kubernetes#10766qianwens merged 4 commits intoAzure:masterfrom akashkeshari:akash/ms.k8s_listcredential_update
Conversation
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-resource-manager-schemas - Release
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
| "description": "The mode of client authentication.", | ||
| "enum": [ | ||
| "Token", | ||
| "Certificate" |
There was a problem hiding this comment.
Certificate [](start = 13, length = 11)
ClientCertificate #Closed
There was a problem hiding this comment.
updated #Closed
| "api-version": "2020-01-01-preview" | ||
| "api-version": "2020-01-01-preview", | ||
| "ClientAuthenticationDetails": { | ||
| "authenticationMethod": "Certificate", |
There was a problem hiding this comment.
Certificate [](start = 31, length = 11)
Can you add another example here and leave the default example with no body? No bodyworks for AAD scenario. For non AAD case user needs to pass in credential
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please go through the contribution checklist added as part of the review and mark them completed. This is a requirement before review can be continued. |
Will require you approval on the PR in order to request the SDK release. https://portal.azure-devex-tools.com/tools/request-api-release Please approve |
…e#10766) * added request body for list credential api * Added another example for non aad scenario for list credential api * removed required properties in authentication object * made properties back reqd since body is optional Co-authored-by: Akash Keshari <akkeshar@microsoft.com>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.