Update provisioningStatus field name for assignment#10754
Merged
ChenTanyi merged 29 commits intoAzure:masterfrom Sep 16, 2020
abhinav-ghai:master
Merged
Update provisioningStatus field name for assignment#10754ChenTanyi merged 29 commits intoAzure:masterfrom abhinav-ghai:master
ChenTanyi merged 29 commits intoAzure:masterfrom
abhinav-ghai:master
Conversation
Merge from master
Merge from upstream Azure
Merge from upstream
|
Swagger pipeline can not start as the pull request has merge conflicts. |
|
Pull request contains merge conflicts. |
|
Swagger pipeline can not start as the pull request has merge conflicts. |
[Staging] Swagger Validation Report
❌ |
| Rule | Message |
|---|---|
1033 - RemovedProperty |
The new version is missing a property found in the old version. Was 'provisioningStatus' renamed or removed? New: Microsoft.Automanage/preview/2020-06-30-preview/automanage.json#L1084:7 Old: Microsoft.Automanage/preview/2020-06-30-preview/automanage.json#L1084:7 |
1033 - RemovedProperty |
The new version is missing a property found in the old version. Was 'provisioningStatus' renamed or removed? New: Microsoft.Automanage/preview/2020-06-30-preview/automanage.json#L1084:7 Old: Microsoft.Automanage/preview/2020-06-30-preview/automanage.json#L1084:7 |
️️✔️LintDiff [Detail]
️✔️Validation passes for LintDiff.
️️✔️Avocado [Detail]
️✔️Validation passes for Avocado.
️️✔️ModelValidation [Detail]
️✔️Validation passes for ModelValidation.
️️✔️SemanticValidation [Detail]
️✔️Validation passes for SemanticValidation.
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-python-track2 - Release
|
azure-resource-manager-schemas - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Sep 10, 2020
Member
Author
|
Breaking change is intended. This is not yet released to any customer. |
ChenTanyi
approved these changes
Sep 11, 2020
Contributor
|
@abhinav-ghai Could you ask a code owner or someone in your team to review it? |
stowen-msft
reviewed
Sep 11, 2020
...manage/preview/2020-06-30-preview/examples/createOrUpdateConfigurationProfileAssignment.json
Show resolved
Hide resolved
stowen-msft
approved these changes
Sep 11, 2020
Member
Author
Done, reviewed by Stephen Owen from Automanage team |
Contributor
|
@abhinav-ghai please fix the merge conflict. |
|
Pull request contains merge conflicts. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nitegupt
pushed a commit
to nitegupt/azure-rest-api-specs
that referenced
this pull request
Sep 25, 2020
* Add list and get software to GuestConfiguration * Use newer API version for software * Revert software Swagger spec since these are private preview only * Add Automanage resource provider * Address validation tool errors * spelling add antimalware * Address lint errors * Fix error response * Fix newline * Fix Operations API Lint * Fix operations example * Fix prettier and lint * Address lint and prettier errors * Use common definitions and correct pref enum * Fix parameter * Address comments * Fix update examples * Prettier fix * Fix python md * Change provisioningStatus field name * Fix config profile name in examples * resolve conflict * Address conflict Co-authored-by: Abhinav Ghai <abghai@microsoft.com> Co-authored-by: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.