Reverting recovery services specs to fix docs builds#1074
Merged
Conversation
salameer
reviewed
Mar 27, 2017
Member
salameer
left a comment
salameer
left a comment
There was a problem hiding this comment.
Approved on reverting the change
vishrutshah
approved these changes
Mar 27, 2017
vishrutshah
approved these changes
Mar 27, 2017
Contributor
vishrutshah
left a comment
vishrutshah
left a comment
There was a problem hiding this comment.
LGTM. Just minor & non-blocker you should have used git revert so that you don't need to supply message.
|
No modification for Python |
|
No modification for NodeJS |
dsgouda
added a commit
to dsgouda/azure-rest-api-specs
that referenced
this pull request
Mar 30, 2017
)" This reverts commit ddaf1b1.
sarangan12
pushed a commit
that referenced
this pull request
Mar 30, 2017
|
No modification for NodeJS |
|
No modification for Python |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger
Cross references in recovery services specs is causing build failures for docs team since they don't support it yet. Reverting changes introduced here
These changes will be re-introduced once the docs teams add support for cross referencing in swagger specs