updated apispec by tamilmani1989 · Pull Request #10719 · Azure/azure-rest-api-specs

tamilmani1989 · 2020-09-07T18:46:43Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-09-07T18:46:47Z

[Staging] Swagger Validation Report

️❌BreakingChange: 8 Errors, 0 Warnings [Detail] [Expand]

Rule	Message
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'kubernetesProperties' renamed or removed? New: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json#L766:7 Old: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json#L818:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'type' renamed or removed? New: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json#L804:7 Old: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json#L851:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'kubernetesProperties' renamed or removed? New: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json#L766:7 Old: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json#L818:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'resourceGuid' renamed or removed? New: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json#L804:7 Old: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json#L851:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'dncAppID' renamed or removed? New: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json#L804:7 Old: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json#L851:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'kubernetesProperties' renamed or removed? New: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json#L766:7 Old: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json#L818:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'dncAppId' in response that was not found in the old version. New: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json#L804:7 Old: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json#L851:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'resourceGuid' in response that was not found in the old version. New: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json#L923:7 Old: Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json#L926:7

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-09-07T18:47:00Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-09-07T18:48:20Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 7ce45f1 with merge commit d199ce1. SDK Automation 13.0.17.20200909.5
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-09-07T18:48:22Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-07T18:48:22Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 7ce45f1 with merge commit d199ce1. SDK Automation 13.0.17.20200909.5

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.DelegatedNetwork [View full logs] [Release SDK Changes]

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 05:31:33 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0400:9308:B018FA1:D34A59D:5F61A334","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-09-07T18:48:22Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-07T18:48:22Z

azure-resource-manager-schemas - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-07T18:48:23Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-07T18:48:24Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 7ce45f1 with merge commit d199ce1. SDK Automation 13.0.17.20200909.5

️✔️preview/delegatednetwork/mgmt/2020-08-08-preview [View full logs] [Release SDK Changes]

preview.delegatednetwork.mgmt.2020-08-08-preview.zip

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 05:33:05 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0402:4173:1CA543:489025:5F61A391","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-09-07T18:48:24Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 7ce45f1 with merge commit d199ce1. SDK Automation 13.0.17.20200909.5
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-09-07T18:48:25Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 7ce45f1 with merge commit d199ce1. SDK Automation 13.0.17.20200909.5

⚠️sdk/DelegatedNetwork/mgmt-2020-08-08-preview [View full logs] [Release SDK Changes]

[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-mgmt-delegatednetwork: MavenReportException: Error while creating archive: 
[mvn] [ERROR] Exit code: 1 - javadoc: error - Illegal package name: "com.microsoft.azure.management.delegatednetwork.2020-08-08-preview"
[mvn] [ERROR] 
[mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
[mvn] [ERROR] 
[mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/DelegatedNetwork/mgmt-2020-08-08-preview/target/apidocs' dir.
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 05:32:12 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0400:174F:2818BD8:44C72BF:5F61A35C","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

azure-pipelines · 2020-09-07T19:05:42Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-07T19:09:22Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-08T23:05:00Z

Azure Pipelines successfully started running 1 pipeline(s).

...-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/examples/patchController.json

lirenhe · 2020-09-11T04:56:57Z

@tamilmani1989, it seems your PR contains breaking changes. could you follow our breaking change policy to get it reviewed and approved?

tamilmani1989 · 2020-09-11T07:09:52Z

@lirenhe No one has been using the RP yet and haven't released any SDK. So is it still required to follow breaking change policy?

lirenhe · 2020-09-14T03:16:26Z

@lirenhe No one has been using the RP yet and haven't released any SDK. So is it still required to follow breaking change policy?

Yes. Please follow the process and contact azbreakchangereview@microsoft.com to get the approval for breaking changes.

azure-pipelines · 2020-09-14T18:02:20Z

Azure Pipelines successfully started running 1 pipeline(s).

tamilmani1989 · 2020-09-14T18:38:54Z

@lirenhe Got approval for breaking change. Can you please approve and merge?

* updated apispec * spell error fix * removed dncappid from response * updated apispec * Added appid and endpoint in response

updated apispec

7dba823

openapi-assignment-bot bot assigned lirenhe Sep 7, 2020

This was referenced Sep 7, 2020

[AutoPR sdk/DelegatedNetwork/mgmt-2020-08-08-preview] updated apispec AzureSDKAutomation/azure-sdk-for-java#3851

Closed

[AutoPR Microsoft.Azure.Management.DelegatedNetwork] updated apispec AzureSDKAutomation/azure-sdk-for-net#1662

Closed

spell error fix

cc1464c

removed dncappid from response

115a16e

updated apispec

4d61d27

msvik reviewed Sep 9, 2020

View reviewed changes

...-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/examples/patchController.json Show resolved Hide resolved

msvik reviewed Sep 9, 2020

View reviewed changes

...-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/examples/patchController.json Show resolved Hide resolved

lirenhe added the Reviewed-FeedbackProvided label Sep 11, 2020

Added appid and endpoint in response

7ce45f1

JeffreyRichter self-assigned this Sep 14, 2020

JeffreyRichter removed their assignment Sep 14, 2020

JeffreyRichter self-requested a review September 14, 2020 18:23

JeffreyRichter approved these changes Sep 14, 2020

View reviewed changes

lirenhe approved these changes Sep 16, 2020

View reviewed changes

lirenhe added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed Reviewed-FeedbackProvided labels Sep 16, 2020

lirenhe merged commit d199ce1 into Azure:master Sep 16, 2020

nitegupt pushed a commit to nitegupt/azure-rest-api-specs that referenced this pull request Sep 25, 2020

updated apispec (Azure#10719)

e6915b1

* updated apispec * spell error fix * removed dncappid from response * updated apispec * Added appid and endpoint in response

Conversation

tamilmani1989 commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-pipeline-app bot commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Staging] Swagger Validation Report

Uh oh!

azure-pipelines bot commented Sep 7, 2020

Uh oh!

openapi-sdkautomation bot commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Azure CLI Extension Generation - Release

Uh oh!

openapi-sdkautomation bot commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python-track2 - Release

Uh oh!

openapi-sdkautomation bot commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-resource-manager-schemas - Release

Uh oh!

openapi-sdkautomation bot commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Trenton Generation - Release

Uh oh!

openapi-sdkautomation bot commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

azure-pipelines bot commented Sep 7, 2020

Uh oh!

azure-pipelines bot commented Sep 7, 2020

Uh oh!

azure-pipelines bot commented Sep 8, 2020

Uh oh!

Uh oh!

Uh oh!

lirenhe commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tamilmani1989 commented Sep 11, 2020

Uh oh!

lirenhe commented Sep 14, 2020

Uh oh!

azure-pipelines bot commented Sep 14, 2020

Uh oh!

tamilmani1989 commented Sep 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tamilmani1989 commented Sep 7, 2020 •

edited

Loading

openapi-pipeline-app bot commented Sep 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 7, 2020 •

edited

Loading

lirenhe commented Sep 11, 2020 •

edited

Loading