Skip to content

Conversation

@v-Ajnava
Copy link
Contributor

@v-Ajnava v-Ajnava commented Sep 3, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 3, 2020

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]

Rule Message
1041 - AddedPropertyInResponse The new version has a new property 'trustedServiceAccessEnabled' in response that was not found in the old version.
New: Microsoft.ServiceBus/preview/2018-01-01-preview/NetworkRuleSet-preview.json#L179:11
Old: Microsoft.ServiceBus/preview/2018-01-01-preview/NetworkRuleSet-preview.json#L179:11
1041 - AddedPropertyInResponse The new version has a new property 'trustedServiceAccessEnabled' in response that was not found in the old version.
New: Microsoft.ServiceBus/preview/2018-01-01-preview/NetworkRuleSet-preview.json#L179:11
Old: Microsoft.ServiceBus/preview/2018-01-01-preview/NetworkRuleSet-preview.json#L179:11
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.

️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/servicebus/resource-manager/readme.md
tag: specification/servicebus/resource-manager/readme.md#tag-package-2018-01-preview
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@v-Ajnava
Copy link
Contributor Author

v-Ajnava commented Sep 3, 2020

PR is fix for : https://portal.microsofticm.com/imp/v3/incidents/details/203561654/home

this is a bug fix

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 3, 2020

azure-sdk-for-python

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 29557e9 with merge commit 63e87c3e11b6ca218298d741df65c56201d98fde. SDK Automation 13.0.17.20200918.2
  • ️✔️azure-mgmt-servicebus [View full logs]  [Preview SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-servicebus
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-servicebus
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 0.540% size of original (original: 62571 chars, delta: 338 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model SBNamespace has a new parameter identity
    [ChangeLog]   - Model NetworkRuleSet has a new parameter trusted_service_access_enabled

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 3, 2020

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 3, 2020

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 29557e9 with merge commit 63e87c3e11b6ca218298d741df65c56201d98fde. SDK Automation 13.0.17.20200918.2
  • ️✔️@azure/arm-servicebus [View full logs]  [Preview SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/serviceBusManagementClient.js → ./dist/arm-servicebus.js...
    [npmPack] created ./dist/arm-servicebus.js in 635ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 240.8kB dist/arm-servicebus.js                                      
    [npmPack] npm notice 90.8kB  dist/arm-servicebus.min.js                                  
    [npmPack] npm notice 14.2kB  esm/operations/disasterRecoveryConfigs.js                   
    [npmPack] npm notice 1.1kB   esm/models/disasterRecoveryConfigsMappers.js                
    [npmPack] npm notice 2.6kB   esm/operations/eventHubs.js                                 
    [npmPack] npm notice 995B    esm/models/eventHubsMappers.js                              
    [npmPack] npm notice 263B    esm/models/index.js                                         
    [npmPack] npm notice 710B    esm/operations/index.js                                     
    [npmPack] npm notice 64.9kB  esm/models/mappers.js                                       
    [npmPack] npm notice 9.4kB   esm/operations/migrationConfigs.js                          
    [npmPack] npm notice 1.0kB   esm/models/migrationConfigsMappers.js                       
    [npmPack] npm notice 34.5kB  esm/operations/namespaces.js                                
    [npmPack] npm notice 1.2kB   esm/models/namespacesMappers.js                             
    [npmPack] npm notice 2.2kB   esm/operations/operations.js                                
    [npmPack] npm notice 417B    esm/models/operationsMappers.js                             
    [npmPack] npm notice 5.8kB   esm/models/parameters.js                                    
    [npmPack] npm notice 2.6kB   esm/operations/premiumMessagingRegionsOperations.js         
    [npmPack] npm notice 1.0kB   esm/models/premiumMessagingRegionsOperationsMappers.js      
    [npmPack] npm notice 7.9kB   esm/operations/privateEndpointConnections.js                
    [npmPack] npm notice 1.0kB   esm/models/privateEndpointConnectionsMappers.js             
    [npmPack] npm notice 1.9kB   esm/operations/privateLinkResources.js                      
    [npmPack] npm notice 430B    esm/models/privateLinkResourcesMappers.js                   
    [npmPack] npm notice 14.8kB  esm/operations/queues.js                                    
    [npmPack] npm notice 1.1kB   esm/models/queuesMappers.js                                 
    [npmPack] npm notice 2.4kB   esm/operations/regions.js                                   
    [npmPack] npm notice 1.0kB   esm/models/regionsMappers.js                                
    [npmPack] npm notice 910B    rollup.config.js                                            
    [npmPack] npm notice 7.0kB   esm/operations/rules.js                                     
    [npmPack] npm notice 987B    esm/models/rulesMappers.js                                  
    [npmPack] npm notice 2.4kB   esm/serviceBusManagementClient.js                           
    [npmPack] npm notice 2.6kB   esm/serviceBusManagementClientContext.js                    
    [npmPack] npm notice 6.7kB   esm/operations/subscriptions.js                             
    [npmPack] npm notice 1.0kB   esm/models/subscriptionsMappers.js                          
    [npmPack] npm notice 14.8kB  esm/operations/topics.js                                    
    [npmPack] npm notice 1.1kB   esm/models/topicsMappers.js                                 
    [npmPack] npm notice 1.7kB   package.json                                                
    [npmPack] npm notice 457B    tsconfig.json                                               
    [npmPack] npm notice 546.7kB dist/arm-servicebus.js.map                                  
    [npmPack] npm notice 70.2kB  dist/arm-servicebus.min.js.map                              
    [npmPack] npm notice 6.3kB   esm/operations/disasterRecoveryConfigs.d.ts.map             
    [npmPack] npm notice 8.1kB   esm/operations/disasterRecoveryConfigs.js.map               
    [npmPack] npm notice 698B    esm/models/disasterRecoveryConfigsMappers.d.ts.map          
    [npmPack] npm notice 711B    esm/models/disasterRecoveryConfigsMappers.js.map            
    [npmPack] npm notice 1.2kB   esm/operations/eventHubs.d.ts.map                           
    [npmPack] npm notice 1.6kB   esm/operations/eventHubs.js.map                             
    [npmPack] npm notice 621B    esm/models/eventHubsMappers.d.ts.map                        
    [npmPack] npm notice 634B    esm/models/eventHubsMappers.js.map                          
    [npmPack] npm notice 30.8kB  esm/models/index.d.ts.map                                   
    [npmPack] npm notice 401B    esm/operations/index.d.ts.map                               
    [npmPack] npm notice 126B    esm/models/index.js.map                                     
    [npmPack] npm notice 415B    esm/operations/index.js.map                                 
    [npmPack] npm notice 3.2kB   esm/models/mappers.d.ts.map                                 
    [npmPack] npm notice 35.6kB  esm/models/mappers.js.map                                   
    [npmPack] npm notice 3.3kB   esm/operations/migrationConfigs.d.ts.map                    
    [npmPack] npm notice 5.0kB   esm/operations/migrationConfigs.js.map                      
    [npmPack] npm notice 635B    esm/models/migrationConfigsMappers.d.ts.map                 
    [npmPack] npm notice 648B    esm/models/migrationConfigsMappers.js.map                   
    [npmPack] npm notice 13.8kB  esm/operations/namespaces.d.ts.map                          
    [npmPack] npm notice 19.4kB  esm/operations/namespaces.js.map                            
    [npmPack] npm notice 724B    esm/models/namespacesMappers.d.ts.map                       
    [npmPack] npm notice 737B    esm/models/namespacesMappers.js.map                         
    [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map                          
    [npmPack] npm notice 1.4kB   esm/operations/operations.js.map                            
    [npmPack] npm notice 241B    esm/models/operationsMappers.d.ts.map                       
    [npmPack] npm notice 254B    esm/models/operationsMappers.js.map                         
    [npmPack] npm notice 1.2kB   esm/models/parameters.d.ts.map                              
    [npmPack] npm notice 4.5kB   esm/models/parameters.js.map                                
    [npmPack] npm notice 1.1kB   esm/operations/premiumMessagingRegionsOperations.d.ts.map   
    [npmPack] npm notice 1.5kB   esm/operations/premiumMessagingRegionsOperations.js.map     
    [npmPack] npm notice 669B    esm/models/premiumMessagingRegionsOperationsMappers.d.ts.map
    [npmPack] npm notice 682B    esm/models/premiumMessagingRegionsOperationsMappers.js.map  
    [npmPack] npm notice 2.7kB   esm/operations/privateEndpointConnections.d.ts.map          
    [npmPack] npm notice 4.0kB   esm/operations/privateEndpointConnections.js.map            
    [npmPack] npm notice 655B    esm/models/privateEndpointConnectionsMappers.d.ts.map       
    [npmPack] npm notice 668B    esm/models/privateEndpointConnectionsMappers.js.map         
    [npmPack] npm notice 817B    esm/operations/privateLinkResources.d.ts.map                
    [npmPack] npm notice 1.1kB   esm/operations/privateLinkResources.js.map                  
    [npmPack] npm notice 251B    esm/models/privateLinkResourcesMappers.d.ts.map             
    [npmPack] npm notice 264B    esm/models/privateLinkResourcesMappers.js.map               
    [npmPack] npm notice 6.7kB   esm/operations/queues.d.ts.map                              
    [npmPack] npm notice 8.6kB   esm/operations/queues.js.map                                
    [npmPack] npm notice 651B    esm/models/queuesMappers.d.ts.map                           
    [npmPack] npm notice 664B    esm/models/queuesMappers.js.map                             
    [npmPack] npm notice 1.1kB   esm/operations/regions.d.ts.map                             
    [npmPack] npm notice 1.5kB   esm/operations/regions.js.map                               
    [npmPack] npm notice 617B    esm/models/regionsMappers.d.ts.map                          
    [npmPack] npm notice 630B    esm/models/regionsMappers.js.map                            

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 3, 2020

azure-resource-manager-schemas

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 29557e9 with merge commit 63e87c3e11b6ca218298d741df65c56201d98fde. Schema Automation 13.0.17.20200918.2
    [servicebus][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [servicebus][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [servicebus][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
  • ️✔️servicebus [View full logs]  [Preview Schema Changes]
      [after_scripts|node] PostProcessor finished successfully.
      [after_scripts|node]   5790 passing (1m)
      AzureResourceSchema has no registered package commands.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 3, 2020

    Azure CLI Extension Generation

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 3, 2020

    Trenton Generation

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 3, 2020

    azure-sdk-for-go

    ⚠️ warning [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 3, 2020

    azure-sdk-for-python-track2

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 3, 2020

    azure-sdk-for-java

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 29557e9 with merge commit 63e87c3e11b6ca218298d741df65c56201d98fde. SDK Automation 13.0.17.20200918.2
    • ️✔️sdk/servicebus/mgmt-v2015_08_01 [View full logs]  [Preview SDK Changes]
    • ⚠️sdk/servicebus/mgmt-v2017_04_01 [View full logs]  [Preview SDK Changes]
        [mvn] [ERROR] COMPILATION ERROR : 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/servicebus/v2017_04_01/implementation/PremiumMessagingRegionImpl.java:[16,92] type argument com.microsoft.azure.management.servicebus.v2017_04_01.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerModelT
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/servicebus/v2017_04_01/implementation/PremiumMessagingRegionsImpl.java:[21,122] type argument com.microsoft.azure.management.servicebus.v2017_04_01.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerT
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-servicebus: Compilation failure: Compilation failure: 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/servicebus/v2017_04_01/implementation/PremiumMessagingRegionImpl.java:[16,92] type argument com.microsoft.azure.management.servicebus.v2017_04_01.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerModelT
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/servicebus/v2017_04_01/implementation/PremiumMessagingRegionsImpl.java:[21,122] type argument com.microsoft.azure.management.servicebus.v2017_04_01.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerT
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
      • ⚠️sdk/servicebus/mgmt-v2018_01_01_preview [View full logs]  [Preview SDK Changes]
          [mvn] [ERROR] COMPILATION ERROR : 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2018_01_01_preview/src/main/java/com/microsoft/azure/management/servicebus/v2018_01_01_preview/implementation/PremiumMessagingRegionsImpl.java:[21,122] type argument com.microsoft.azure.management.servicebus.v2018_01_01_preview.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerT
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2018_01_01_preview/src/main/java/com/microsoft/azure/management/servicebus/v2018_01_01_preview/implementation/PremiumMessagingRegionImpl.java:[16,92] type argument com.microsoft.azure.management.servicebus.v2018_01_01_preview.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerModelT
          [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-servicebus: Compilation failure: Compilation failure: 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2018_01_01_preview/src/main/java/com/microsoft/azure/management/servicebus/v2018_01_01_preview/implementation/PremiumMessagingRegionsImpl.java:[21,122] type argument com.microsoft.azure.management.servicebus.v2018_01_01_preview.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerT
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2018_01_01_preview/src/main/java/com/microsoft/azure/management/servicebus/v2018_01_01_preview/implementation/PremiumMessagingRegionImpl.java:[16,92] type argument com.microsoft.azure.management.servicebus.v2018_01_01_preview.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerModelT
          [mvn] [ERROR] -> [Help 1]
          [mvn] [ERROR] 
          [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [mvn] [ERROR] 
          [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

        @v-Ajnava
        Copy link
        Contributor Author

        v-Ajnava commented Sep 4, 2020

        Hi @ArcturusZhang , can you please review the PR. its a fix for : https://portal.microsofticm.com/imp/v3/incidents/details/203561654/home

        @ArcturusZhang
        Copy link
        Member

        Hi @v-Ajnava this PR looks good to me.

        But there is a problem that this PR introduces a breaking change to a stable api-version, could you please follow the breaking change review process as documented in this doc?

        @ArcturusZhang ArcturusZhang added the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Sep 4, 2020
        @v-Ajnava
        Copy link
        Contributor Author

        v-Ajnava commented Sep 4, 2020

        Hi @v-Ajnava this PR looks good to me.

        But there is a problem that this PR introduces a breaking change to a stable api-version, could you please follow the breaking change review process as documented in this doc?

        we have done the similar change in the Eventhub Service : #10327

        @ArcturusZhang
        Copy link
        Member

        ArcturusZhang commented Sep 7, 2020

        Hi @v-Ajnava there is a big difference between this PR and the merged PR for eventhub: the eventhub PR is introducing breaking changes to a preview api-version, but this PR is intorducing breaking changes to a stable PR
        The breaking change review policies is more strict when breaking changes are introduced to a stable api-version. Please follow the policy to make a review request. Thanks

        @v-Ajnava
        Copy link
        Contributor Author

        v-Ajnava commented Sep 9, 2020

        Hi @v-Ajnava there is a big difference between this PR and the merged PR for eventhub: the eventhub PR is introducing breaking changes to a preview api-version, but this PR is intorducing breaking changes to a stable PR
        The breaking change review policies is more strict when breaking changes are introduced to a stable api-version. Please follow the policy to make a review request. Thanks

        here is the PR to split the swagger and make similar changes as Event Hub: #10071.

        @v-Ajnava
        Copy link
        Contributor Author

        Hi @ArcturusZhang , can you please help getting this reviewed by AzureAPIBorad.

        …into mastSBnetworkrulesets
        
        # Conflicts:
        #	specification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json
        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @v-Ajnava
        Copy link
        Contributor Author

        Hi @ArcturusZhang , PR #10071 is merged and now the new property is in 2018-preview API version. can you please review the PR.

        @ArcturusZhang
        Copy link
        Member

        @v-Ajnava
        Copy link
        Contributor Author

        v-Ajnava commented Sep 18, 2020

        Hi @v-Ajnava please follow the process documented here: https://microsoft.sharepoint.com/teams/azureecosystem/servicerings/Shared%20Documents/Breaking%20Changes/Azure%20Breaking%20Changes%20Program%20Definition-%20V1.0.pdf

        Seems like I don't have access to the document, I have requested for access.

        @ArcturusZhang ArcturusZhang added BreakingChangeReviewRequired and removed APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. labels Oct 22, 2020
        @openapi-workflow-bot
        Copy link

        Hi @v-Ajnava, one or multiple breaking change(s) is detected in your PR. Pls follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.

        @ArcturusZhang
        Copy link
        Member

        /azp run

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 3 pipeline(s).

        @ArcturusZhang
        Copy link
        Member

        Hi @v-Ajnava do we have any update on the breaking change review?

        @ArcturusZhang
        Copy link
        Member

        Hi, @v-Ajnava any updates?

        @openapi-workflow-bot
        Copy link

        Hi @v-Ajnava, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
        Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
        If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

        @ArcturusZhang
        Copy link
        Member

        /azp run

        @openapi-pipeline-app
        Copy link

        openapi-pipeline-app bot commented Dec 9, 2020

        Swagger Generation Artifacts

        ️🔄[Staging] ApiDocPreview inProgress [Detail]
        ️⚠️ azure-sdk-for-net warning [Detail]
        • ⚠️Warning [Logs] Generate from 78311c858b78ebfad85c134ee81dcc35c073e136. SDK Automation 14.0.0
          warn	Skip initScript due to not configured
          command	sudo apt-get install -y dotnet-sdk-5.0
          command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/servicebus/resource-manager/readme.md
          cmderr	[Autorest] realpath(): Permission denied
          cmderr	[Autorest] realpath(): Permission denied
          cmderr	[Autorest] realpath(): Permission denied
          cmderr	[Autorest] realpath(): Permission denied
          cmderr	[Autorest] realpath(): Permission denied
          cmderr	[Autorest] realpath(): Permission denied
        • ️✔️Microsoft.Azure.Management.ServiceBus [View full logs]  [Preview SDK Changes]
        ️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]
        • ️✔️Succeeded [Logs] Generate from 78311c858b78ebfad85c134ee81dcc35c073e136. SDK Automation 14.0.0
          warn	Skip initScript due to not configured
          command	npx n 12
          command	python3 -m venv venv
          command	pip install --upgrade setuptools wheel pip
          command	pip install pathlib jinja2 msrestazure
          command	autorest --version=V2 [email protected]/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/servicebus/resource-manager/readme.md
        • ️✔️azure-mgmt-servicebus [View full logs]  [Preview SDK Changes] Breaking Change Detected
          cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-servicebus
          cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
          cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
          cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-servicebus
          cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
          cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.servicebus
          cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.servicebus
          cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.servicebus
          cmderr	[changelogReport] INFO:__main__:Report written to sdk/servicebus/azure-mgmt-servicebus/code_reports/latest/report.json
          cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-servicebus on PyPI
          cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '0.2.0', '0.3.0', '0.3.1', '0.4.0', '0.5.0', '0.5.1', '0.5.2', '0.5.3', '0.6.0', '1.0.0', '6.0.0b1', '6.0.0']
          cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
          cmderr	[changelogReportLatest] INFO:__main__:Installing version 1.0.0 of azure-mgmt-servicebus in a venv
          cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
          cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.servicebus
          cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.servicebus
          cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.servicebus
          cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/servicebus/azure-mgmt-servicebus/code_reports/1.0.0/report.json
          cmdout	[Changelog] Size of delta 2.504% size of original (original: 62790 chars, delta: 1572 chars)
          cmdout	[Changelog] **Features**
          cmdout	[Changelog]   - Model SBNamespace has a new parameter identity
          cmdout	[Changelog]   - Model NetworkRuleSet has a new parameter trusted_service_access_enabled
          cmdout	[Changelog] **Breaking changes**
          cmdout	[Changelog]   - Operation DisasterRecoveryConfigsOperations.fail_over has a new signature
          warn	Breaking change found in changelog
        ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
        • ️✔️Succeeded [Logs] Generate from 78311c858b78ebfad85c134ee81dcc35c073e136. SDK Automation 14.0.0
          command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
          command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
        • ️✔️preview/servicebus/mgmt/2018-01-01-preview/servicebus [View full logs]  [Preview SDK Changes]
          info	[Changelog] ## Struct Changes
          info	[Changelog]
          info	[Changelog] ### New Struct Fields
          info	[Changelog]
          info	[Changelog] 1. NetworkRuleSetProperties.TrustedServiceAccessEnabled
          info	[Changelog]
        • ️✔️servicebus/mgmt/2017-04-01/servicebus [View full logs]  [Preview SDK Changes]
          info	[Changelog] No exported changes
        • ️✔️servicebus/mgmt/2015-08-01/servicebus [View full logs]  [Preview SDK Changes]
          info	[Changelog] No exported changes
        ️⚠️ azure-sdk-for-java warning [Detail]
        • ⚠️Warning [Logs] Generate from 78311c858b78ebfad85c134ee81dcc35c073e136. SDK Automation 14.0.0
          command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
          command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
          cmderr	[generate.py] 2020-12-09 03:09:47 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-servicebus-generated"
          cmderr	[generate.py] 2020-12-09 03:09:47 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
          cmderr	[generate.py] 2020-12-09 03:09:47 INFO autorest --version=3.0.6327 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/servicebus/azure-resourcemanager-servicebus-generated --java.namespace=com.azure.resourcemanager.servicebus.generated  --package-version=1.0.0-beta.1 --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --pipeline.modelerfour.flatten-payloads=false --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/servicebus/resource-manager/readme.md
          cmderr	[generate.py] 2020-12-09 03:10:38 INFO [CI][Success] Write to ci.yml
          cmderr	[generate.py] 2020-12-09 03:10:38 INFO [POM][Process] dealing with pom.xml
          cmderr	[generate.py] 2020-12-09 03:10:38 INFO [POM][Success] Write to pom.xml
          cmderr	[generate.py] 2020-12-09 03:10:38 INFO [POM][Process] dealing with root pom
          cmderr	[generate.py] 2020-12-09 03:10:38 INFO [POM][Skip] pom already has module sdk/servicebus
          cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
          cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
          cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
          cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
          cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
        • ️✔️azure-resourcemanager-servicebus-generated [View full logs]  [Preview SDK Changes]
          cmderr	[Inst] 2020-12-09 03:13:53 DEBUG Got artifact_id: azure-resourcemanager-servicebus-generated
          cmderr	[Inst] 2020-12-09 03:13:53 DEBUG Got artifact: pom.xml
          cmderr	[Inst] 2020-12-09 03:13:53 DEBUG Got artifact: azure-resourcemanager-servicebus-generated-1.0.0-beta.1-javadoc.jar
          cmderr	[Inst] 2020-12-09 03:13:53 DEBUG Got artifact: azure-resourcemanager-servicebus-generated-1.0.0-beta.1.jar
          cmderr	[Inst] 2020-12-09 03:13:53 DEBUG Match jar package: azure-resourcemanager-servicebus-generated-1.0.0-beta.1.jar
          cmderr	[Inst] 2020-12-09 03:13:53 DEBUG output: {"full": "curl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/10698/azure-sdk-for-java/azure-resourcemanager-servicebus-generated/azure-resourcemanager-servicebus-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-servicebus-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-servicebus-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-servicebus-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true\n"}
        ️❌ azure-sdk-for-ruby failed [Detail]
        • Failed [Logs] Generate from 78311c858b78ebfad85c134ee81dcc35c073e136. SDK Automation 14.0.0
          warn	Skip initScript due to not configured
          command	autorest --version=preview [email protected]/autorest.ruby@preview --ruby --multiapi --ruby-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-ruby ../azure-rest-api-specs/specification/servicebus/resource-manager/readme.md
          cmderr	[Autorest] realpath(): Permission denied
          cmderr	[Autorest] realpath(): Permission denied
          cmderr	[Autorest] realpath(): Permission denied
          cmderr	[Autorest] /home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/pipeline.js - FAILURE {}
          cmderr	[Autorest] (node:2813) UnhandledPromiseRejectionWarning: Error: Plugin modeler reported failure.
          cmderr	[Autorest]     at /home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/plugins/external.js:26:19
          cmderr	[Autorest]     at async ScheduleNode (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/pipeline.js:280:33)
          cmderr	[Autorest] (Use `node --trace-warnings ...` to show where the warning was created)
          cmderr	[Autorest] (node:2813) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 65)
          cmderr	[Autorest] (node:2813) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
          cmderr	[Autorest] (node:2813) UnhandledPromiseRejectionWarning: Error: Plugin modeler reported failure.
          cmderr	[Autorest]     at /home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/plugins/external.js:26:19
          cmderr	[Autorest]     at async ScheduleNode (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/pipeline.js:280:33)
          cmderr	[Autorest] (node:2813) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 66)
          cmderr	[Autorest] (node:2813) UnhandledPromiseRejectionWarning: Error: Plugin modeler reported failure.
          cmderr	[Autorest]     at /home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/plugins/external.js:26:19
          cmderr	[Autorest]     at async ScheduleNode (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/pipeline.js:280:33)
          cmderr	[Autorest] (node:2813) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 67)
          cmderr	[Autorest] (node:2813) UnhandledPromiseRejectionWarning: Error: Plugin modeler reported failure.
          cmderr	[Autorest]     at /home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/plugins/external.js:26:19
          cmderr	[Autorest]     at async ScheduleNode (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/pipeline.js:280:33)
          cmderr	[Autorest] (node:2813) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 68)
          cmderr	[Autorest] (node:2813) UnhandledPromiseRejectionWarning: Error: Plugin modeler reported failure.
          cmderr	[Autorest]     at /home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/plugins/external.js:26:19
          cmderr	[Autorest]     at async ScheduleNode (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/pipeline.js:280:33)
          cmderr	[Autorest] (node:2813) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 69)
          cmderr	[Autorest] (node:2813) UnhandledPromiseRejectionWarning: Error: Plugin modeler reported failure.
          cmderr	[Autorest]     at /home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/plugins/external.js:26:19
          cmderr	[Autorest]     at async ScheduleNode (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/pipeline.js:280:33)
          cmderr	[Autorest] (node:2813) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 70)
          cmderr	[Autorest] (node:2813) UnhandledPromiseRejectionWarning: Error: Plugin modeler reported failure.
          cmderr	[Autorest]     at /home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/plugins/external.js:26:19
          cmderr	[Autorest]     at async ScheduleNode (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/pipeline.js:280:33)
          cmderr	[Autorest] (node:2813) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 71)
          cmderr	[Autorest] Failure during batch task - {"tag":"package-2017-04"} -- Error: Plugin modeler reported failure..
          cmderr	[Autorest]   Error: Plugin modeler reported failure.
          error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-ruby]: autorest
          warn	Skip package processing as generation is failed
        ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
        • ️✔️Succeeded [Logs] Generate from 78311c858b78ebfad85c134ee81dcc35c073e136. SDK Automation 14.0.0
          warn	Skip initScript due to not configured
          command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/servicebus/resource-manager/readme.md
        • ️✔️@azure/arm-servicebus [View full logs]  [Preview SDK Changes]
          cmderr	[npmPack] loaded rollup.config.js with warnings
          cmderr	[npmPack] (!) Unused external imports
          cmderr	[npmPack] default imported from external module 'rollup' but never used
          cmderr	[npmPack] ./esm/serviceBusManagementClient.js → ./dist/arm-servicebus.js...
          cmderr	[npmPack] created ./dist/arm-servicebus.js in 553ms
        ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
        • ️✔️Succeeded [Logs] Generate from 78311c858b78ebfad85c134ee81dcc35c073e136. Schema Automation 14.0.0
          warn	Skip initScript due to not configured
          command	npx n 12
          command	autorest --use=@autorest/[email protected] --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/servicebus/resource-manager/readme.md
        • ️✔️servicebus [View full logs]  [Preview Schema Changes]
          cmderr	[resource-manager] node-pre-gyp
          cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
          cmderr	[resource-manager]  [email protected] No repository field.
          cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
          cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
        Posted by Swagger Pipeline | How to fix these errors?

        @ArcturusZhang
        Copy link
        Member

        Hey @v-Ajnava do we have any update on this?

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 2 pipeline(s).

        @ghost
        Copy link

        ghost commented Dec 27, 2020

        Hi, @v-Ajnava. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

        @ghost ghost added the no-recent-activity label Dec 27, 2020
        @ArcturusZhang
        Copy link
        Member

        Hey @v-Ajnava do we have any update on this PR?

        @ghost ghost closed this Mar 22, 2021
        @ghost
        Copy link

        ghost commented Mar 22, 2021

        Hi, @v-Ajnava. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee @ArcturusZhang.

        This pull request was closed.
        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

        Projects

        None yet

        Development

        Successfully merging this pull request may close these issues.

        2 participants