-
Notifications
You must be signed in to change notification settings - Fork 5.6k
ServiceBus : Added trustedServiceAccessEnabled optional property in Networkrulesets fix for ICM 203561654 #10698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s fix for ICM 203561654
Swagger Validation Report
|
| Rule | Message |
|---|---|
1041 - AddedPropertyInResponse |
The new version has a new property 'trustedServiceAccessEnabled' in response that was not found in the old version. New: Microsoft.ServiceBus/preview/2018-01-01-preview/NetworkRuleSet-preview.json#L179:11 Old: Microsoft.ServiceBus/preview/2018-01-01-preview/NetworkRuleSet-preview.json#L179:11 |
1041 - AddedPropertyInResponse |
The new version has a new property 'trustedServiceAccessEnabled' in response that was not found in the old version. New: Microsoft.ServiceBus/preview/2018-01-01-preview/NetworkRuleSet-preview.json#L179:11 Old: Microsoft.ServiceBus/preview/2018-01-01-preview/NetworkRuleSet-preview.json#L179:11 |
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/servicebus/resource-manager/readme.md tag: specification/servicebus/resource-manager/readme.md#tag-package-2018-01-preview |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
PR is fix for : https://portal.microsofticm.com/imp/v3/incidents/details/203561654/home this is a bug fix |
azure-sdk-for-python
|
azure-sdk-for-net
|
azure-sdk-for-js
|
azure-resource-manager-schemas
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go
|
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java
|
|
Hi @ArcturusZhang , can you please review the PR. its a fix for : https://portal.microsofticm.com/imp/v3/incidents/details/203561654/home |
|
Hi @v-Ajnava there is a big difference between this PR and the merged PR for eventhub: the eventhub PR is introducing breaking changes to a preview api-version, but this PR is intorducing breaking changes to a stable PR |
here is the PR to split the swagger and make similar changes as Event Hub: #10071. |
|
Hi @ArcturusZhang , can you please help getting this reviewed by AzureAPIBorad. |
…into mastSBnetworkrulesets # Conflicts: # specification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @ArcturusZhang , PR #10071 is merged and now the new property is in 2018-preview API version. can you please review the PR. |
|
Hi @v-Ajnava please follow the process documented here: https://microsoft.sharepoint.com/teams/azureecosystem/servicerings/Shared%20Documents/Breaking%20Changes/Azure%20Breaking%20Changes%20Program%20Definition-%20V1.0.pdf |
Seems like I don't have access to the document, I have requested for access. |
|
Hi @v-Ajnava, one or multiple breaking change(s) is detected in your PR. Pls follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Hi @v-Ajnava do we have any update on the breaking change review? |
|
Hi, @v-Ajnava any updates? |
|
Hi @v-Ajnava, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
/azp run |
Swagger Generation Artifacts
|
|
Hey @v-Ajnava do we have any update on this? |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hi, @v-Ajnava. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hey @v-Ajnava do we have any update on this PR? |
|
Hi, @v-Ajnava. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee @ArcturusZhang. |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.