[Hub Generated] Review request for Microsoft.Kusto to add version stable/2020-09-18#10688
Conversation
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Checked the swagger changes in the new API version they are fine. Marking it as ARM Approved. |
|
The reformatting in 91a65dc makes it hard to find what changed between api-version. If convenient could we get a summary on changes, or a better diff view on changes? |
|
Here is a short description of the changes:
Adding diff file for reference |
| "provisioningState": { | ||
| "type": "string", | ||
| "readOnly": true, | ||
| "description": "The provisioned state of the resource.", | ||
| "enum": [ | ||
| "Running", | ||
| "Creating", | ||
| "Deleting", | ||
| "Succeeded", | ||
| "Failed", | ||
| "Moving" | ||
| ], | ||
| "x-ms-enum": { | ||
| "name": "ProvisioningState", | ||
| "modelAsString": true | ||
| } |
There was a problem hiding this comment.
There appears to be several same definition of "provisioningState". It might better to put it to definition and share the reference, like https://github.com/Azure/azure-rest-api-specs/blob/master/specification/network/resource-manager/Microsoft.Network/stable/2020-06-01/network.json#L241-L255
|
Since it is a new stable api-version, you might want to check if some of LintDiff error can be fixed in this version. |
specification/azure-kusto/resource-manager/Microsoft.Kusto/stable/2020-09-18/kusto.json
Show resolved
Hide resolved
| description: 'The Azure Kusto management API provides a RESTful set of web services that interact with Azure Kusto services to manage your clusters and databases. The API enables you to create, update, and delete clusters and databases.' | ||
| openapi-type: arm | ||
| tag: package-2020-06-14 | ||
| tag: package-2020-09 |
|
|
||
| These settings apply only when `--tag=package-2020-09` is specified on the command line. | ||
|
|
||
| ```yaml $(tag) == 'package-2020-09' |
specification/azure-kusto/resource-manager/Microsoft.Kusto/stable/2020-09-18/kusto.json
Show resolved
Hide resolved
|
Ready for this to be merged in. |
@roshauli |
|
@weidongxu-microsoft Thank you for confirming, |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.