Skip to content

Network: update readme.java.md #10682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmyyrroonn merged 1 commit into from
Sep 10, 2020
Merged

Network: update readme.java.md #10682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions specification/network/resource-manager/readme.java.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ directive:
- rename-operation:
from: VirtualHubBgpConnection_Delete
to: VirtualHubBgpConnections_Delete
- rename-operation:
from: InboundSecurityRule_CreateOrUpdate
Copy link
Contributor

@mmyyrroonn mmyyrroonn Sep 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this one? Duplicate operation ID?

Copy link
Contributor Author

@xseeseesee xseeseesee Sep 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's required for autorest.java. For operations, the code generator will take InboundSecurityRule and prepare keywords of InboundSecurityRule and InboundSecurityRules while it already exists InboundSecurityRules in the swagger definition. Once we rename it to a new operation name, the conflict gets resolved.

to: InboundSecurityRuleOperation_CreateOrUpdate
```

### Java multi-api
Expand Down