Adding PowerPlatform swagger. by rapatank · Pull Request #10651 · Azure/azure-rest-api-specs

rapatank · 2020-08-31T21:03:33Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-08-31T21:03:39Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-08-31T21:03:51Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-31T21:05:20Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 5e23a00 with merge commit 75f089d. SDK Automation 13.0.17.20200916.11

Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt/powerplatform/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/powerplatform/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/powerplatform/_power_platform.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/powerplatform/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/powerplatform/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/powerplatform/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/powerplatform/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/powerplatform/models/_power_platform_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/powerplatform/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/powerplatform/operations/_enterprise_policies_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/powerplatform/operations/_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/powerplatform/operations/_private_endpoint_connections_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/powerplatform/operations/_private_link_resources_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/powerplatform/operations/_subnets_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/powerplatform/version.py

openapi-sdkautomation · 2020-08-31T21:05:20Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 5e23a00 with merge commit 75f089d. SDK Automation 13.0.17.20200916.11
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-08-31T21:05:20Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 5e23a00 with merge commit 75f089d. SDK Automation 13.0.17.20200916.11
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-08-31T21:05:21Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-31T21:05:23Z

azure-resource-manager-schemas - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-31T21:05:23Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5e23a00 with merge commit 75f089d. SDK Automation 13.0.17.20200916.11
️✔️preview/powerplatform/mgmt/2020-10-30 [View full logs] [Release SDK Changes]
- preview.powerplatform.mgmt.2020-10-30.zip

openapi-sdkautomation · 2020-08-31T21:05:24Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-31T21:05:26Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-08-31T21:20:38Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-31T21:22:18Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

raych1 · 2020-09-01T00:26:47Z

@rapatank, please fix the CI check failures.

azure-pipelines · 2020-09-01T00:38:47Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-01T00:52:30Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-01T02:49:01Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-01T02:52:37Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-01T03:12:28Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-10T20:48:16Z

Azure Pipelines successfully started running 1 pipeline(s).

raych1 · 2020-09-11T01:36:05Z

Please go through the contribution checklist added as part of the review and mark them completed. This is a requirement before review can be continued.

@rapatank , could you reply chiragg4u if you complete above ask to start ARM review?

...orm/resource-manager/Microsoft.PowerPlatform/preview/2020-10-30-preview/subnetResources.json

azure-pipelines · 2020-09-13T02:51:34Z

Azure Pipelines successfully started running 1 pipeline(s).

chiragg4u · 2020-09-13T03:54:39Z

...orm/resource-manager/Microsoft.PowerPlatform/preview/2020-10-30-preview/subnetResources.json

+        }
+      }
+    },
+    "Subnet": {


Subnet [](start = 5, length = 6)

I assume you are modeling it as a network subnet resource have you reviewed the network swagger definitions
specification\network\resource-manager\Microsoft.Network\stable\2018-11-01\virtualNetwork.json

...ce-manager/Microsoft.PowerPlatform/preview/2020-10-30-preview/privateEndpointConnection.json

chiragg4u · 2020-09-13T05:18:39Z

Please resolve the model validation failures

azure-pipelines · 2020-09-14T00:37:12Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-14T01:10:42Z

Azure Pipelines successfully started running 1 pipeline(s).

raych1 · 2020-09-14T03:08:31Z

...rm/resource-manager/Microsoft.PowerPlatform/preview/2020-10-30-preview/enterprisePolicy.json

+            "$ref": "../../common/v1/definitions.json#/parameters/ResourceGroupNameParameter"
+          },
+          {
+            "$ref": "../../common/v1/definitions.json#/parameters/ApiVersionParameter"


This reference doesn't exist now and also needs to be updated.

thanks! done

raych1 · 2020-09-14T03:08:41Z

...rm/resource-manager/Microsoft.PowerPlatform/preview/2020-10-30-preview/enterprisePolicy.json

+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/SubscriptionIdParameter"
+          },
+          {
+            "$ref": "../../common/v1/definitions.json#/parameters/ApiVersionParameter"


raych1 · 2020-09-14T03:08:58Z

...rm/resource-manager/Microsoft.PowerPlatform/preview/2020-10-30-preview/enterprisePolicy.json

+        "operationId": "Operations_List",
+        "parameters": [
+          {
+            "$ref": "../../common/v1/definitions.json#/parameters/ApiVersionParameter"


done, thanks!

azure-pipelines · 2020-09-14T03:20:52Z

Azure Pipelines successfully started running 1 pipeline(s).

chiragg4u · 2020-09-17T15:35:53Z

specification/powerplatform/resource-manager/Microsoft.PowerPlatform/common/v1/definitions.json

+      },
+      "description": "An error response from the PowerPlatform service."
+    },
+    "Resource": {


As commented in different file; these should refer to global common definitions rather than copying locally.

chiragg4u · 2020-09-17T15:40:31Z

...esource-manager/Microsoft.PowerPlatform/preview/2020-10-30-preview/privateLinkResources.json

+        ]
+      }
+    },
+    "/providers/Microsoft.PowerPlatform/operations": {


"/providers/Microsoft.PowerPlatform/operations" [](start = 0, length = 51)

Nit: Normally operations API's are kept in the main swagger file.

chiragg4u · 2020-09-17T15:42:12Z

Looked at the changes, API's seems to be OK and has been reviewed by the team internally. Marking ARMSignOff based on the discussion.

* PowerPlatform RP specifications * PowerPlatform changes * Updating powerplatform json * Update definitions.json * Updating the schema * Updated the schema. * Updates to schema * Schema update * Schema update * Example update * Update description * Updating the swagger * Updating the swagger definition * Swagger update. * Swagger updates * Adding private link changes. * Updates to readme.md * Private link updates * Schema update * private link update * response update * Added systemData * Updated description. * Adding subnet configuration * readme update. * Adding systemData. * Updated example * Update * Update to systemData * Updates * Updates * Updated the version of common types * readme.go update * Update * Updated version * version update * update * update * Updated "enterprisePromise" to "enterprisePolicy". * Updates * Updates * Updating to use common type * updates

rapatank added 2 commits August 28, 2020 16:26

PowerPlatform RP specifications

cd785e5

PowerPlatform changes

e151577

openapi-assignment-bot bot assigned raych1 Aug 31, 2020

rapatank added 2 commits August 31, 2020 14:17

Updating powerplatform json

78e46e4

Update definitions.json

427ee1a

openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 1, 2020

raych1 added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Sep 1, 2020

Updating the schema

ebc1721

Updated the schema.

11a7c98

Updates to schema

2df5362

Schema update

b9a8313

Schema update

96d3724

Updated "enterprisePromise" to "enterprisePolicy".

dce442b

chiragg4u reviewed Sep 12, 2020

View reviewed changes

...orm/resource-manager/Microsoft.PowerPlatform/preview/2020-10-30-preview/subnetResources.json Outdated Show resolved Hide resolved

chiragg4u reviewed Sep 12, 2020

View reviewed changes

...orm/resource-manager/Microsoft.PowerPlatform/preview/2020-10-30-preview/subnetResources.json Show resolved Hide resolved

Updates

28a766b

chiragg4u reviewed Sep 13, 2020

View reviewed changes

...ce-manager/Microsoft.PowerPlatform/preview/2020-10-30-preview/privateEndpointConnection.json Outdated Show resolved Hide resolved

Updates

b4b4459

Updating to use common type

eae057d

raych1 reviewed Sep 14, 2020

View reviewed changes

raych1 added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Sep 14, 2020

updates

5e23a00

rapatank removed the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Sep 14, 2020

chiragg4u reviewed Sep 17, 2020

View reviewed changes

chiragg4u added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 17, 2020

raych1 approved these changes Sep 17, 2020

View reviewed changes

raych1 merged commit 75f089d into master Sep 17, 2020

ctaggart mentioned this pull request Nov 8, 2020

fix powerplatforrm ref & duplicates #11580

Merged

Comments

Conversation

rapatank commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-pipeline-app bot commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Staging] Swagger Validation Report

Uh oh!

azure-pipelines bot commented Aug 31, 2020

Uh oh!

openapi-sdkautomation bot commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Azure CLI Extension Generation - Release

Uh oh!

openapi-sdkautomation bot commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-resource-manager-schemas - Release

Uh oh!

openapi-sdkautomation bot commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Trenton Generation - Release

Uh oh!

azure-pipelines bot commented Aug 31, 2020

Uh oh!

openapi-sdkautomation bot commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python-track2 - Release

Uh oh!

raych1 commented Sep 1, 2020

Uh oh!

azure-pipelines bot commented Sep 1, 2020

Uh oh!

azure-pipelines bot commented Sep 1, 2020

Uh oh!

azure-pipelines bot commented Sep 1, 2020

Uh oh!

azure-pipelines bot commented Sep 1, 2020

Uh oh!

azure-pipelines bot commented Sep 1, 2020

Uh oh!

azure-pipelines bot commented Sep 10, 2020

Uh oh!

raych1 commented Sep 11, 2020

Uh oh!

Uh oh!

Uh oh!

azure-pipelines bot commented Sep 13, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chiragg4u commented Sep 13, 2020

Uh oh!

azure-pipelines bot commented Sep 14, 2020

rapatank commented Aug 31, 2020 •

edited

Loading

openapi-pipeline-app bot commented Aug 31, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 31, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 31, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 31, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 31, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 31, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 31, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 31, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 31, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 31, 2020 •

edited

Loading