Skip to content

update link context to type dictionary #10624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmyyrroonn merged 1 commit into from
Aug 28, 2020
Merged

update link context to type dictionary #10624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions ...fication/network/resource-manager/Microsoft.Network/stable/2020-06-01/networkWatcher.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3461,10 +3461,10 @@
},
"context": {
"readOnly": true,
"type": "array",
"description": "Provides additional context on the issue.",
"items": {
"$ref": "#/definitions/IssueContext"
"type": "object",
"description": "Provides additional context on links.",
"additionalProperties": {
"type": "string"
}
},
"resourceId": {
Expand All @@ -3480,19 +3480,16 @@
"roundTripTimeMin": {
"description": "Minimum roundtrip time in milliseconds.",
"readOnly": true,
"format": "int32",
"type": "integer"
},
"roundTripTimeAvg": {
"description": "Average roundtrip time in milliseconds.",
"readOnly": true,
"format": "int32",
Copy link
Copy Markdown
Contributor

@mmyyrroonn mmyyrroonn Aug 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we remove this format?

Copy link
Copy Markdown
Contributor

@mmyyrroonn mmyyrroonn Aug 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

talked offline. will add this format back next week since @junyezhu need confirm with one team member who is on vacation right now.

"type": "integer"
},
"roundTripTimeMax": {
"description": "Maximum roundtrip time in milliseconds.",
"readOnly": true,
"format": "int32",
"type": "integer"
}
}
Expand Down
11 changes: 4 additions & 7 deletions ...fication/network/resource-manager/Microsoft.Network/stable/2020-07-01/networkWatcher.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3461,10 +3461,10 @@
},
"context": {
"readOnly": true,
"type": "array",
"description": "Provides additional context on the issue.",
"items": {
"$ref": "#/definitions/IssueContext"
"type": "object",
"description": "Provides additional context on links.",
"additionalProperties": {
"type": "string"
}
},
"resourceId": {
Expand All @@ -3480,19 +3480,16 @@
"roundTripTimeMin": {
"description": "Minimum roundtrip time in milliseconds.",
"readOnly": true,
"format": "int32",
"type": "integer"
},
"roundTripTimeAvg": {
"description": "Average roundtrip time in milliseconds.",
"readOnly": true,
"format": "int32",
"type": "integer"
},
"roundTripTimeMax": {
"description": "Maximum roundtrip time in milliseconds.",
"readOnly": true,
"format": "int32",
"type": "integer"
}
}
Expand Down