-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Updating readme.md files for SDK generation (multi-api, new api version already checked in) #10567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and remove updateConfigurations API
…m/Suna-MS/azure-rest-api-specs into moljain/flexServerNamespace
…intali/azure-rest-api-specs into moljain/flexServerNamespace
…n2/azure-rest-api-specs into moljain/flexServerNamespace
[Staging] Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
❌ |
| Rule | Message |
|---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/flexibleServers/{serverName}/maintenanceWindows' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-02-14-privatepreview/postgresql.json#L950:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/flexibleServers/{serverName}/maintenanceWindows/{maintenanceWindowName}' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-02-14-privatepreview/postgresql.json#L796:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForMySql/flexibleServers/{serverName}/maintenanceWindows/{maintenanceWindowName}' removed or restructured? Old: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L1043:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForMySql/flexibleServers/{serverName}/maintenanceWindows' removed or restructured? Old: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L1197:5 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'MaintenanceWindowProperties' removed or renamed? New: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L1215:3 Old: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L1321:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'CustomerMaintenanceWindowProperties' removed or renamed? New: Microsoft.DBforPostgreSQL/preview/2020-02-14-privatepreview/postgresql.json#L1176:3 Old: Microsoft.DBforPostgreSQL/preview/2020-02-14-privatepreview/postgresql.json#L1071:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'CustomerMaintenanceWindow' removed or renamed? New: Microsoft.DBforPostgreSQL/preview/2020-02-14-privatepreview/postgresql.json#L1176:3 Old: Microsoft.DBforPostgreSQL/preview/2020-02-14-privatepreview/postgresql.json#L1071:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'VnetInjArgs' removed or renamed? New: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L1215:3 Old: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L1321:3 |
1007 - RemovedClientParameter |
The new version is missing a client parameter that was found in the old version. Was 'MaintenanceWindowNameParameter' removed or renamed? New: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L2146:3 Old: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L2077:3 |
1008 - ModifiedOperationId |
The operation id has been changed from 'CheckNameAvailability_Execute' to 'CheckNameAvailability'. This will impact generated code. New: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L1137:7 Old: Microsoft.DBforMySQL/preview/2020-07-01-privatepreview/mysql.json#L1243:7 |
️️✔️LintDiff [Detail]
️✔️Validation passes for LintDiff.
️❌Avocado: 1 Errors, 0 Warnings [Detail] [Expand]
❌| Rule | Message |
|---|---|
UNREFERENCED_JSON_FILE |
The example JSON file is not referenced from the swagger file. readme: specification/mysql/resource-manager/readme.md json: preview/2020-07-01-privatepreview/examples/MaintenanceWindowsListByServer.json |
️️✔️ModelValidation [Detail]
️✔️Validation passes for ModelValidation.
️️✔️SemanticValidation [Detail]
️✔️Validation passes for SemanticValidation.
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java
|
azure-sdk-for-go
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
…om/pradeepkintali/azure-rest-api-specs into moljain/flexServerNamespace
…om/pradeepkintali/azure-rest-api-specs into moljain/flexServerNamespace
…om/pradeepkintali/azure-rest-api-specs into moljain/flexServerNamespace
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Sep 3, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Abandoning this PR. Changes should only include readme.md files. Will recreate PR and activate it once the new swagger spec is checked in. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
This PR is to update MD files for azure.mgmt.rdbms namespace, which includes mysql and postgresql.
8/26: Marked as draft as new API changes are pending check in.
Overview of changes:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.