Skip to content

Conversation

@yuwzho
Copy link
Contributor

@yuwzho yuwzho commented Aug 24, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 24, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yuwzho yuwzho requested a review from shawncx August 24, 2020 07:45
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 24, 2020

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from dfba924 with merge commit fce6ed2. SDK Automation 13.0.17.20200807.2
    [azure-mgmt-appplatform][ChangeLog] WARNING: Failed to generate ChangeLog.
  • ⚠️azure-mgmt-appplatform [View full logs]  [Release SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-appplatform
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-appplatform
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    Not exact 2 reports found:
    code_reports/0.1.0/report.json
    code_reports/latest/merged_report.json
    code_reports/latest/v2019_05_01_preview.json
    code_reports/latest/v2020_07_01.json
    Not generating changelog.
    [ChangeLog] WARNING: Failed to generate ChangeLog.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 24, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 24, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from dfba924 with merge commit fce6ed2. SDK Automation 13.0.17.20200807.2
  • ️✔️@azure/arm-appplatform [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/appPlatformManagementClient.js → ./dist/arm-appplatform.js...
    [npmPack] created ./dist/arm-appplatform.js in 521ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 2.2kB   esm/appPlatformManagementClient.js             
    [npmPack] npm notice 2.7kB   esm/appPlatformManagementClientContext.js      
    [npmPack] npm notice 13.5kB  esm/operations/apps.js                         
    [npmPack] npm notice 1.1kB   esm/models/appsMappers.js                      
    [npmPack] npm notice 207.9kB dist/arm-appplatform.js                        
    [npmPack] npm notice 66.7kB  dist/arm-appplatform.min.js                    
    [npmPack] npm notice 12.2kB  esm/operations/bindings.js                     
    [npmPack] npm notice 1.1kB   esm/models/bindingsMappers.js                  
    [npmPack] npm notice 9.0kB   esm/operations/certificates.js                 
    [npmPack] npm notice 1.1kB   esm/models/certificatesMappers.js              
    [npmPack] npm notice 7.0kB   esm/operations/configServers.js                
    [npmPack] npm notice 1.0kB   esm/models/configServersMappers.js             
    [npmPack] npm notice 12.5kB  esm/operations/customDomains.js                
    [npmPack] npm notice 1.1kB   esm/models/customDomainsMappers.js             
    [npmPack] npm notice 22.8kB  esm/operations/deployments.js                  
    [npmPack] npm notice 1.1kB   esm/models/deploymentsMappers.js               
    [npmPack] npm notice 345B    esm/models/index.js                            
    [npmPack] npm notice 652B    esm/operations/index.js                        
    [npmPack] npm notice 56.0kB  esm/models/mappers.js                          
    [npmPack] npm notice 7.3kB   esm/operations/monitoringSettings.js           
    [npmPack] npm notice 1.1kB   esm/models/monitoringSettingsMappers.js        
    [npmPack] npm notice 2.3kB   esm/operations/operations.js                   
    [npmPack] npm notice 560B    esm/models/operationsMappers.js                
    [npmPack] npm notice 3.5kB   esm/models/parameters.js                       
    [npmPack] npm notice 995B    rollup.config.js                               
    [npmPack] npm notice 17.2kB  esm/operations/services.js                     
    [npmPack] npm notice 1.2kB   esm/models/servicesMappers.js                  
    [npmPack] npm notice 2.3kB   esm/operations/skus.js                         
    [npmPack] npm notice 575B    esm/models/skusMappers.js                      
    [npmPack] npm notice 1.7kB   package.json                                   
    [npmPack] npm notice 457B    tsconfig.json                                  
    [npmPack] npm notice 957B    esm/appPlatformManagementClient.d.ts.map       
    [npmPack] npm notice 1.3kB   esm/appPlatformManagementClient.js.map         
    [npmPack] npm notice 521B    esm/appPlatformManagementClientContext.d.ts.map
    [npmPack] npm notice 1.4kB   esm/appPlatformManagementClientContext.js.map  
    [npmPack] npm notice 3.9kB   esm/operations/apps.d.ts.map                   
    [npmPack] npm notice 6.7kB   esm/operations/apps.js.map                     
    [npmPack] npm notice 596B    esm/models/appsMappers.d.ts.map                
    [npmPack] npm notice 609B    esm/models/appsMappers.js.map                  
    [npmPack] npm notice 387.4kB dist/arm-appplatform.js.map                    
    [npmPack] npm notice 55.0kB  dist/arm-appplatform.min.js.map                
    [npmPack] npm notice 3.1kB   esm/operations/bindings.d.ts.map               
    [npmPack] npm notice 5.6kB   esm/operations/bindings.js.map                 
    [npmPack] npm notice 565B    esm/models/bindingsMappers.d.ts.map            
    [npmPack] npm notice 578B    esm/models/bindingsMappers.js.map              
    [npmPack] npm notice 2.4kB   esm/operations/certificates.d.ts.map           
    [npmPack] npm notice 4.2kB   esm/operations/certificates.js.map             
    [npmPack] npm notice 573B    esm/models/certificatesMappers.d.ts.map        
    [npmPack] npm notice 586B    esm/models/certificatesMappers.js.map          
    [npmPack] npm notice 1.6kB   esm/operations/configServers.d.ts.map          
    [npmPack] npm notice 3.1kB   esm/operations/configServers.js.map            
    [npmPack] npm notice 562B    esm/models/configServersMappers.d.ts.map       
    [npmPack] npm notice 575B    esm/models/configServersMappers.js.map         
    [npmPack] npm notice 3.1kB   esm/operations/customDomains.d.ts.map          
    [npmPack] npm notice 5.6kB   esm/operations/customDomains.js.map            
    [npmPack] npm notice 575B    esm/models/customDomainsMappers.d.ts.map       
    [npmPack] npm notice 588B    esm/models/customDomainsMappers.js.map         
    [npmPack] npm notice 5.6kB   esm/operations/deployments.d.ts.map            
    [npmPack] npm notice 10.3kB  esm/operations/deployments.js.map              
    [npmPack] npm notice 584B    esm/models/deploymentsMappers.d.ts.map         
    [npmPack] npm notice 597B    esm/models/deploymentsMappers.js.map           
    [npmPack] npm notice 25.5kB  esm/models/index.d.ts.map                      
    [npmPack] npm notice 334B    esm/operations/index.d.ts.map                  
    [npmPack] npm notice 126B    esm/models/index.js.map                        
    [npmPack] npm notice 349B    esm/operations/index.js.map                    
    [npmPack] npm notice 3.2kB   esm/models/mappers.d.ts.map                    
    [npmPack] npm notice 31.5kB  esm/models/mappers.js.map                      
    [npmPack] npm notice 1.6kB   esm/operations/monitoringSettings.d.ts.map     
    [npmPack] npm notice 3.1kB   esm/operations/monitoringSettings.js.map       
    [npmPack] npm notice 572B    esm/models/monitoringSettingsMappers.d.ts.map  
    [npmPack] npm notice 585B    esm/models/monitoringSettingsMappers.js.map    
    [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map             
    [npmPack] npm notice 1.4kB   esm/operations/operations.js.map               
    [npmPack] npm notice 277B    esm/models/operationsMappers.d.ts.map          
    [npmPack] npm notice 290B    esm/models/operationsMappers.js.map            
    [npmPack] npm notice 822B    esm/models/parameters.d.ts.map                 
    [npmPack] npm notice 2.7kB   esm/models/parameters.js.map                   
    [npmPack] npm notice 5.6kB   esm/operations/services.d.ts.map               
    [npmPack] npm notice 9.1kB   esm/operations/services.js.map                 
    [npmPack] npm notice 614B    esm/models/servicesMappers.d.ts.map            
    [npmPack] npm notice 627B    esm/models/servicesMappers.js.map              
    [npmPack] npm notice 1.0kB   esm/operations/skus.d.ts.map                   
    [npmPack] npm notice 1.4kB   esm/operations/skus.js.map                     
    [npmPack] npm notice 265B    esm/models/skusMappers.d.ts.map                
    [npmPack] npm notice 278B    esm/models/skusMappers.js.map                  
    [npmPack] npm notice 3.4kB   README.md                                      
    [npmPack] npm notice 1.5kB   esm/appPlatformManagementClient.d.ts           

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 24, 2020

azure-resource-manager-schemas - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from dfba924 with merge commit fce6ed2. Schema Automation 13.0.17.20200807.2
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 24, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 24, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 24, 2020

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 24, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 24, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yuwzho yuwzho removed the request for review from bowen5 August 24, 2020 08:36
@njuCZ njuCZ merged commit fce6ed2 into Azure:master Aug 24, 2020
@yuwzho yuwzho deleted the yuwzho/appplatform branch August 24, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants