-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2020-06-01 #10507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
akning-ms
merged 8 commits into
Azure:master
from
Zzegfried:dev-cost-management-Microsoft.CostManagement-2020-06-01
Aug 19, 2020
Merged
[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2020-06-01 #10507
akning-ms
merged 8 commits into
Azure:master
from
Zzegfried:dev-cost-management-Microsoft.CostManagement-2020-06-01
Aug 19, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt-2020-06-01 # Conflicts: # specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json # specification/cost-management/resource-manager/readme.go.md # specification/cost-management/resource-manager/readme.md
# Conflicts: # specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json # specification/cost-management/resource-manager/readme.go.md # specification/cost-management/resource-manager/readme.md
…nt-2020-06-01 # Conflicts: # specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json # specification/cost-management/resource-manager/readme.go.md # specification/cost-management/resource-manager/readme.md
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-js - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
Azure CLI Extension Generation - Release
|
azure-resource-manager-schemas - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Contributor
|
Can one of the admins verify this patch? |
sashahdo
approved these changes
Aug 18, 2020
akning-ms
reviewed
Aug 19, 2020
| }, | ||
| { | ||
| "$ref": "#/parameters/apiVersionParameter" | ||
| "$ref": "#/parameters/apiVersion20200601Parameter" |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, why we need put the version info in the description? :) if so, it means we need to add one more definition for every new API version for it?
Contributor
Author
|
The CostManagement resource provider has multiple resource types each of which has a set of API paths used to manage the resources. We never increase the API version for all resource types at the same time. In this case the latest API version of the Exports resource type is “2020-06-01” but the latest version for the others remain at 2019-11-01 for now. Because the docs appear to only support one version of a swagger this is a bit of a hack to inform customers which version they should use. If you can tell me a better way to do this I would be very interested to hear it.
From: Arthur Ning <[email protected]>
Sent: Tuesday, August 18, 2020 5:43 PM
To: Azure/azure-rest-api-specs <[email protected]>
Cc: melmullen <[email protected]>; Author <[email protected]>
Subject: Re: [Azure/azure-rest-api-specs] [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2020-06-01 (#10507)
@akning-ms commented on this pull request.
_____
In specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2020-06-01/costmanagement.json <#10507 (comment)> :
@@ -1256,7 +1256,7 @@
"$ref": "#/parameters/scopeQueryParameter"
},
{
- "$ref": "#/parameters/apiVersionParameter"
+ "$ref": "#/parameters/apiVersion20200601Parameter"
Just curious, why we need put the version info in the description? :) if so, it means we need to add one more definition for every new API version for it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#10507 (review)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMCLO62OJL2VB4NZRKGMM4LSBMN2NANCNFSM4QD3V5XQ> . <https://github.com/notifications/beacon/AMCLO673R45U2NPKBVPN24DSBMN2NA5CNFSM4QD3V5X2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODQBIO2A.gif>
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.