Updated the resource settings models of following tracked NRP resources #10468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
❌ |
| Rule | Message |
|---|---|
|
The operation id has been changed from 'MoveCollection_Update' to 'MoveCollections_Update'. This will impact generated code. New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L81:7 Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L81:7 |
️️✔️LintDiff [Detail]
️✔️Validation passes for LintDiff.
️️✔️Avocado [Detail]
️✔️Validation passes for Avocado.
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
|
innosam
force-pushed
the
hsingh/regionmovenetworkresourcesettingsupdate
branch
from
e9288ef to
c426839
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
innosam
force-pushed
the
hsingh/regionmovenetworkresourcesettingsupdate
branch
from
c426839 to
931bfc5
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Can one of the admins verify this patch? |
innosam
force-pushed
the
hsingh/regionmovenetworkresourcesettingsupdate
branch
from
931bfc5 to
b102b59
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
innosam
changed the title
innosam
force-pushed
the
hsingh/regionmovenetworkresourcesettingsupdate
branch
from
b102b59 to
9b64e50
Compare
|
Pull request contains merge conflicts. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
innosam
force-pushed
the
hsingh/regionmovenetworkresourcesettingsupdate
branch
from
312a335 to
55de293
Compare
|
Pull request contains merge conflicts. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
innosam
force-pushed
the
hsingh/regionmovenetworkresourcesettingsupdate
branch
from
3ead286 to
47ed816
Compare
|
Pull request contains merge conflicts. |
innosam
force-pushed
the
hsingh/regionmovenetworkresourcesettingsupdate
branch
from
47ed816 to
389fb23
Compare
…es and related models: Network Interfaces Network Security Groups Virtual Networks Loadbalancers Public IP
innosam
force-pushed
the
hsingh/regionmovenetworkresourcesettingsupdate
branch
from
77f8f40 to
f675c11
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
innosam
removed request for
JasonYang-MSFT,
Kishp01,
MS-syh2qs,
MehaKaushik,
Sandido,
Tiano2017,
ahamad-MS,
ankushbindlish2,
dkulkarni-ms,
grizzlytheodore,
haagha,
hitenjava,
jlichwa,
kasobol-msft,
kjeur,
madewithsmiles,
samedder,
shurd,
v-Ajnava,
wilcobmsft and
xingwu1
ArcturusZhang
added
BreakingChangeReviewRequired
Approved-BreakingChange
Member
|
approved breaking changes since this is a preview api within one year |
ArcturusZhang
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.