Skip to content

Comments

Remove cross-file references from SQL specs#1046

Merged
amarzavery merged 1 commit intoAzure:masterfrom
jaredmoo:crossfilereferences
Mar 17, 2017
Merged

Remove cross-file references from SQL specs#1046
amarzavery merged 1 commit intoAzure:masterfrom
jaredmoo:crossfilereferences

Conversation

@jaredmoo
Copy link
Contributor

@jaredmoo jaredmoo commented Mar 17, 2017

The cross-file references don't work in azure doc build system.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

  • I have read the contribution guidelines.
  • My spec meets the review criteria:
    • The spec conforms to the Swagger 2.0 specification.
    • Validation errors from the Linter extension for VS Code have all been fixed for this spec. (Note: for large, previously checked in specs, there will likely be many errors shown. Please contact our team so we can set a timeframe for fixing these errors if your PR is not going to address them).
    • The spec follows the patterns described in the Swagger good patterns document unless the service API makes this impossible.

@msftclas
Copy link

@jaredmoo,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@amarzavery amarzavery merged commit 8d6c3cf into Azure:master Mar 17, 2017
@AutorestCI
Copy link

No modification for NodeJS

@AutorestCI
Copy link

@AutorestCI
Copy link

@jaredmoo jaredmoo deleted the crossfilereferences branch July 8, 2017 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants