Skip to content

Conversation

@surashed
Copy link
Contributor

@surashed surashed commented Aug 13, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 13, 2020

[Staging] Swagger Validation Report

BreakingChange: 3 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1020 - AddedEnumValue The new version is adding enum value(s) 'SubAssessments' from the old version.
New: Microsoft.Security/preview/2019-01-01-preview/automations.json#L374:9
Old: Microsoft.Security/preview/2019-01-01-preview/automations.json#L371:9
1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: resource-manager/common/v1/types.json#L60:5
Old: resource-manager/common/v1/types.json#L60:5
1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: resource-manager/common/v1/types.json#L60:5
Old: resource-manager/common/v1/types.json#L60:5
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from e58a0d7 with merge commit ee2ca2f. SDK Automation 13.0.17.20200807.2
  • ️✔️@azure/arm-security [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/securityCenter.js → ./dist/arm-security.js...
    [npmPack] created ./dist/arm-security.js in 1s
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 4.8kB   esm/operations/adaptiveApplicationControls.js                          
    [npmPack] npm notice 634B    esm/models/adaptiveApplicationControlsMappers.js                       
    [npmPack] npm notice 7.9kB   esm/operations/adaptiveNetworkHardenings.js                            
    [npmPack] npm notice 3.1kB   esm/models/adaptiveNetworkHardeningsMappers.js                         
    [npmPack] npm notice 3.0kB   esm/operations/advancedThreatProtection.js                             
    [npmPack] npm notice 3.1kB   esm/models/advancedThreatProtectionMappers.js                          
    [npmPack] npm notice 13.7kB  esm/operations/alerts.js                                               
    [npmPack] npm notice 3.0kB   esm/models/alertsMappers.js                                            
    [npmPack] npm notice 5.5kB   esm/operations/alertsSuppressionRules.js                               
    [npmPack] npm notice 3.1kB   esm/models/alertsSuppressionRulesMappers.js                            
    [npmPack] npm notice 5.0kB   esm/operations/allowedConnections.js                                   
    [npmPack] npm notice 521B    esm/models/allowedConnectionsMappers.js                                
    [npmPack] npm notice 761.8kB dist/arm-security.js                                                   
    [npmPack] npm notice 297.4kB dist/arm-security.min.js                                               
    [npmPack] npm notice 5.3kB   esm/operations/assessments.js                                          
    [npmPack] npm notice 3.1kB   esm/models/assessmentsMappers.js                                       
    [npmPack] npm notice 7.7kB   esm/operations/assessmentsMetadata.js                                  
    [npmPack] npm notice 3.1kB   esm/models/assessmentsMetadataMappers.js                               
    [npmPack] npm notice 8.3kB   esm/operations/automations.js                                          
    [npmPack] npm notice 672B    esm/models/automationsMappers.js                                       
    [npmPack] npm notice 4.4kB   esm/operations/autoProvisioningSettings.js                             
    [npmPack] npm notice 3.1kB   esm/models/autoProvisioningSettingsMappers.js                          
    [npmPack] npm notice 3.3kB   esm/operations/complianceResults.js                                    
    [npmPack] npm notice 3.1kB   esm/models/complianceResultsMappers.js                                 
    [npmPack] npm notice 3.2kB   esm/operations/compliances.js                                          
    [npmPack] npm notice 3.1kB   esm/models/compliancesMappers.js                                       
    [npmPack] npm notice 5.1kB   esm/operations/connectors.js                                           
    [npmPack] npm notice 3.1kB   esm/models/connectorsMappers.js                                        
    [npmPack] npm notice 5.6kB   esm/operations/deviceSecurityGroups.js                                 
    [npmPack] npm notice 3.1kB   esm/models/deviceSecurityGroupsMappers.js                              
    [npmPack] npm notice 5.3kB   esm/operations/discoveredSecuritySolutions.js                          
    [npmPack] npm notice 498B    esm/models/discoveredSecuritySolutionsMappers.js                       
    [npmPack] npm notice 5.3kB   esm/operations/externalSecuritySolutions.js                            
    [npmPack] npm notice 704B    esm/models/externalSecuritySolutionsMappers.js                         
    [npmPack] npm notice 345B    esm/models/index.js                                                    
    [npmPack] npm notice 2.2kB   esm/operations/index.js                                                
    [npmPack] npm notice 4.9kB   esm/operations/informationProtectionPolicies.js                        
    [npmPack] npm notice 3.1kB   esm/models/informationProtectionPoliciesMappers.js                     
    [npmPack] npm notice 3.8kB   esm/operations/iotAlerts.js                                            
    [npmPack] npm notice 444B    esm/models/iotAlertsMappers.js                                         
    [npmPack] npm notice 3.0kB   esm/operations/iotAlertTypes.js                                        
    [npmPack] npm notice 3.1kB   esm/models/iotAlertTypesMappers.js                                     
    [npmPack] npm notice 4.9kB   esm/operations/iotDefenderSettings.js                                  
    [npmPack] npm notice 3.3kB   esm/models/iotDefenderSettingsMappers.js                               
    [npmPack] npm notice 3.9kB   esm/operations/iotRecommendations.js                                   
    [npmPack] npm notice 3.1kB   esm/models/iotRecommendationsMappers.js                                
    [npmPack] npm notice 3.2kB   esm/operations/iotRecommendationTypes.js                               
    [npmPack] npm notice 3.1kB   esm/models/iotRecommendationTypesMappers.js                            
    [npmPack] npm notice 8.9kB   esm/operations/iotSecuritySolution.js                                  
    [npmPack] npm notice 3.1kB   esm/operations/iotSecuritySolutionAnalytics.js                         
    [npmPack] npm notice 3.1kB   esm/models/iotSecuritySolutionAnalyticsMappers.js                      
    [npmPack] npm notice 598B    esm/models/iotSecuritySolutionMappers.js                               
    [npmPack] npm notice 5.3kB   esm/operations/iotSecuritySolutionsAnalyticsAggregatedAlert.js         
    [npmPack] npm notice 571B    esm/models/iotSecuritySolutionsAnalyticsAggregatedAlertMappers.js      
    [npmPack] npm notice 4.3kB   esm/operations/iotSecuritySolutionsAnalyticsRecommendation.js          
    [npmPack] npm notice 532B    esm/models/iotSecuritySolutionsAnalyticsRecommendationMappers.js       
    [npmPack] npm notice 5.0kB   esm/operations/iotSensors.js                                           
    [npmPack] npm notice 3.1kB   esm/models/iotSensorsMappers.js                                        
    [npmPack] npm notice 12.6kB  esm/operations/jitNetworkAccessPolicies.js                             
    [npmPack] npm notice 767B    esm/models/jitNetworkAccessPoliciesMappers.js                          
    [npmPack] npm notice 3.1kB   esm/operations/locations.js                                            
    [npmPack] npm notice 3.1kB   esm/models/locationsMappers.js                                         
    [npmPack] npm notice 220.6kB esm/models/mappers.js                                                  
    [npmPack] npm notice 2.2kB   esm/operations/operations.js                                           
    [npmPack] npm notice 465B    esm/models/operationsMappers.js                                        
    [npmPack] npm notice 17.9kB  esm/models/parameters.js                                               
    [npmPack] npm notice 3.4kB   esm/operations/pricings.js                                             
    [npmPack] npm notice 3.0kB   esm/models/pricingsMappers.js                                          
    [npmPack] npm notice 4.5kB   esm/operations/regulatoryComplianceAssessments.js                      
    [npmPack] npm notice 3.1kB   esm/models/regulatoryComplianceAssessmentsMappers.js                   
    [npmPack] npm notice 4.0kB   esm/operations/regulatoryComplianceControls.js                         
    [npmPack] npm notice 3.1kB   esm/models/regulatoryComplianceControlsMappers.js                      
    [npmPack] npm notice 3.6kB   esm/operations/regulatoryComplianceStandards.js                        
    [npmPack] npm notice 3.1kB   esm/models/regulatoryComplianceStandardsMappers.js                     
    [npmPack] npm notice 976B    rollup.config.js                                                       
    [npmPack] npm notice 4.1kB   esm/operations/secureScoreControlDefinitions.js                        
    [npmPack] npm notice 3.1kB   esm/models/secureScoreControlDefinitionsMappers.js                     
    [npmPack] npm notice 4.2kB   esm/operations/secureScoreControls.js                                  
    [npmPack] npm notice 3.1kB   esm/models/secureScoreControlsMappers.js                               
    [npmPack] npm notice 3.2kB   esm/operations/secureScores.js                                         
    [npmPack] npm notice 3.1kB   esm/models/secureScoresMappers.js                                      
    [npmPack] npm notice 5.2kB   esm/securityCenter.js                                                  
    [npmPack] npm notice 2.7kB   esm/securityCenterContext.js                                           
    [npmPack] npm notice 6.3kB   esm/operations/securityContacts.js                                     
    [npmPack] npm notice 3.1kB   esm/models/securityContactsMappers.js                                  
    [npmPack] npm notice 3.5kB   esm/operations/securitySolutions.js                                    
    [npmPack] npm notice 468B    esm/models/securitySolutionsMappers.js                                 

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from e58a0d7 with merge commit ee2ca2f. SDK Automation 13.0.17.20200807.2
  • ️✔️azure-mgmt-security [View full logs]  [Release SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-security
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-security
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 18.295% size of original (original: 166435 chars, delta: 30450 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model SecureScoreItem has a new parameter weight
    [ChangeLog]   - Added operation group SecuritySolutionsOperations
    [ChangeLog]   - Added operation group IotAlertTypesOperations
    [ChangeLog]   - Added operation group ConnectorsOperations
    [ChangeLog]   - Added operation group IotSensorsOperations
    [ChangeLog]   - Added operation group IotRecommendationsOperations
    [ChangeLog]   - Added operation group IotAlertsOperations
    [ChangeLog]   - Added operation group SecuritySolutionsReferenceDataOperations
    [ChangeLog]   - Added operation group IotRecommendationTypesOperations
    [ChangeLog]   - Added operation group IotDefenderSettingsOperations

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-resource-manager-schemas - Release

failed [Logs] [Expand Details]
  • Generate from e58a0d7 with merge commit ee2ca2f. Schema Automation 13.0.17.20200807.2
    [AutoRest] FATAL: System.InvalidOperationException: Values specified by 'enum' mismatch those specified by 'x-ms-enum' (name: 'ruleType'): 'ConnectionToIpNotAllowed', 'LocalUserNotAllowed', 'ProcessNotAllowed', 'ActiveConnectionsNotInAllowedRange', 'AmqpC2DMessagesNotInAllowedRange', 'MqttC2DMessagesNotInAllowedRange', 'HttpC2DMessagesNotInAllowedRange', 'AmqpC2DRejectedMessagesNotInAllowedRange', 'MqttC2DRejectedMessagesNotInAllowedRange', 'HttpC2DRejectedMessagesNotInAllowedRange', 'AmqpD2CMessagesNotInAllowedRange', 'MqttD2CMessagesNotInAllowedRange', 'HttpD2CMessagesNotInAllowedRange', 'DirectMethodInvokesNotInAllowedRange', 'FailedLocalLoginsNotInAllowedRange', 'FileUploadsNotInAllowedRange', 'QueuePurgesNotInAllowedRange', 'TwinUpdatesNotInAllowedRange', 'UnauthorizedOperationsNotInAllowedRange' vs 'ConnectionToIpNotAllowed', 'LocalUserNotAllowed', 'ProcessNotAllowed'
    [AutoRest]    at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /home/vsts/work/1/s/autorest.common/src/ObjectBuilder.cs:line 132
    [AutoRest]    at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in /home/vsts/work/1/s/autorest.common/src/SchemaBuilder.cs:line 222
    [AutoRest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /home/vsts/work/1/s/autorest.common/src/SchemaBuilder.cs:line 51
    [AutoRest]    at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in /home/vsts/work/1/s/autorest.common/src/SwaggerModeler.cs:line 349
    [AutoRest]    at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in /home/vsts/work/1/s/autorest.common/src/SwaggerModeler.cs:line 66
    [AutoRest]    at AutoRest.Modeler.ModelerPlugin.d__1.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Program.cs:line 43
    [AutoRest] --- End of stack trace from previous location where exception was thrown ---
    [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
    [AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/common/Plugins/NewPlugin.cs:line 164
    [AutoRest] Failure during batch task - {"tag":"package-composite-v1"} -- Error: Plugin imodeler2 reported failure..
    [AutoRest]   Error: Plugin imodeler2 reported failure.
    Failed to run autorest.
    Error: /z/node_modules/.bin/autorest --use=@autorest/[email protected] --version=3.0.6274 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/z/work/azure-resource-manager-schemas /z/work/azure-rest-api-specs/specification/security/resource-manager/readme.md FATAL: System.InvalidOperationException: Values specified by 'enum' mismatch those specified by 'x-ms-enum' (name: 'ruleType'): 'ConnectionToIpNotAllowed', 'LocalUserNotAllowed', 'ProcessNotAllowed', 'ActiveConnectionsNotInAllowedRange', 'AmqpC2DMessagesNotInAllowedRange', 'MqttC2DMessagesNotInAllowedRange', 'HttpC2DMessagesNotInAllowedRange', 'AmqpC2DRejectedMessagesNotInAllowedRange', 'MqttC2DRejectedMessagesNotInAllowedRange', 'HttpC2DRejectedMessagesNotInAllowedRange', 'AmqpD2CMessagesNotInAllowedRange', 'MqttD2CMessagesNotInAllowedRange', 'HttpD2CMessagesNotInAllowedRange', 'DirectMethodInvokesNotInAllowedRange', 'FailedLocalLoginsNotInAllowedRange', 'FileUploadsNotInAllowedRange', 'QueuePurgesNotInAllowedRange', 'TwinUpdatesNotInAllowedRange', 'UnauthorizedOperationsNotInAllowedRange' vs 'ConnectionToIpNotAllowed', 'LocalUserNotAllowed', 'ProcessNotAllowed'
       at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /home/vsts/work/1/s/autorest.common/src/ObjectBuilder.cs:line 132
       at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in /home/vsts/work/1/s/autorest.common/src/SchemaBuilder.cs:line 222
       at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /home/vsts/work/1/s/autorest.common/src/SchemaBuilder.cs:line 51
       at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in /home/vsts/work/1/s/autorest.common/src/SwaggerModeler.cs:line 349
       at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in /home/vsts/work/1/s/autorest.common/src/SwaggerModeler.cs:line 66
       at AutoRest.Modeler.ModelerPlugin.d__1.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Program.cs:line 43
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
       at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/common/Plugins/NewPlugin.cs:line 164
    Failure during batch task - {"tag":"package-composite-v1"} -- Error: Plugin imodeler2 reported failure..
      Error: Plugin imodeler2 reported failure.
    , {} 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@fengzhou-msft
Copy link
Member

Suppress the breaking change according to @mikreite, there are no official .Net SDK\PS\CLI for this API yet, the impact should be so small, if any.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 18, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fengzhou-msft fengzhou-msft merged commit ee2ca2f into Azure:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants