Skip to content

[Azure Automation] Swagger json files for rest of 15 resources and and changes to #1045

Merged
sarangan12 merged 23 commits into
Azure:masterfrom
AzureAutomationTeam:master
Apr 6, 2017
Merged

[Azure Automation] Swagger json files for rest of 15 resources and and changes to #1045
sarangan12 merged 23 commits into
Azure:masterfrom
AzureAutomationTeam:master

Conversation

@fearthecowboy
Copy link
Copy Markdown
Contributor

@fearthecowboy fearthecowboy commented Mar 17, 2017

Re-Creating PR for @vivlingaiah

@vivlingaiah -- You need to complete the following checklist, and fix the conflicts between the master branch and this PR (Pull from master into your local branch, fix the changes and push back into your fork on AzureAutomationTeam:master

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

  • I have read the contribution guidelines.
  • My spec meets the review criteria:
    • The spec conforms to the Swagger 2.0 specification.
    • Validation errors from the Linter extension for VS Code have all been fixed for this spec. (Note: for large, previously checked in specs, there will likely be many errors shown. Please contact our team so we can set a timeframe for fixing these errors if your PR is not going to address them).
    • The spec follows the patterns described in the Swagger good patterns document unless the service API makes this impossible.

Copy link
Copy Markdown
Contributor

@vishrutshah vishrutshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only reviewed arm-automation/2015-10-31/swagger/account.json from the PR so far

"$ref": "#/definitions/AutomationAccount"
}
},
"default": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct indentation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all indentations are corrected now.

],
"responses": {
"200": {
"description": "OK",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide descriptive descriptions

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Vishrut,
We have received exceptions for the below issues:
[Azure Automation] validations (size, range, regexes) on properties and parameters missing #1020
#1020
[Azure Automation] Descriptions need to be corrected in all Azure Automation resources #1021
#1021

Samer is aware of above issues. The two issues above will be revisited. These descriptions were inherited from Hyak specs and we won't be changing descriptions or validation regex at the moment
Leave a comment

"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/AutomationAccountCreateOrUpdateParameters"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

}
}
},
"put": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a long-running operation?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

"$ref": "#/definitions/AutomationAccount"
}
},
"default": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

},
"Usage": {
"properties": {
"id": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readOnly?

},
"unit": {
"type": "string",
"description": "Gets or sets the usage unit name."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide descriptive description so that users can understand this property. Applies for entire document.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a commentHi Vishrut,
We have received exceptions for the below issues:
[Azure Automation] validations (size, range, regexes) on properties and parameters missing #1020
#1020
[Azure Automation] Descriptions need to be corrected in all Azure Automation resources #1021
#1021

Samer is aware of above issues. The two issues above will be revisited. These descriptions were inherited from Hyak specs and we won't be changing descriptions or validation regex at the moment

"description": "Gets or sets the current usage value."
},
"limit": {
"type": "integer",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should use Minimum and Maximum constrains here

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a commentHi Vishrut,
We have received exceptions for the below issues:
[Azure Automation] validations (size, range, regexes) on properties and parameters missing #1020
#1020
[Azure Automation] Descriptions need to be corrected in all Azure Automation resources #1021
#1021

Samer is aware of above issues. The two issues above will be revisited. These descriptions were inherited from Hyak specs and we won't be changing descriptions or validation regex at the moment

"in": "path",
"required": true,
"type": "string",
"description": "Gets subscription credentials which uniquely identify Microsoft Azure subscription. The subscription ID forms part of the URI for every service call."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gets ??

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Vishrut,
We have received exceptions for the below issues:
[Azure Automation] validations (size, range, regexes) on properties and parameters missing #1020
#1020
[Azure Automation] Descriptions need to be corrected in all Azure Automation resources #1021
#1021

Samer is aware of above issues. The two issues above will be revisited. These descriptions were inherited from Hyak specs and we won't be changing descriptions or validation regex at the moment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @vishrutshah they have exceptions for fixing descriptions

"in": "path",
"required": true,
"type": "string",
"pattern": "^[-\\w\\._]+$",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

@vishrutshah
Copy link
Copy Markdown
Contributor

I'd request you please provide x-ms-example for your APIs. https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/x-ms-examples.md

@viveklingaiah
Copy link
Copy Markdown
Contributor

Hi Vishrut,
We have received exceptions for the below issues:
[Azure Automation] validations (size, range, regexes) on properties and parameters missing  #1020
#1020
[Azure Automation] Descriptions need to be corrected in all Azure Automation resources  #1021
#1021

Samer is aware of above issues. The two issues above will be revisited. These descriptions were inherited from Hyak specs and we won't be changing descriptions or validation regex at the moment

@viveklingaiah
Copy link
Copy Markdown
Contributor

More importantly, I need help your help with below issues.
Issue 1:
couple of operations need to automatically generate new Guid each time. Is there a way to do it in Swagger ? This swagger was auto-generated using Hyak specs. Could you confirm this is correct way to auto-generate new guid on each invocation of operation ?
uuid

@viveklingaiah
Copy link
Copy Markdown
Contributor

Issue 2: The issue is AutoRest command that generates “Generated” files adds member Credentials (Credentials needed for the client to connect to Azure.) Co-Incidentally, we also have an API “Credentials” due to which two members have name conflicts. Could you let us know how to resolve this issue? I’ve attached the concerned files for your reference. (Forwarded the .cs files in reference to Vishrut). There is a name conflict. Two "Credentials" can be found

credentialspath

@vishrutshah
Copy link
Copy Markdown
Contributor

#Issue 2 is coming from https://github.com/Azure/azure-rest-api-specs/pull/1045/files#diff-bf0e1b6e54180951dd6138234a55f3c4R239 : operationId should be PsCredentials_List.

@vishrutshah
Copy link
Copy Markdown
Contributor

Issue 1: Yes AutoRest should generate guid for you. Ref: Azure/autorest#784

@salameer
Copy link
Copy Markdown
Member

@vivlingaiah just to be clear xms-examples are not covered in the exceptions, just wanted to make sure that we're on the same page here

Copy link
Copy Markdown
Contributor

@vishrutshah vishrutshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed arm-automation/2015-10-31/swagger/certificate.json. Please fix indentation across the swagger files

],
"responses": {
"200": {
"description": "OK"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PUT/GET/PATCH operations must have same schema response - I see patch is not returning Certificate.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

"tags": [
"Certificates"
],
"operationId": "Certificates_List",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_ListByAutomationAccounts?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

"properties": {
"base64Value": {
"type": "string",
"description": "Gets or sets the base64 encoded value of the certificate."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gets or Sets MUST not appear in entire swagger.

"type": "string",
"description": "Gets or sets the thumbprint of the certificate."
},
"isExportable": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this readOnly?

"type": "string",
"description": "Gets or sets the description of the certificate."
},
"thumbprint": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this readOnly?

"type": "string",
"description": "Gets or sets the thumbprint of the certificate."
},
"expiryTime": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this updatable?

"type": "boolean",
"description": "Gets or sets the is exportable flag of the certificate."
},
"creationTime": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readOnly?

"format": "date-time",
"description": "Gets or sets the creation time."
},
"lastModifiedTime": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readOnly?

},
"lastModifiedTime": {
"type": "string",
"format": "date-time",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the date-time format? ISO8601?

},
"description": "Properties of the certificate."
},
"Certificate": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a tracked resource?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

Copy link
Copy Markdown
Contributor

@vishrutshah vishrutshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed arm-automation/2015-10-31/swagger/connection.json. Please update indentation and provide accurate descriptions.

Also please provide x-ms-example for each of the operation

],
"responses": {
"200": {
"description": "OK"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch MUST return #/definitions/Connection schema

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

"tags": [
"Connections"
],
"operationId": "Connections_List",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_ListByAutomationAccounts

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccount}/connections": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you have

List - BySubscription &
ListByResourceGroup for this tracked resource?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a tracked resource. corrected naming of methods

},
"connectionType": {
"$ref": "#/definitions/ConnectionTypeAssociationProperty",
"description": "Gets or sets the connectionType of the connection."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gets or Sets MUST not appear in the swagger. Documentation will not be good.

"description": "Gets or sets the field definition values of the connection."
},
"creationTime": {
"type": "string",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readOnly?

"format": "date-time",
"description": "Gets or sets the creation time."
},
"lastModifiedTime": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readOnly?

},
"description": "Definition of the connection properties."
},
"Connection": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a tracked/Proxy Resource? Should it inherit from the common Resource model having id, name, type as readOnly?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a tracked resource

"Connection": {
"properties": {
"id": {
"type": "string",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readOnly?

}
}
},
"/{subscriptionId}/operations/{requestId}": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the API supported & maintained by your team?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not supported. I removed it

}
],
"responses": {
"201": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when do you return 201 v/s 200? Seems like both return the same model?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

@sarangan12
Copy link
Copy Markdown
Contributor

The following operation names are violating the rules:

  1. Statistics_ListByAutomationAccount
  2. Usages_ListByAutomationAccount
  3. Certificates_ListByAutomationAccount
  4. Connections_ListByAutomationAccount
  5. ConnectionTypes_ListByAutomationAccount
  6. PsCredentials_ListByAutomationAccount
  7. Jobs_ListByAutomationAccount
  8. JobStreams_ListByJob
  9. Activities_ListByModule
  10. Modules_ListByAutomationAccount
  11. Fields_ListByType
  12. Runbooks_ListByAutomationAccount
  13. TestJobStreams_ListByTestJob
  14. Schedules_ListByAutomationAccount
  15. JobSchedules_ListByAutomationAccount
  16. Variables_ListByAutomationAccount
  17. Webhooks_ListByAutomationAccount
  18. CompilationJobs_ListByAutomationAccount
  19. Configurations_ListByAutomationAccount
  20. Nodes_ListByAutomationAccount
  21. NodeReports_ListByNode
  22. NodeConfigurations_ListByAutomationAccount
  23. HybridRunbookWorkerGroups_ListByAutomationAccount

@vivlingaiah Can you confirm if you have exceptions approved for all of these?

@sarangan12
Copy link
Copy Markdown
Contributor

sarangan12 commented Apr 3, 2017

A body parameter must be named 'parameters'. The following paths are violating the rule:

  1. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/patch/parameters[3]
  2. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/put/parameters[3]
  3. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/certificates/{certificateName}/put/parameters[4]
  4. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/connections/{connectionName}/put/parameters[4]
  5. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/connections/{connectionName}/patch/parameters[4]
  6. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/connectionTypes/{connectionTypeName}/put/parameters[4]
  7. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/modules/{moduleName}/put/parameters[4]
  8. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/modules/{moduleName}/patch/parameters[4]
  9. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/runbooks/{runbookName}/draft/content/put/parameters[4]
  10. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/runbooks/{runbookName}/put/parameters[4]
  11. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/runbooks/{runbookName}/draft/testJob/put/parameters[4]
  12. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/schedules/{scheduleName}/put/parameters[4]
  13. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/schedules/{scheduleName}/patch/parameters[4]
  14. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/jobSchedules/{jobScheduleId}/put/parameters[4]
  15. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/variables/{variableName}/put/parameters[4]
  16. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/variables/{variableName}/patch/parameters[4]
  17. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/webhooks/{webhookName}/put/parameters[4]
  18. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/webhooks/{webhookName}/patch/parameters[4]
  19. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/compilationjobs/{compilationJobId}/put/parameters[4]
  20. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/agentRegistrationInformation/regenerateKey/post/parameters[3]
  21. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/nodeConfigurations/{nodeConfigurationName}/put/parameters[4]
  22. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/certificates/{certificateName}/patch/parameters[4]
  23. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/credentials/{credentialName}/put/parameters[4]
    24: Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/credentials/{credentialName}/patch/parameters[4]
  24. Path: #/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/runbooks/{runbookName}/patch/parameters[4]

@sarangan12
Copy link
Copy Markdown
Contributor

One of the rule is that "Parameters "subscriptionId" and "api-version" are not allowed in the operations section, define these in the global parameters section instead". There are several paths which violate the rule: https://gist.github.com/sarangan12/e5ffe03d76cbaccbcceba2060c2dec8d#file-gistfile1-txt

@sarangan12
Copy link
Copy Markdown
Contributor

ERROR: A 'POST' operation 'RunbookDraft_Publish' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 201 or 204.
Path: file:///C:/workspace/azure-rest-api-specs/arm-automation/compositeAutomation.json#/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/runbooks/{runbookName}/draft/publish/post/extensions/x-ms-long-running-operation

@sarangan12
Copy link
Copy Markdown
Contributor

ERROR: The property 'odata.nextLink' specified by nextLinkName does not exist in the 200 response schema.
Path: file:///C:/workspace/azure-rest-api-specs/arm-automation/compositeAutomation.json#/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/hybridRunbookWorkerGroups/get/extensions/x-ms-pageable

@sarangan12
Copy link
Copy Markdown
Contributor

ERROR: Tracked Resource failing validation is: "DscConfiguration". Validation Failed: 2.
A Tracked Resource must have:
1. A Get Operation
2. A ListByResourceGroup operation with x-ms-pageable extension and
3. A ListBySubscriptionId operation with x-ms-pageable extension.
4. "type","location","tags" should not be used in the RP property bag named "properties".
Path: file:///C:/workspace/azure-rest-api-specs/arm-automation/compositeAutomation.json#/definitions
ERROR: Tracked resource 'DscConfiguration' must have patch operation that at least supports the update of tags.
Path: file:///C:/workspace/azure-rest-api-specs/arm-automation/compositeAutomation.json#/definitions

@viveklingaiah viveklingaiah force-pushed the master branch 2 times, most recently from 0552348 to e4dc90d Compare April 3, 2017 23:15
@viveklingaiah
Copy link
Copy Markdown
Contributor

Hi Sarangan,

@sarangan12 sarangan12 dismissed vishrutshah’s stale review April 6, 2017 21:59

Dismissing. Assigned to me

@sarangan12 sarangan12 merged commit 84aaf9c into Azure:master Apr 6, 2017
@AutorestCI
Copy link
Copy Markdown

No modification for Ruby

1 similar comment
@AutorestCI
Copy link
Copy Markdown

No modification for Ruby

@AutorestCI
Copy link
Copy Markdown

No modification for Python

@AutorestCI
Copy link
Copy Markdown

No modification for NodeJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants