Skip to content

[Hub Generated] Review request for Microsoft.CostManagement to add version preview/2020-03-01-preview #10407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njuCZ merged 55 commits into from
Aug 21, 2020
Merged

[Hub Generated] Review request for Microsoft.CostManagement to add version preview/2020-03-01-preview #10407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
661ebb8
Adds base for updating Microsoft.CostManagement from version preview/…
zachraMSFT Jun 11, 2020
727e1f4
Updates readme
zachraMSFT Jun 11, 2020
6c98a4f
Updates API version in new specs and examples
zachraMSFT Jun 11, 2020
ba3043d
Sync to private repo change set
zachraMSFT Jun 11, 2020
7d59c8d
Fix warnings
zachraMSFT Jun 12, 2020
eba5f4b
Fix example for string over boolean
zachraMSFT Jun 12, 2020
0dca2aa
List operation id fix
zachraMSFT Jun 12, 2020
cd1b1af
Implement changes from review
zachraMSFT Jun 12, 2020
95f71bc
Fix response types
zachraMSFT Jun 12, 2020
193c633
Only one tag
zachraMSFT Jun 12, 2020
da876f5
Fix failures
zachraMSFT Jun 12, 2020
6740f12
Fix operation Ids
zachraMSFT Jun 12, 2020
f4a466d
Just CostAllocation
zachraMSFT Jun 12, 2020
5ac1d56
Percentage as number
zachraMSFT Jun 13, 2020
fb2744e
Revert to working version
zachraMSFT Jun 13, 2020
88b6801
First wave of review changes
zachraMSFT Jun 13, 2020
0f7f59c
ruleName in examples
zachraMSFT Jun 13, 2020
c89db65
Percentage as number, example for tag
zachraMSFT Jun 13, 2020
8b3b0df
ruleName in tag example
zachraMSFT Jun 13, 2020
56de5cf
Add nesting for list
zachraMSFT Jun 13, 2020
6c3be4b
More changes
zachraMSFT Jun 13, 2020
bf0d063
Fix example name
zachraMSFT Jun 13, 2020
d139ee6
Update tags/summary setup
zachraMSFT Jun 13, 2020
a19bb98
Update based on review
zachraMSFT Jun 14, 2020
122c520
Complete changes for API review
zachraMSFT Jun 15, 2020
e6070d8
remove tags
zachraMSFT Jun 15, 2020
b1eed58
fix response model, restore tag
zachraMSFT Jun 15, 2020
788a09a
Add 204 to example
zachraMSFT Jun 15, 2020
6ac27f6
Remove actual next link until implemented
zachraMSFT Jun 15, 2020
2fc8414
Improve naming
zachraMSFT Jun 15, 2020
2f28e6e
restore paging
zachraMSFT Jun 16, 2020
712ec91
fixes found in review
zachraMSFT Jun 16, 2020
4152713
Reduce duplication of definition object
zachraMSFT Jun 16, 2020
45fad22
camelcase checkname url
zachraMSFT Jun 16, 2020
27dc73b
Make one type limitation clearer
zachraMSFT Jun 16, 2020
40adb35
Use enum descriptions
zachraMSFT Jun 24, 2020
03d8aca
Add created/updated date to response contract
zachraMSFT Jul 6, 2020
cc97daf
minor style fix
zachraMSFT Jul 6, 2020
3d0c867
Fix examples
zachraMSFT Jul 6, 2020
582aaa6
Improve messages
zachraMSFT Aug 3, 2020
063b686
Merge branch 'master' into dev-cost-management-Microsoft.CostManageme…
zachraMSFT Aug 11, 2020
df9e50b
Remove correlation id, run prettier
zachraMSFT Aug 12, 2020
ac4c6c2
Merge branch 'dev-cost-management-Microsoft.CostManagement-2020-03-01…
zachraMSFT Aug 12, 2020
5e60c52
Fix error format
zachraMSFT Aug 12, 2020
2c6b61c
Rename new files to costallocation.
zachraMSFT Aug 13, 2020
68a214a
Include additional json in readme
zachraMSFT Aug 14, 2020
16b4675
Remove items that aren't changing versions
zachraMSFT Aug 14, 2020
f60d21b
Use 2020-06-01 to avoid lint errors
zachraMSFT Aug 14, 2020
7d05743
Fix more object mismatches
zachraMSFT Aug 14, 2020
032ba6b
Match parameter descriptions
zachraMSFT Aug 14, 2020
5141fda
Remove request/response differences
zachraMSFT Aug 19, 2020
73d093a
Fix semantics
zachraMSFT Aug 19, 2020
2bf0282
Fix readonly setup
zachraMSFT Aug 20, 2020
12494b4
Remove format from readonly field
zachraMSFT Aug 20, 2020
6be6f49
Fix capitalization
zachraMSFT Aug 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
601 changes: 601 additions & 0 deletions .../resource-manager/Microsoft.CostManagement/preview/2020-03-01-preview/costallocation.json
View file
Open in desktop

Large diffs are not rendered by default.

19 changes: 19 additions & 0 deletions ...nagement/preview/2020-03-01-preview/examples/CostAllocationRuleCheckNameAvailability.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"parameters": {
"api-version": "2020-03-01-preview",
"billingAccountId": "100",
"costAllocationRuleCheckNameAvailabilityRequest": {
"name": "testRule",
"type": "Microsoft.CostManagement/costAllocationRules"
}
},
"responses": {
"200": {
"body": {
"nameAvailable": false,
"reason": "AlreadyExists",
"message": "A cost allocation rule with name testRule is already present for the billing account 100. Please specify a differnt name."
}
}
}
}
85 changes: 85 additions & 0 deletions ...icrosoft.CostManagement/preview/2020-03-01-preview/examples/CostAllocationRuleCreate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
{
"parameters": {
"api-version": "2020-03-01-preview",
"billingAccountId": "100",
"ruleName": "testRule",
"costAllocationRule": {
"properties": {
"description": "This is a testRule",
"status": "Active",
"details": {
"sourceResources": [
{
"resourceType": "Dimension",
"name": "ResourceGroupName",
"values": [
"sampleRG",
"secondRG"
]
}
],
"targetResources": [
{
"resourceType": "Dimension",
"policyType": "FixedProportion",
"name": "ResourceGroupName",
"values": [
{
"name": "destinationRG",
"percentage": 45
},
{
"name": "destinationRG2",
"percentage": 54
}
]
}
]
}
}
}
},
"responses": {
"200": {
"body": {
"id": "providers/Microsoft.Billing/billingAccounts/100/providers/Microsoft.CostManagement/costAllocationRules/testRule",
"name": "testRule",
"type": "Microsoft.CostManagement/costAllocationRules",
"properties": {
"description": "This is a testRule",
"createdDate": "2020-06-18T22:21:51.1287144Z",
"updatedDate": "2020-06-18T22:21:51.1287144Z",
"status": "Creating",
"details": {
"sourceResources": [
{
"resourceType": "Dimension",
"name": "ResourceGroupName",
"values": [
"sampleRG"
]
}
],
"targetResources": [
{
"resourceType": "Dimension",
"policyType": "FixedProportion",
"name": "ResourceGroupName",
"values": [
{
"name": "destinationRG",
"percentage": 50
},
{
"name": "destinationRG2",
"percentage": 50
}
]
}
]
}
}
}
}
}
}
88 changes: 88 additions & 0 deletions ...osoft.CostManagement/preview/2020-03-01-preview/examples/CostAllocationRuleCreateTag.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
{
"parameters": {
"api-version": "2020-03-01-preview",
"billingAccountId": "100",
"ruleName": "testRule",
"costAllocationRule": {
"properties": {
"description": "This is a testRule",
"status": "Active",
"details": {
"sourceResources": [
{
"resourceType": "Tag",
"name": "category",
"values": [
"devops"
]
}
],
"targetResources": [
{
"resourceType": "Dimension",
"policyType": "FixedProportion",
"name": "ResourceGroupName",
"values": [
{
"name": "destinationRG",
"percentage": 33.33
},
{
"name": "destinationRG2",
"percentage": 33.33
},
{
"name": "destinationRG3",
"percentage": 33.34
}
]
}
]
}
}
}
},
"responses": {
"200": {
"body": {
"id": "providers/Microsoft.Billing/billingAccounts/100/providers/Microsoft.CostManagement/costAllocationRules/testRule",
"name": "testRule",
"type": "Microsoft.CostManagement/costAllocationRules",
"properties": {
"description": "This is a testRule",
"createdDate": "2020-06-18T22:21:51.1287144Z",
"updatedDate": "2020-06-18T22:21:51.1287144Z",
"status": "Creating",
"details": {
"sourceResources": [
{
"resourceType": "Dimension",
"name": "ResourceGroupName",
"values": [
"sampleRG"
]
}
],
"targetResources": [
{
"resourceType": "Dimension",
"policyType": "FixedProportion",
"name": "ResourceGroupName",
"values": [
{
"name": "destinationRG",
"percentage": 50
},
{
"name": "destinationRG2",
"percentage": 50
}
]
}
]
}
}
}
}
}
}
11 changes: 11 additions & 0 deletions ...icrosoft.CostManagement/preview/2020-03-01-preview/examples/CostAllocationRuleDelete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"parameters": {
"api-version": "2020-03-01-preview",
"billingAccountId": "100",
"ruleName": "testRule"
},
"responses": {
"200": {},
"204": {}
}
}
50 changes: 50 additions & 0 deletions ...r/Microsoft.CostManagement/preview/2020-03-01-preview/examples/CostAllocationRuleGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
{
"parameters": {
"api-version": "2020-03-01-preview",
"billingAccountId": "100",
"ruleName": "testRule"
},
"responses": {
"200": {
"body": {
"id": "providers/Microsoft.Billing/billingAccounts/100/providers/Microsoft.CostManagement/costAllocationRules/testRule",
"name": "testRule",
"type": "Microsoft.CostManagement/costAllocationRules",
"properties": {
"description": "This is a testRule",
"createdDate": "2020-06-18T22:21:51.1287144Z",
"updatedDate": "2020-06-18T22:21:51.1287144Z",
"status": "NotActive",
"details": {
"sourceResources": [
{
"resourceType": "Dimension",
"name": "ResourceGroupName",
"values": [
"sampleRG"
]
}
],
"targetResources": [
{
"resourceType": "Dimension",
"policyType": "FixedProportion",
"name": "ResourceGroupName",
"values": [
{
"name": "destinationRG",
"percentage": 50
},
{
"name": "destinationRG2",
"percentage": 50
}
]
}
]
}
}
}
}
}
}
128 changes: 128 additions & 0 deletions ...Microsoft.CostManagement/preview/2020-03-01-preview/examples/CostAllocationRulesList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
{
"parameters": {
"api-version": "2020-03-01-preview",
"billingAccountId": "100"
},
"responses": {
"200": {
"body": {
"value": [
{
"id": "providers/Microsoft.Billing/billingAccounts/100/providers/Microsoft.CostManagement/costAllocationRules/testRule",
"name": "testRule",
"type": "Microsoft.CostManagement/costAllocationRules",
"properties": {
"description": "This is a testRule",
"createdDate": "2020-06-18T22:21:51.1287144Z",
"updatedDate": "2020-06-18T22:21:51.1287144Z",
"status": "NotActive",
"details": {
"sourceResources": [
{
"resourceType": "Dimension",
"name": "ResourceGroupName",
"values": [
"sampleRG"
]
}
],
"targetResources": [
{
"resourceType": "Dimension",
"policyType": "FixedProportion",
"name": "ResourceGroupName",
"values": [
{
"name": "destinationRG",
"percentage": 50
},
{
"name": "destinationRG2",
"percentage": 50
}
]
}
]
}
}
},
{
"id": "providers/Microsoft.Billing/billingAccounts/100/providers/Microsoft.CostManagement/costAllocationRules/testRule2",
"name": "testRule2",
"type": "Microsoft.CostManagement/costAllocationRules",
"properties": {
"description": "This is a second test Rule",
"createdDate": "2020-06-18T22:21:51.1287144Z",
"updatedDate": "2020-06-18T22:21:51.1287144Z",
"status": "Active",
"details": {
"sourceResources": [
{
"resourceType": "Dimension",
"name": "SubscriptionId",
"values": [
"2A002F2D-536F-4D7C-90DA-3D0BAE879B0E"
]
}
],
"targetResources": [
{
"resourceType": "Tag",
"policyType": "FixedProportion",
"name": "category",
"values": [
{
"name": "devops",
"percentage": 100
}
]
}
]
}
}
},
{
"id": "providers/Microsoft.Billing/billingAccounts/100/providers/Microsoft.CostManagement/costAllocationRules/testRule3",
"name": "testRule3",
"type": "Microsoft.CostManagement/costAllocationRules",
"properties": {
"description": "This is a third test Rule",
"createdDate": "2020-06-18T22:21:51.1287144Z",
"updatedDate": "2020-06-18T22:21:51.1287144Z",
"status": "Active",
"details": {
"sourceResources": [
{
"resourceType": "Tag",
"name": "category",
"values": [
"devops"
]
}
],
"targetResources": [
{
"resourceType": "Dimension",
"policyType": "FixedProportion",
"name": "ResourceGroupName",
"values": [
{
"name": "ResourceGroup",
"percentage": 55.55
},
{
"name": "ResourceGroupSecond",
"percentage": 44.45
}
]
}
]
}
}
}
],
"nextLink": null
}
}
}
}
Loading